summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2009-07-19Fix a few type errors in VFS modulesVolker Lendecke6-10/+18
2009-07-17Fix Coverity CIDs 887, 888. Don't pass NULL's to functionsJeremy Allison1-4/+3
that deref them. Jeremy.
2009-07-17Fix Coverity CID 928. Removed check as this can never be null.Jeremy Allison1-1/+1
Jeremy.
2009-07-17Fix Coverity CID 929. Potential NULL deref after code refactoring.Jeremy Allison1-0/+5
Jeremy.
2009-07-17Fix coverity CID 930. Pointer check can never be null here.Jeremy Allison1-1/+1
Jeremy
2009-07-17Fix coverity CID 931. This check is redundent as smb_fname canJeremy Allison1-1/+1
never be null in this function. Jeremy.
2009-07-17Fix a typo reading uninitialized memory. Caught by valgrind.Jeremy Allison1-3/+1
Jeremy.
2009-07-17Move the initialization of smbd_server_conn from smbd/process,Jeremy Allison2-5/+5
after the accept and fork, to smbd_init_globals(), so it's done immediately on server startup. This is needed as some messages are sent to all active smbd processes (including the master listening daemon). If it gets a message that forces it to scan it's current connections (ie. conn_find()) then it discovers that sconn->smb1.tcons.Connections dereferences null (as sconn == NULL in the parent) and crashes. Yes, I could fix all cases where sconn is used and explicitly check for NULL but this fix is easier. It means that the smbd_event_context() is initialized in the master daemon and then re-initialized after fork, but that should be being done correctly in every fork call anyway. Without this change the previous fix 6a9e0039100b57f9626e87defec6720c476b9789 still panics in the reproducible test case for bug 6564, as this is one case where such a message (MSG_SMB_CONF_UPDATED) is sent to the parent. Metze please check. This change passes valgrind. Jeremy.
2009-07-17Fix bug #6564 - SetPrinter fails (panics) as non root.Jeremy Allison2-0/+5
Missing become_root()/unbecome_root() around reload_services. Jeremy.
2009-07-17s3-rpcclient: add createprinteric command.Günther Deschner1-0/+43
Guenther
2009-07-17s3-lsa: let _lsa_Delete return NT_STATUS_NOT_SUPPORTED as w2k3 does.Günther Deschner1-6/+10
Guenther
2009-07-17s3-lsa: Fix access_mask calculation for new handle in _lsa_CreateAccount().Günther Deschner1-6/+24
Guenther
2009-07-17s3-lsa: add (not yet activate) level specific access checks for ↵Günther Deschner1-0/+42
_lsa_QueryInfoPolicy. Guenther
2009-07-17s3-lsa: also implement level 13 in lsa_QueryInfoPolicy.Günther Deschner1-19/+24
Guenther
2009-07-17s3-lsa: Fix policy handle memleak and handle type check in _lsa_DeleteObject().Günther Deschner1-4/+14
Guenther
2009-07-17s3-rpcclient: add LSA storeprivatedata command.Günther Deschner1-0/+56
Guenther
2009-07-17s3-rpcclient: add LSA retrieveprivatedata command.Günther Deschner1-0/+60
Guenther
2009-07-17s3-rpcclient: add LSA setsecret command.Günther Deschner1-0/+71
Guenther
2009-07-17s3-rpcclient: add LSA querysecret command.Günther Deschner1-0/+86
Guenther
2009-07-17s3-rpcclient: add LSA deletesecret command.Günther Deschner1-0/+50
Guenther
2009-07-17s3-rpcclient: add LSA createsecret command.Günther Deschner1-0/+43
Guenther
2009-07-18s3: compile warning and upn handlingBo Yang2-1/+7
Signed-off-by: Bo Yang <boyang@samba.org>
2009-07-18s3: don't do this, upper callbacks will check itBo Yang1-4/+0
Signed-off-by: Bo Yang <boyang@samba.org>
2009-07-18s3: Fix crsh in net usershare listBo Yang1-0/+1
Signed-off-by: Bo Yang <boyang@samba.org>
2009-07-16More conversions of NULL -> talloc_autofree_context()Jeremy Allison3-19/+24
so we at least know when we're using a long-lived context. Jeremy.
2009-07-16Replace more long-lived contexts with talloc_autofree_context().Jeremy Allison2-2/+2
Jeremy.
2009-07-16Replace short-lived NULL talloc contexts with talloc_tos().Jeremy Allison3-22/+22
Jeremy.
2009-07-16Remove an unused talloc context.Jeremy Allison1-8/+2
Jeremy.
2009-07-17s3-lsa: Fix pointless check for sec_info flags in _lsa_QuerySecurity().Günther Deschner1-13/+3
Guenther
2009-07-17s3-lsa: implement _lsa_LookupPrivName().Günther Deschner1-6/+45
Guenther
2009-07-17s3-lsa: implement _lsa_EnumAccountsWithUserRight().Günther Deschner1-6/+57
Guenther
2009-07-16Tidyup prompted by #6554 - Wrong deallocation in sam_account_ok.Jeremy Allison1-2/+3
Jeremy.
2009-07-16s3-rpc_parse: remove more unused code.Günther Deschner2-334/+0
Guenther
2009-07-16s3-spoolss: make some of the command hooks static.Günther Deschner2-6/+3
Guenther
2009-07-15Fix bug #6551 - win98 clients cannot connect after server upgrade to ↵Jeremy Allison2-0/+3
samba-3.4.0. The values of vuid and tid were not being correctly updated in the struct smb_request when passed to chain_reply inside sessionsetupX and tconX. Jeremy.
2009-07-15s3:smbd: try to fix a compiler warning on i386 : left shift count >= width ↵Stefan Metzmacher1-1/+1
of type metze
2009-07-15s3:libsmb: we need to include "includes.h" as first header to let code build ↵Stefan Metzmacher1-1/+1
on all platforms This should fix the Tru64 build. metze
2009-07-15s3:tldap: fix the build - a void function should not return a valueStefan Metzmacher1-3/+3
metze
2009-07-15Make cli_unlock and cli_unlock64 async. Fix POSIX lock test.Jeremy Allison5-91/+247
Jeremy.
2009-07-15s3: make linking of rpcclient --as-needed safeBjörn Jacke1-2/+2
2009-07-15s3: make linking of cifs.upcall --as-needed safePeter Volkov1-1/+1
See http://www.gentoo.org/proj/en/qa/asneeded.xml for details.
2009-07-15s3:dbwrap: fix embarrassing typo :-)Michael Adam1-1/+1
Michael
2009-07-15s3:registry: db backend: add my CMichael Adam1-0/+1
Michael
2009-07-15s3:registry: flush the provided subkey_ctr in regdb_fetch_keys_internal()Michael Adam1-0/+3
This way, we always return what has really been read from the db, and not more. The callers assume exactly this, but one could hand in an already pre-filled subkey container... Michael
2009-07-15s3:registry: add function regsubkey_ctr_reinit()Michael Adam2-0/+24
This reinitializes an already allocated regsubkey_ctr structure, emptying out the subkey array and hash table. Michael
2009-07-15s3:registry: turn regdb_fetch_keys_internal() from int to WERROR return typeMichael Adam1-32/+53
This way, more error information is propagated to the callers. Michael
2009-07-15s3:registry: use transaction wrapper in create_sorted_subkeys()Michael Adam1-48/+51
Michael
2009-07-15s3:registry: restructure logic of create_sorted_subkes() slightlyMichael Adam1-14/+19
This makes it clearer to me, and it also makes it easier to use the transaction retry wrapper in the next step. Michael
2009-07-15s3:registry: use transaction wrapper in regdb_delete_subkey().Michael Adam1-37/+49
Michael
2009-07-15s3:registry: add a comment header for the delete_subkey set of commands.Michael Adam1-0/+4
Michael