summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2009-11-03Fix debug statements to use correct function name.Jeremy Allison1-13/+13
Jeremy.
2009-11-03requires_resume_key is a bool not int.Jeremy Allison1-7/+2
Jeremy.
2009-11-03Fix more of the RAW-SEARCH test. Older info levels areJeremy Allison1-2/+9
not 4 byte aligned (levels 1 - 3). Jeremy.
2009-11-03s3: Remove debug_ctx()Volker Lendecke13-86/+70
smbd just crashed on me: In a debug message I called a routine preparing a string that itself used debug_ctx. The outer routine also used it after the inner routine had returned. It was still referencing the talloc context that the outer debug_ctx() had given us, which the inner DEBUG had already freed.
2009-11-02Convert from numbers to correct SMB_FIND_XX constant names.Jeremy Allison1-8/+12
Jeremy.
2009-11-03s3:registry: add an extra check for dsize==0 to regdb_fetch_keys_internal()Michael Adam1-1/+1
Don't only rely on dptr == NULL. I stumbled over this one when rewriting some of the dbwrap_ctdb code. Michael
2009-11-03s3:registry: add safety check for return value of tdb_unpack to ↵Michael Adam1-0/+4
regdb_fetch_keys_internal() Prevents segfaults in some situations. (For a non existent or empty record, we sometimes rely on the fetch operation to return dsize==0 and sometimes we rely on dptr==NULL.) Michael
2009-11-03s3:dbwrap_ctdb: add debug message to transaction_fetch_start()Michael Adam1-0/+4
for the case that another local process has started a transaction bewteen releasing the transaction_lock record and starting the transaction. Michael
2009-11-03s3:dbwrap_ctdb: split combined check in two and add descriptive debugMichael Adam1-1/+14
in db_ctdb_transaction_fetch_start() for error conditions when re-fetching the transaction_lock record inside the transaction Michael
2009-11-03s3:dbwrap_ctdb: fix race condition with concurrent transactions on the same ↵Michael Adam1-0/+12
node. In ctdb_transaction_commit(), when the trans2_commit control fails, there is a race condition in the 1 second sleep between the local transaction_cancel and the call to ctdb_replay_transaction(): The database is not locked, and neither is the transaction_lock record. So another client can start and possibly complete a new transaction in this gap, but only on the same node: The locking of the transaction_lock record on a different node which involves migration of the record to the other node has been disabled by introduction of the transaction_active flag on the db which closes precisely this gap from the start of the commit until the call to TRANS2_FINISH or TRANS2_ERROR. But this mechanism does not cover the case where a process on the same node tries to start a transaction: There is no obstacle to locking the transaction_lock record because the record does not need to be migrated. This commit closes this race condition in ctdb_transaction_fetch_start() by using the new ctdb_ctrl_transaction_active() call to ask the local ctdb daemon whether it has a transaction running on the database. If so, the check is repeated until the running transaction is done. This does introduce an additional call to the local ctdbd when starting transactions, but it does close the (hopefully) last race condition. Michael
2009-11-03s3:configure: add a check for the new CTDB_CONTROL_TRANS2_ACTIVEMichael Adam1-0/+17
Michael
2009-11-03s3:dbwrap_ctdb: add new db_ctdb_transaction_active() that calls ↵Michael Adam1-0/+21
CTDB_CONTROL_TRANS2_COMMIT Michael
2009-11-03s3:dbwrap_ctdb: fix a race in starting concurrent transactions on a single nodeMichael Adam1-0/+25
There are two races in concurrent transactions on a single node. One in starting a transaction and one with replay during commit. This commit closes the first race by storing the client pid in the transaction-lock record and comparing the stored pid against its own pid after releasing the lock and refetching the record inside the transaction. Michael
2009-11-03s3:dbwrap_ctdb: use db_ctdb_ltdb_fetch() inside db_ctdb_transaction_fetch_startMichael Adam1-6/+4
Michael
2009-11-03s3:dbwrap_ctdb: use db_ctdb_ltdb_fetch() inside db_ctdb_transaction_fetch()Michael Adam1-16/+6
Michael
2009-11-03s3:dbwrap_ctdb: add a function db_ctdb_ltdb_fetch()Michael Adam1-0/+53
This fetches a record from the db and splits out the ctdb header. Michael
2009-11-03s3:dbrwap_ctdb: add a function db_ctdb_ltdb_store()Michael Adam1-27/+39
and use it in db_ctdb_store() and db_ctdb_transaction_store(). Michael
2009-11-03s3:dbwrap_ctdb: reformat a comment slightly to enhance clearness.Michael Adam1-3/+5
Michael
2009-11-02Fix bug 6867 - trans2findnext returns reply_nterror(req, ntstatus) In a ↵Jeremy Allison1-12/+16
directory with a lot of files. Jeremy.
2009-11-02s3: Fix a 100% CPU loop when ctdbd dies during a traverseVolker Lendecke1-0/+1
2009-11-02s3-gencache: restore gencache_get behavior with NULL args (with torture test).Günther Deschner2-4/+13
Without this, we panic in wins_srv_is_dead() and fail to start nmbd with wins support. Volker, please check. Guenther
2009-11-02s3: Make "debug hires timestamp" default to trueVolker Lendecke1-1/+1
It does not cost much and can help a lot when debugging
2009-11-02lib/util Use rfc1738.c from Squid for all our URL encode/decode needs.Andrew Bartlett1-1/+1
Andrew Bartlett
2009-11-02s3:ldap: don't search when no values where foundBjörn Jacke1-1/+1
2009-10-31s3: Fix the RPC server SUBSYSTEM declarationVolker Lendecke1-1/+1
If I read SMB_SUBSYSTEM right then the 2nd argument needs to be the file where the static_init_rpc (in this case) is defined. This seems to have moved from server.c to process.c. Jelmer, please check! Volker
2009-10-31s3:Makefile: add LIBREPLACE_LIBS for talloc, tdb and wbclientBjörn Jacke1-3/+3
2009-10-31ѕ3:buildsystem: fix depenencies for libreplaceBjörn Jacke2-8/+7
This problem became visible after adding the picky -z defs linker option: On Solaris libreplace had unresolved symbols, which showed up in the libtalloc build. PAM_WINBIND_EXTRA_LIBS and WINBIND_NSS_EXTRA_LIBS had been workarounds to make things work at two placeѕ. These variables have been obsoleted now. This patch introduces LIBREPLACE_LIBS which contans the linker flags needed for linking anything using libreplace.
2009-10-31ѕ3:ldap: search for account policies in objectclass sambaDomain, not *Björn Jacke1-1/+6
2009-10-30s3-rpcclient: add deletetrustdom command.Günther Deschner1-0/+89
Guenther
2009-10-30s3-rpcclient: add createtrustdom command.Günther Deschner1-0/+45
Guenther
2009-10-30s3-lsa: expand struct lsa_info to carry name and sd.Günther Deschner1-0/+2
Guenther
2009-10-30s3-lsa: use switch in _lsa_QuerySecurity().Günther Deschner1-3/+7
Guenther
2009-10-29Start fixing the RAW-STREAMS test - ensure that the xattrJeremy Allison3-2/+3
used to store the stream info in streams_depot.so is not seen in when enumerating EAs. Jeremy.
2009-10-29s3: Fix incorrect rc check of nscd_flush_cache.Jim McDonough1-1/+1
At least this only resulted in an incorrect debug message.
2009-10-29s3-secrets: use autogenerated code for TRUSTED_DOM_PASS struct parsing from ↵Günther Deschner3-233/+38
a tdb. Guenther
2009-10-29s3: add secrets.idl.Günther Deschner5-1/+140
Guenther
2009-10-28Add in Metze's new code to ndr encode the user.DOSATTRIBStefan (metze) Metzmacher1-0/+1
blobs. Next I'll change the create timestamp and dos attribute code to use this.
2009-10-28Fix bug 6572 - libsmbclient: unable to access 'msdfs proxy' share.SATOH Fumiyasu3-46/+120
2009-10-28s3:net: fix output of net rpc trustdom listBjörn Jacke1-3/+5
Move some messages from stderr to stdout. When some trusting DCs were unreachable we lacked \n's on stdout which screwed up whole the output.
2009-10-28s3:configure: only check for gpfs_gpl.hStefan Metzmacher1-25/+5
The header is everything we need in order to build vfs_gpfs. metze Signed-off-by: Michael Adam <obnox@samba.org>
2009-10-28s3-passdb: move open_schannel_session_store() to passdb/secrets_schannel.c.Günther Deschner3-64/+64
Guenther
2009-10-28s3-net: acct_flags are uint32_t in net_sam_set_userflag().Günther Deschner1-1/+1
Guenther
2009-10-28s3-lsa: add lsa_trusted_domain_mapping.Günther Deschner1-0/+7
Guenther
2009-10-28s3-passdb: add secrets_delete_generic().Günther Deschner2-0/+17
Guenther
2009-10-28s3-lsa: add lsa_secret_mapping.Günther Deschner1-0/+7
Guenther
2009-10-28s3-lsa: use correct function name in_lsa_RemoveAccountRights().Günther Deschner1-1/+1
Guenther
2009-10-28s3-lsa: pure cosmetic indentation fixes.Günther Deschner1-18/+16
Guenther
2009-10-28s3-lsa: use enum lsa_LookupNamesLevel in lsa_lookup_level_to_flags().Günther Deschner1-7/+8
Guenther
2009-10-27s3: pdbedit: add option --kickoff-time/-K to set the user's kickoff timeMichael Adam1-4/+28
Use "never" as argument to set this to unlimited. Michael
2009-10-26Second part of the fix for bug 6828 - infinite timeout occurs when byte lock ↵Jeremy Allison1-6/+9
held outside of samba. Fixes case where a connection with a pending lock can me marked "idle", and ensures that the lock queue timeout is always recalculated. Jeremy.