summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2011-03-16s3: Fix Coverity ID 2233, REVERSE_INULLVolker Lendecke1-1/+1
We have dereferenced h already in dcerpc_lsa_open_policy2 in line 425
2011-03-16s3: Fix Coverity ID 2234: REVERSE_INULLVolker Lendecke1-2/+2
We have dereferenced "b" already in dcerpc_samr_Connect2 in line 521
2011-03-16s3: Fix Coverity ID 2140, DEADCODEVolker Lendecke1-1/+1
This routine was never executed after f0dcc90f because "netname" was always NULL. Jeremy, please check!
2011-03-16s3: Fix Coverity ID 2144, DEADCODEVolker Lendecke1-1/+1
We could never have assigned the real value in line 481. Andreas, please check!
2011-03-16s3: Fix Coverity ID 2147, FORWARD_NULLVolker Lendecke1-1/+1
How could this ever have worked???
2011-03-16s3: Fix Coverity ID 1402: PASS_BY_VALUEVolker Lendecke1-11/+11
There's no point in passing GROUP_MAP on the stack Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Mar 16 21:58:08 CET 2011 on sn-devel-104
2011-03-16s3: Fix Coverity ID 2213, PASS_BY_VALUEVolker Lendecke1-6/+6
There's little point to pass a copy of this structure on the stack. Günther, please check!
2011-03-16s3: Fix Coverity ID 1012, CHECKED_RETURNVolker Lendecke1-6/+5
This is probably more or less taste. Removing the necessity for a comment is a good thing though IMO.
2011-03-16s3: Fix Coverity ID 1013, CHECKED_RETURNVolker Lendecke1-6/+5
This is probably more or less taste. Removing the necessity for a comment is a good thing though IMO.
2011-03-16s3: Fix Coverity ID 1017, CHECKED_RETURNVolker Lendecke1-1/+3
Günther, please check!
2011-03-16s3: Fix Coverity ID 1018, CHECKED_RETURNVolker Lendecke1-3/+5
2011-03-16s3: Fix Coverity ID 1034, CHECKED_RETURNVolker Lendecke1-3/+1
In all other places we check the result of secrets_init.
2011-03-16s3: Fix Coverity ID 2100, BAD_SIZEOFVolker Lendecke1-1/+1
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Mar 16 18:52:18 CET 2011 on sn-devel-104
2011-03-16s3: Fix Coverity ID 2317: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
2011-03-16s3: Fix Coverity ID 2318: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
2011-03-16s3: Fix Coverity ID 2319: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
2011-03-16s3-packet: only include packet.h where needed.Günther Deschner3-1/+2
Guenther
2011-03-16s3-interfaces: only include interfaces.h where needed.Günther Deschner5-1/+4
Guenther
2011-03-16s3-msdfs: avoid global inclusion of msdfs.h.Günther Deschner5-1/+5
Guenther
2011-03-16s3-printing: fix memory leak in print_cups.cDavid Disseldorp1-16/+9
As found by valgrind, tmp_pcap_cache is not freed following printer list tdb update. Signed-off-by: Andreas Schneider <asn@samba.org> Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed Mar 16 16:37:58 CET 2011 on sn-devel-104
2011-03-16s3-printing: remove duplicate cups response processing codeDavid Disseldorp1-147/+94
There is currently a lot of duplicate code included for processing responses to CUPS_GET_PRINTERS and CUPS_GET_CLASSES requests. This change splits this code into a separate function. Signed-off-by: Andreas Schneider <asn@samba.org>
2011-03-16s3-printing: use printcap IDL for IPCDavid Disseldorp3-132/+109
Use printcap IDL for marshalling and unmarshalling messages between cups child and parent smbd processes. This simplifies the IPC and ensures the parent is notified of cups errors encountered by the child. https://bugzilla.samba.org/show_bug.cgi?id=7994 Signed-off-by: Andreas Schneider <asn@samba.org>
2011-03-16s3-build: stop including ldap and lber headers everywhere in the code.Günther Deschner8-51/+67
Instead use new header smb_ldap.h where all LDAP API related things are handled, while smbldap.h only deals with our smbldap_X() API. Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Mar 16 10:54:51 CET 2011 on sn-devel-104
2011-03-16s3-includes: avoid global include of gssapi headers.Günther Deschner3-12/+20
Guenther
2011-03-16s3-libsmb: move smb encryption structs into own header.Günther Deschner7-28/+67
Guenther
2011-03-16libcli/security: move display_sec headers to own header file and add toGünther Deschner5-10/+4
security.h grouping header. Guenther
2011-03-16s3: Fix a cut&paste error in pdb_ads_connectVolker Lendecke1-1/+1
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Mar 16 08:22:28 CET 2011 on sn-devel-104
2011-03-16s3: Use jenkins hash for str_checksum, fix bug 8010Volker Lendecke1-11/+2
From the bugreport: I have a folder with ~90 photos: IMG_XXXX.JPG where XXXX is a four digit number, almost consecutive (photos from camera for one day). Current implementation gives about 30 different checksums for this set of files. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Mar 16 01:15:41 CET 2011 on sn-devel-104
2011-03-15s3-build: try to silence annoying "Ignoring invalid value 'vlp' for ↵Günther Deschner2-5/+6
parameter 'printing'" warning on the buildfarm. Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Mar 15 23:38:43 CET 2011 on sn-devel-104
2011-03-15s3-libsmb: only include rap client when needed.Günther Deschner20-180/+226
Guenther
2011-03-15s3-build: share smbtorture4 build rules with s3-waf build.Günther Deschner3-20/+33
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Mar 15 16:10:17 CET 2011 on sn-devel-104
2011-03-15s3: Fix Coverity ID 2278: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
2011-03-15s3: Fix Coverity ID 2279: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
2011-03-15s3: Fix Coverity ID 2280: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
2011-03-15s3: Fix Coverity ID 2281: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
2011-03-15s3: Fix Coverity ID 2282: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
2011-03-15s3: Fix Coverity ID 2283: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_OpenKey.
2011-03-15s3: Fix Coverity ID 2284: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_DeleteValue.
2011-03-15s3: Fix Coverity ID 2285: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_DeleteValue.
2011-03-15s3: Fix Coverity ID 2286: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
2011-03-15s3: Fix Coverity ID 2287: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_CreateKey.
2011-03-15s3: Fix Coverity ID 2288: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
2011-03-15s3: Fix Coverity ID 2289: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_OpenKey.
2011-03-15s3: Fix Coverity ID 2290: Uninitialized readVolker Lendecke1-1/+1
We passed the structure including the uninitialized elements to dcerpc_winreg_DeleteKey.
2011-03-15s3: Read uidNumber/gidNumber in pdb_ads_sid_to_idVolker Lendecke1-29/+45
Question: How shall we allocate those? Something like the rid allocator? Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Tue Mar 15 09:59:55 CET 2011 on sn-devel-104
2011-03-15s3: Remove some unused codeVolker Lendecke2-43/+0
2011-03-15s3: "hex_encode" does the same as "binary_string"Volker Lendecke1-1/+1
2011-03-15s3-waf: enable public_headers_allow_brokenAndrew Tridgell1-0/+3
2011-03-15s3-waf: enable public header building in s3Andrew Tridgell1-0/+7
2011-03-15Re-enable base.tcondev test for S3, now we pass it correctly.Jeremy Allison1-1/+0
Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Tue Mar 15 00:59:37 CET 2011 on sn-devel-104