summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2011-08-26s3: Fix a winbind race leading to 100% CPUVolker Lendecke1-2/+3
This fixes a race condition that leads to the winbindd_children list becoming corrupted. It happens when on a busy winbind SIGCHLD is a bit late. Imagine a winbind with multiple requests in the queue for a single child. Child dies, and before the SIGCHLD handler is called we find the socket to be dead. wb_child_request_done is called, receiving an error from wb_simple_trans_recv. It closes the socket. Then immediately the wb_child_request_trigger will do another fork_domain_child before the signal handler is called. This means that we do another fork_domain_child, we have child->sock==-1 at this point. fork_domain_child will do a DLIST_ADD(winbindd_children, child) a second time where the child is already part of that list. This corrupts the list. Then the signal handler kicks in, spinning in for (child = winbindd_children; child != NULL; child = child->next) { forever. Not good. This patch makes sure that both conditions (sock==-1 and not part of the list) for a winbindd_child struct match up. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Aug 26 18:51:24 CEST 2011 on sn-devel-104
2011-08-26s3: Fix two int/enum mixupsVolker Lendecke1-2/+2
2011-08-26s3-passdb: Allocate talloc stackframe before calling pdb_get_group_sid()Amitay Isaacs1-5/+6
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3-param: Allocate talloc stackframe before calling s3 param routinesAmitay Isaacs1-2/+26
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3: Use sys_write in fork_domain_childVolker Lendecke1-1/+1
Counterpart for last checkin. A lot less likely, but not impossible in a child. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Aug 26 13:14:27 CEST 2011 on sn-devel-104
2011-08-26s3: Use sys_read in fork_domain_childVolker Lendecke1-1/+1
I've seen [2011/08/26 01:44:10.872057, 1] winbindd/winbindd_dual.c:1336(fork_domain_child) fork_domain_child: Could not read child status: nread=-1, error=Interrupted system call on a customer box. Not good.
2011-08-26s3-passdb: Make domain_sid argument optional for search_aliases methodAmitay Isaacs1-5/+10
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3-passdb: Return assigned number of hours and not MAX_HOURS_LENAmitay Isaacs1-3/+4
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3-passdb: Convert lm_pw and nt_pw to python string using lengthAmitay Isaacs1-2/+2
lm_pw and nt_pw are fixed length strings and convert them to python strings as fixed length strings. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3-param: Add a dump() method to output parametersAmitay Isaacs1-0/+1
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-25s3:dbwrap_tdb: correctly catch the error from the return code of tdb_parse ↵Michael Adam1-1/+6
in db_tdb_fetch()
2011-08-25s3:smbd: remove an unused variable in dptr_create()Michael Adam1-1/+0
2011-08-25s3:registry: fix the v2_to_v3 upgrade code so that it does not create value ↵Michael Adam1-0/+6
list security records for the INFO/version key ...
2011-08-25s3:registry: fix the v1_to_v2 upgrade code so that it does not normalize the ↵Michael Adam1-0/+6
INFO/version key ...
2011-08-25s3:registry: define a constant REGDB_VERSION_KEYNAME for the key ↵Michael Adam1-7/+6
INFO/version (and use it)
2011-08-25s3:registry: hand db context in to v2_to_v3 upgrade code via private_dataMichael Adam1-4/+9
This also fixes the earlier faulty handing in of a useless stackframe memory context via private_data.
2011-08-25s3:registry: fix broken use of dbwrap store record in v1_to_v2 upgrade codeMichael Adam1-8/+10
This also fixes broken private_data parameter for the traverse function (making use of it): Originally a memory context was handed in but was not used.
2011-08-25s3: Fix the build of vfs_aixacl2.cSATOH Fumiyasu1-0/+1
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Thu Aug 25 23:06:12 CEST 2011 on sn-devel-104
2011-08-25s3: Remove a bogus commentVolker Lendecke1-4/+0
2011-08-25s3: Pass smbd_server_connection to (unused) server_encryption_shutdownVolker Lendecke2-2/+2
2011-08-25s3: Pass smbd_server_connection to srv_encrypt_bufferVolker Lendecke3-3/+5
2011-08-25s3: Pass smbd_server_connection to srv_decrypt_bufferVolker Lendecke3-4/+3
2011-08-25s3: Pass smbd_server_connection to srv_free_enc_bufferVolker Lendecke3-4/+4
2011-08-25s3: Pass smbd_server_connection to is_encrypted_packetVolker Lendecke4-8/+11
2011-08-25s3: Pass sconn to valid_smb_headerVolker Lendecke1-4/+5
2011-08-25s3: Explicitly pass smb_srv_trans_enc_ctx to srv_enc_ctxVolker Lendecke1-3/+3
2011-08-25s3: Fix some nonempty blank linesVolker Lendecke2-6/+6
2011-08-25s3-waf: fix some unresolved symbols in idmap ad modules.Günther Deschner1-0/+2
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Thu Aug 25 15:15:57 CEST 2011 on sn-devel-104
2011-08-25s3-registry: fix bug #8401 - registry/reg_format.c must include includes.h.Günther Deschner1-0/+1
Guenther
2011-08-25pdb-samba4: use ldb_get_default_basedn() instead of NULLAndrew Tridgell1-3/+3
this makes pdb-samba4 safe for multi-domain setups Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-08-24s3:winbindd fix a return code checkChristian Ambach1-2/+2
talloc_traverse_dict will return with -1 in case of an error and might return positive values that indicate the count of found entries Autobuild-User: Christian Ambach <ambi@samba.org> Autobuild-Date: Wed Aug 24 18:09:11 CEST 2011 on sn-devel-104
2011-08-24s3: Fix an uninitialized variableVolker Lendecke1-1/+1
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Aug 24 00:34:04 CEST 2011 on sn-devel-104
2011-08-23s3: Fix the build on FreeBSDVolker Lendecke1-0/+1
lsasd.c uses basename(3), which according to susv3 requires libgen.h and without which the FreeBSD build breaks.
2011-08-23s/event_context/tevent_context/ in smbsock_any_connectVolker Lendecke1-2/+2
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Tue Aug 23 18:21:58 CEST 2011 on sn-devel-104
2011-08-23s/event_context/tevent_context/ in smbsock_connectVolker Lendecke1-2/+2
2011-08-23scannedonly module: improve sleep behavior when reading a directory with ↵Olivier Sessink1-14/+16
multiple non-scanned files
2011-08-22s3: Slightly simplify serverid_existsVolker Lendecke1-1/+1
procid_is_me() works fine in the clustering case as well Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Mon Aug 22 21:28:13 CEST 2011 on sn-devel-104
2011-08-22s3-net: Added documentation for net_rpc_conf functionsVicentiu Ciorbaru1-1/+44
Added comments to most functions of net rpc conf for easier understanding of the code. Signed-off-by: Michael Adam <obnox@samba.org> Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Mon Aug 22 17:08:15 CEST 2011 on sn-devel-104
2011-08-22s3-test: Added net conf tests to tests.pyVicentiu Ciorbaru1-0/+6
The tests are added as blackbox tests and they can be called with the wildcard source3.blackbox.net.*.conf with either 'local' or 'rpc' instead of '*' . Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22s3-test: Added new testsuites for test net [rpc] confVicentiu Ciorbaru1-0/+970
The script tests all commands present in the net conf tool. It is also possible to provide a fourth command line parameter 'rpc' in order to run the tests with the use of rpc. Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22s3-test: added samba3.blackbox.net.rpc.registry.roundtrip testsuiteVicentiu Ciorbaru1-1/+4
The testsuite makes use of the rpc mode from the registry roundtrip script to test net rpc conf / net rpc registry Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22s3-test: Enhanced the net registry roundtrip test scriptVicentiu Ciorbaru1-13/+14
The script now supports an rpc mode, which is triggered by the presence of a fourth command line parameter "rpc" Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22s3-net: Implemented net rpc conf import commandVicentiu Ciorbaru1-3/+347
The function takes a local file in smb.conf format, uses calls to smbconf to create smbconf_service structs, which are then placed in the remote registry. The function also provides a test module to only print the changes that it would make. Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22s3-net: Added net rpc conf import command to net rpc confVicentiu Ciorbaru1-0/+16
The function only appears in the commands list usage of net rpc conf. Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22s3-net: Implemented net rpc conf addshare commandVicentiu Ciorbaru1-2/+255
The function is mostly a wrapper around a series of setparm commands. It can be used to quickly set up a share with simple parameters. Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22s3-net: Added net rpc conf addshare command to net rpc confVicentiu Ciorbaru1-0/+15
The function only appears in the commands list usage of net rpc conf. Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22s3-net: Implemented net rpc conf setincludes commandVicentiu Ciorbaru1-2/+141
The function creates the share key if it does not exist. If the share key was present it deletes the previous includes. After this the function sets the new includes accordingly. Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22s3-net: Added net rpc conf setincludes command to net rpc confVicentiu Ciorbaru1-0/+16
The function only appears in the commands list usage of net rpc conf. Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22s3-net: Implemented net rpc conf setparm commandVicentiu Ciorbaru1-2/+201
The function creates the share key if it does not exist. If the share key was present it deletes the previous value. After this the function sets the new value accordingly. Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22s3-net: Added net rpc conf setparm command to net rpc confVicentiu Ciorbaru1-0/+14
The function only appears in the commands list usage of net rpc conf. Signed-off-by: Michael Adam <obnox@samba.org>