summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2011-06-05s3: Fix a valgrind errorVolker Lendecke1-2/+2
For me this fixes ==1950== Invalid read of size 4 ==1950== at 0x81EBED5: GUID_equal (uuid.c:239) ==1950== by 0x81E51AB: ndr_syntax_id_equal (ndr_misc.c:35) ==1950== by 0x82EB0D1: get_iface_from_syntax (rpc_common.c:160) ==1950== by 0x82EB25E: get_pipe_name_from_syntax (rpc_common.c:179) ==1950== by 0x8509E4F: close_policy_by_pipe (rpc_handles.c:322) ==1950== by 0x8507941: close_internal_rpc_pipe_hnd (rpc_ncacn_np.c:109) ==1950== by 0x468270: _talloc_free_internal (talloc.c:826) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x80E6487: sam_trusted_domains (winbindd_samr.c:406) ==1950== Address 0x687ea4 is 20 bytes inside a block of size 40 free'd ==1950== at 0x58CDC: free (in /usr/local/lib/valgrind/vgpreload_memcheck-x86-freebsd.so) ==1950== by 0x8507812: free_pipe_rpc_context_internal (rpc_ncacn_np.c:74) ==1950== by 0x8507936: close_internal_rpc_pipe_hnd (rpc_ncacn_np.c:106) ==1950== by 0x468270: _talloc_free_internal (talloc.c:826) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x80E6487: sam_trusted_domains (winbindd_samr.c:406) ==1950== by 0x80C2F85: trusted_domains (winbindd_cache.c:2820) ==1950== by 0x80D5188: winbindd_dual_list_trusted_domains (winbindd_misc.c:162) ==1950== by 0x80E987F: wb_child_request_trigger (winbindd_dual.c:437) ==1950== Andreas, Guenther, please check! Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Jun 5 13:19:39 CEST 2011 on sn-devel-104
2011-06-05s3:winbind: Convert WINBINDD_WINS_BYIP to the async APIVolker Lendecke6-73/+145
2011-06-04s3: Fix the build on FreeBSD 8Volker Lendecke1-0/+5
This is probably not the last word on gss_mech_krb5, but for now it fixes the build on FreeBSD
2011-06-04Add the same fix to the S3 event backend as the previous commit added to the ↵Jeremy Allison1-1/+14
tevent poll backend. Metze please check ! Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Jun 4 00:27:37 CEST 2011 on sn-devel-104
2011-06-02In samba_version.m4 the test to get the version now returns severalHerb Lewis1-1/+1
lines instead of the one we really wanted which causes some spurious output when configure tries to print the samba version when it starts running. This is only a cosmetic problem but still looks ugly. Signed-off-by: Jeremy Allison <jra@samba.org>
2011-06-02Remove another PATH_MAX.Jeremy Allison1-12/+27
Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Jun 2 02:51:06 CEST 2011 on sn-devel-104
2011-06-02Fix const warnings.Jeremy Allison1-1/+1
Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Jun 2 01:02:53 CEST 2011 on sn-devel-104
2011-06-01Fix const warning.Jeremy Allison1-1/+1
2011-06-01Fix const warning.Jeremy Allison1-1/+1
2011-06-01release_ip() is only used with CLUSTER_SUPPORT.Jeremy Allison1-1/+1
2011-06-01Fix bug where format arguments were reversed. Please compile with -Wall !Jeremy Allison1-2/+2
2011-06-01Move fd_close on error path to be identical to all other error paths.Jeremy Allison1-2/+1
Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Jun 1 22:30:03 CEST 2011 on sn-devel-104
2011-06-01TALLOC_FREE already checks for null.Jeremy Allison1-3/+1
2011-06-01Fix bug #8175 - smbd deadlock.Jeremy Allison1-27/+71
Force the open operation (which is the expensive one anyway) to acquire and release locks in a way compatible with the more common do_lock check. Jeremy.
2011-06-01Revert "s3: Mark sockets in error state writable"Volker Lendecke1-23/+0
This reverts commit 5f6f71956460d6840c1433b59e20555268b622ac. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Jun 1 14:56:25 CEST 2011 on sn-devel-104
2011-06-01s3-epmapper: Register ports on IPv4 too.Andreas Schneider2-2/+2
Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed Jun 1 13:14:53 CEST 2011 on sn-devel-104
2011-06-01s3-rpc_server: Remove unused variable pipes_open.Andreas Schneider1-4/+2
2011-06-01s3-rpc_server: Remove syntax from pipes_struct.Andreas Schneider3-3/+0
2011-06-01s3-rpc_server: Fixed debug messages of srv_pipe_hnd.Andreas Schneider1-5/+5
2011-06-01s3-rpc_server: Fixed debug messages for rpc_handles.Andreas Schneider1-6/+7
2011-06-01s3-rpc_server: Fix debug messages.Andreas Schneider1-46/+20
2011-06-01s3-rpc_server: Don't segfault if there are not handles to free.Andreas Schneider1-0/+4
2011-06-01s3-rpc_server: Remove guessing of the syntax id.Andreas Schneider5-51/+11
This is only a wild guess. We don't know to which rpc service the client wants to talk until we read the the rpc bind packet.
2011-06-01s3-rpc_server: Use the correct syntax id for debugging.Andreas Schneider1-8/+11
2011-06-01s3-rpc_server: Migrate init_pipe_handles() to new syntax.Andreas Schneider1-8/+21
2011-06-01s3-rpc_server: Use the context syntax id in api_pipe_request().Andreas Schneider1-7/+7
2011-06-01s3-rpc_server: Use the correct syntax id in api_pipe_bind_req().Andreas Schneider1-19/+14
2011-06-01s3-rpc_server: Use the correct context syntax.Andreas Schneider1-2/+20
2011-06-01s3-rpc_server: Move the context functions to own file.Andreas Schneider5-22/+72
2011-06-01s3-rpc_server: Store the ndr syntax id in the pipe context.Andreas Schneider1-5/+6
The client tell us in the rpc bind to which rpc service it wants to connect. We did set the p->syntax earlier by guessing to which pipe name it connects, but we don't know to which rpc service it wants to bind until we read the first packet.
2011-06-01s3-rpc_server: Added syntax id to pipe_rpc_fns struct.Andreas Schneider1-1/+2
2011-06-01lib/util/time.c: timeval_current_ofs_usecRusty Russell2-8/+8
Several places want "microseconds from current time", and several were simply handing "usecs" values which could be over a million. Using a helper to do this is safer and more readable. I didn't replace any obviously correct callers (ie. constants). I also renamed wait_nsec in source3/lib/util_sock.c; it's actually microseconds not nanoseconds (introduced with this code in Volker's 19b783cc Async wrapper for open_socket_out_send/recv). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-01lib/util/time.c: timeval_current_ofs_msecRusty Russell5-12/+7
Several places want "milliseconds from current time", and several were simply doing "msec * 1000" which can (and does in one place) result in a usec value over 1 a million. Using a helper to do this is safer and more readable. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-01s3-param Make lp_ncalrpc_dir() constAndrew Bartlett2-2/+2
This disables % substitutions in the 'ncalrpc dir' parameter. This is used as a communication point between multiple parts of the codebase, and needs to be internally consistent between all the Samba tasks. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Wed Jun 1 05:30:53 CEST 2011 on sn-devel-104
2011-06-01s3-param Make lp_dedicated_keytab_file() constAndrew Bartlett2-2/+2
This disables % substitutions in the 'dedicated keytab file' parameter. Andrew Bartlett
2011-06-01s3-param Make lp_realm() constAndrew Bartlett2-2/+2
This disables % substitutions in the 'realm' parameter. This is used all over the codebase, and needs to be internally consistent between all the Samba tasks. Andrew Bartlett
2011-06-01s3-param Make lp_name_resolv_order() constAndrew Bartlett2-2/+2
This disables % substitutions in the 'name resolv order' parameter. This is used all over the codebase, and needs to be internally consistent between all the Samba tasks. Andrew Bartlett
2011-06-01s3-param Make lp_utmpdir() and lp_wtmpdir constAndrew Bartlett2-4/+4
This disables % substitutions in the 'utmp dir' and 'wtmp dir' parameters. These are system paths, and need to be consistent between all the Samba tasks. Andrew Bartlett
2011-06-01s3-param Make lp_piddir() constAndrew Bartlett2-2/+2
This disables % substitutions in the 'pid dir' parameter. This is used all over the codebase, and need to be internally consistent between all the Samba tasks. Andrew Bartlett
2011-06-01s3-param Make lp_cachedir() constAndrew Bartlett2-6/+6
This disables % substitutions in the 'cache dir' parameter. This is used all over the codebase, and need to be internally consistent between all the Samba tasks. Andrew Bartlett
2011-06-01s3-param Make lp_statedir() constAndrew Bartlett2-6/+6
This disables % substitutions in the 'state dir' parameter. This is used all over the codebase, and need to be internally consistent between all the Samba tasks. Andrew Bartlett
2011-06-01s3-param Make lp_lockdir() constAndrew Bartlett2-2/+2
This disables % substitutions in the 'lock dir' parameter. This is used all over the codebase, and needs to be internally consistent for the life of the process, as they determine the location of our locking databases. Andrew Bartlett
2011-06-01s3-param Make lp_smb_passwd_file() and lp_private_dir() constAndrew Bartlett2-4/+4
This disables % substitutions in the 'smb passwd file' and 'private dir' parameters. These are used all over the codebase, and need to be internally consistent for the life of the process, as they determine the location of secrets.tdb, as well as the passdb databases. Andrew Bartlett
2011-06-01s3-param Make lp_smb_ports() constAndrew Bartlett2-2/+2
It makes no sense to have a % substiution in the 'smb ports' parameter. Andrew Bartlett
2011-06-01s3-param Make charset parameters constAndrew Bartlett2-6/+6
This removes the dangerous ability for these parameters to change based on % substitutions. Andrew Bartlett
2011-06-01s3-param Make lp_passwordserver() const.Andrew Bartlett2-2/+2
This means that it no longer takes % substituations, and so the documentation for this behaviour is removed from the smb.conf manpage. (This mode is only useful in security=server, which is already marked as deprecated in 3.6). Andrew Bartlett
2011-06-01s3-param prepare for some lp_ functions to return constAndrew Bartlett2-2/+2
2011-06-01Remove the char * argument from the SMB_VFS_GETWD() call. Now alwaysJeremy Allison7-26/+27
returns malloc'ed memory. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Jun 1 04:06:12 CEST 2011 on sn-devel-104
2011-06-01Change sys_getcd() to take no arguments and always return malloc'ed memory ↵Jeremy Allison5-20/+50
(or NULL). Part of the efforts to remove PATH_MAX on modern systems.
2011-06-01Add check for the getcwd function being able to take NULL,0 arguments.Jeremy Allison2-0/+21