Age | Commit message (Collapse) | Author | Files | Lines |
|
the maxeln parameter instead of sizeof(target_area) - 1 (or even
sizeof(fstring) - 1 in some places.
I hope these were really all there were.
Michael
(This used to be commit 9a28be220df622322857dfe102fa35e108f932dc)
|
|
came across.
Michael
(This used to be commit bf12f0c0f843f088c7fa2d1eca3298a3d76e9761)
|
|
in -1 for maxlen.
Michael
(This used to be commit cd3d652d0d7609fc369ed0743c1fc54c87558438)
|
|
destination instead of source as maxlen.
Michael
(This used to be commit 76cb05deec153c1e0003776339da912a0f3d73a9)
|
|
The maxlen parameter should be set to the size of the
destination, not to the size of the soruce.
Michael
(This used to be commit 841ff0beee7ea44ee92d1f90de3edeb53edcae0a)
|
|
If we promise dest is null terminated, ensure we do it even on
fast path exits.
Jeremy.
(This used to be commit 32626e2b9770eb6b15c191a8feb881f81ed6c57a)
|
|
netlogon_getanydcname()
when called for it's own domain. So we should use netlogon_getdcname() which
returns WERR_OK:-)
gd: feel free to usage rpccli_netlogon_dsr_getdcname(), but please make sure
the new WINBIND-STRUCT-GETDCNAME test is still passing.
metze
(This used to be commit 9a9c164366a252ab8268b687699d54048ced993f)
|
|
(This used to be commit f6f64cf0b51f2fb841bd1c0f800c66114c213577)
|
|
called with -1 (these calls were wrong anyway, target
was an fstring, not a pstring). Found by Michael Adam <ma@sernet.de>,
now to check all other uses.
Michael - this version uses sizeof(target) not sizeof(fstring).
This way is more future proof.
Jeremy.
(This used to be commit 9ed3046633b6949c68c9aed61b8e9444601cf101)
|
|
Michael
(This used to be commit a4f53fe22569a63fe7b196971ac6c28a676ee4e8)
|
|
metze
(This used to be commit 579ed8ae87e449dbd5e4f78609754df0556fbf68)
|
|
Now BUILTIN is always the first domain followed
by the domain of our own SAM DB and the primary
domain (in member server mode).
metze
(This used to be commit b8d67b78aa1c35e4e7e61050c1fccbb6d76d9fd7)
|
|
smb_panic().
Michael
(This used to be commit 8b5c34b7d141c44d65622f44f9432723230cea47)
|
|
Guenther
(This used to be commit 38eca60913f513accb24b31dcb6d1d7e92b0ba66)
|
|
(This used to be commit 3246be8cf05a867b74b4b96697c99cc62f13c2a9)
|
|
and move the include location sys/param.h
before we redefine missing macros
metze
(This used to be commit 862046028c3c61adf6da2effac91abf3c763635d)
|
|
for HPUX large file support.
But it would be nice if someone could verify that.
metze
(This used to be commit b09024928d036933a47e4f1c2e246426fb3792aa)
|
|
rpccli_lsa_lookup_sids()
and remove the old rpccli_lsa_lookup_sids() function. The old function would
fail due to server limits when requesting to resolve too many sids at once
(20480 for W2k3). The new version passes the list of sids in hunks to the
server. It has up to now been used (and tested) in the winbindd_ads
lookup_groupmem() function, and I think the time has come to replace the actual
function with this correct version.
Michael
(This used to be commit 1194d4f36ef720747e62dde31881c295e44e4a76)
|
|
metze
(This used to be commit af91f4fd08aae117d9b48eade4d49762c9634cbc)
|
|
detection from libreplace...
It would be good if someone could test that on HPUX...
metze
(This used to be commit 00ea030e67c519ebb69e5932f607b4ac6e834f0e)
|
|
as this is always answered by the winbindd parent and will
most times return old sequence number values.
metze
(This used to be commit 9caf54c868e8c0109730860e772c9cc404e2f899)
|
|
metze
(This used to be commit ff94d055760b16786d1a998e251d487fb886a64c)
|
|
always consistent. Return -1 on error, and ensure
we check for this. In cases where the dest is already
specified and we've been asked to terminate with a
null, ensure we always do so even on error.
Jeremy.
(This used to be commit abedd967869ade9a43c3a8e1b889c60d4aca81cf)
|
|
"winbindd:socket dir=/path/to/dir" for usage in make test
metze
(This used to be commit 5566cf01e827edf60c0235a661d95dd376210108)
|
|
metze
(This used to be commit 828d2ca0610ab5ee3b96d187b3432b9b4fea72f8)
|
|
metze
(This used to be commit 84ebb6cac224cabf3856a632de80a8a9c687329b)
|
|
-
We ran across a bug joining our Samba server to a Win2K domain with LDAP
signing turned on. Upon investigation I discovered that there is a bug
in Win2K server which returns a duplicated responseToken in the LDAP
bindResponse packet. This blob is placed in the optional mechListMIC
field which is unsupported in both Win2K and Win2K3. You can see RFC
2478 for the proper packet construction. I've worked with metze on this
to confirm all these finding.
This patch properly parses then discards the mechListMIC field if it
exists in the packet, so we don't produce a malformed packet error,
causing LDAP signed joins to fail. Also attached is a sniff of the
domain join, exposing Win2Ks bad behavior (packet 21).
-
(I've just changed the scope of the DATA_BLOB mechList)
metze
(This used to be commit 200b5bfb8180af09446762e915eac63d14c6c7b0)
|
|
(This used to be commit aa603bcc6c848de67ea07d6028ab841a8401d9ad)
|
|
Michael
(This used to be commit 7238884c2cb25dd9279703004ffab6618715a275)
|
|
uninitialized data.
Michael
(This used to be commit b4fff6d09d17a18eae61e8ca789f128cd094ba09)
|
|
rpccli_lsa_lookupsids_noalloc() returns an error for one hunk
of SIDs: free all allocated arrays and return the error code
returned by the hunk lookup.
Michael
(This used to be commit 2c68ebd6934206186dc6e635401f66c2fd1e1234)
|
|
as a special dest_len of sizeof(pstring).
Jeremy.
(This used to be commit 9fc14c83cc5e3a360464c33e26b1073db63763d7)
|
|
(This used to be commit cc4599fdc1fb9aa51f6a4487cb1aa78a5556757a)
|
|
(This used to be commit f1f4758e2c40a470c19b4b738f79ec5807522909)
|
|
same as talloc_strdup_upper.
Jeremy.
(This used to be commit db1b6293771755f20660b071aac0284638dbed46)
|
|
error propagation.
Michael
(This used to be commit 5a16da2185f07d1f48fabd93a7a6b8f2d6b91089)
|
|
return NTSTATUS to allow for better error propagation.
Michael
(This used to be commit 46093004a788dae83a4ddb888ca5d72f555c236c)
|
|
str_len == 0. We should just return 0 in this
case.
Jeremy.
(This used to be commit 8bb85f3f141f0f45b06d28f004cb2cf18252d4e1)
|
|
(This used to be commit b64df8a3c504ab7749c21ffb26e4771a9a0a328f)
|
|
we need -lunwind-x86 not -lunwind-i686
metze
(This used to be commit 2e5f4781652961d6369a64c48b92697c11262c51)
|
|
allow overwritting the location of the WINBINDD_SOCKET_DIR
via an environment variable
metze
(This used to be commit 93bdd2724cc711005a5f2f223b499199394e78e7)
|
|
Jeremy.
(This used to be commit 37cf2c272751065245dd46708af0a78f1f0c47df)
|
|
Jeremy.
(This used to be commit 6032fbc358c5015b2b6a23e13d978bf41ef9e5f3)
|
|
Jeremy.
(This used to be commit 4748d2639796e8caa67fae44d1cf660d49d82663)
|
|
Jeremy.
(This used to be commit 764574ee05ea4f13cdd30c0a0668ffeb81756989)
|
|
(This used to be commit 1a022267003480b4487a780ebaa6016f491828a3)
|
|
new name if unmangling succeeded, not if it
failed. Jerry - please re-test, this should
fix your bug.
Jeremy.
(This used to be commit c215d6e84929b70e4472e19f32ec4f1db7449d90)
|
|
string.
Jeremy.
(This used to be commit fe30a523dfc77cc373145624246fd3ad5c62b9ac)
|
|
Jeremy.
(This used to be commit 2243a73d650319208aebbbaf65dfba2a508a7c10)
|
|
Found by Metze's code review (thanks Metze !).
Jeremy.
(This used to be commit a7370eea6be29c0e2adf5ae62aa6182b9165e744)
|