summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2012-11-29s3: Remove db_ctdb_fetchVolker Lendecke1-55/+11
Note that this also makes the request for read only copies much more explicity visible in the code. Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Directly parse local existing records in db_ctdb_parse_recordVolker Lendecke1-0/+22
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Factor out db_ctdb_can_use_local_hdr from db_ctdb_can_use_local_copyVolker Lendecke1-11/+14
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Remove unused code for fetching persistent ctdb recordsVolker Lendecke1-129/+0
The only entry point here is parse_record, and this catches the persistent case with a direct parse now Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Avoid db_ctdb_fetch for persistent databasesVolker Lendecke1-0/+44
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Factor out parse_newest_in_marshall_buffer from ↵Volker Lendecke1-15/+51
pull_newest_from_marshall_buffer Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: reduce db_ctdb_marshall_loop_next to specialized db_ctdb_marshall_buf_parseVolker Lendecke1-48/+21
now that the db_ctdb_marshall_loop_next_key has been factored out. Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Factor out db_ctdb_marshall_loop_next_key from db_ctdb_marshall_loop_nextVolker Lendecke1-9/+24
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Slightly simplify db_ctdb_marshall_loop_nextVolker Lendecke1-4/+3
Both callers give a key argument Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Use db_ctdb_ltdb_parse in db_ctdb_fetch_db_seqnum_from_dbVolker Lendecke1-20/+21
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Use db_ctdb_ltdb_parse in db_ctdb_ltdb_fetchVolker Lendecke1-30/+46
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Add db_ctdb_ltdb_parseVolker Lendecke1-0/+42
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Slightly simplify db_ctdb_transaction_commitVolker Lendecke1-1/+2
Avoid an unnecessary "else". Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Remove header==NULL code from db_ctdb_marshall_recordVolker Lendecke1-12/+5
The only call chain (via db_ctdb_marshall_add) has header != NULL Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: test dbwrap_ctdbVolker Lendecke5-0/+153
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3-printing: add missing carriage return to debug strDavid Disseldorp1-1/+1
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-29rpcclient: fix usage docs for rpcclient adddriverDavid Disseldorp1-2/+2
The printer driver name is incorrectly referred to as the printer name. Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-29spoolss: fix segfault when "default devmode" is disabledDavid Disseldorp1-18/+34
Currently when "default devmode" is explicitly disabled, and a printer is added with a null device mode, spoolssd crashes in copy_devicemode(). Both construct_printer_info2() and construct_printer_info8() code paths currently unconditionally attempt to copy a printers device mode, without checking whether one is present. This change fixes this regression such that construct_printer_info*() functions check for a null device mode before copying. https://bugzilla.samba.org/show_bug.cgi?id=9433 Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Nov 29 13:03:05 CET 2012 on sn-devel-104
2012-11-28s3: Use dbwrap_parse_record in fetch_share_mode_unlockedVolker Lendecke1-13/+14
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-28BUG 9436: Fix leaking sockets of SMB connections to a DC.Andreas Schneider1-0/+4
As this is a burst of 3 unbound sockets with each try to reach a DC we're running out of file descriptors pretty fast. So winbind is then mostly spinning in an accept loop failing with EMFILE. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org> Autobuild-User(master): Jim McDonough <jmcd@samba.org> Autobuild-Date(master): Wed Nov 28 17:17:21 CET 2012 on sn-devel-104
2012-11-28s3:vfs_gpfs: add no memory check in gpfs2smb_acl()Stefan Metzmacher1-0/+5
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Wed Nov 28 14:06:27 CET 2012 on sn-devel-104
2012-11-28s3:vfs_gpfs: make sure we return the correct errno in gpfs2smb_acl()Stefan Metzmacher1-1/+1
TALLOC_FREE() could overwrite errno. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-28s4:smbd/open: add missing TALLOC_FREE(frame) to inherit_new_acl()Stefan Metzmacher1-0/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-28s3:vfs_aixacl2: make use of vfs_aixacl_util.hStefan Metzmacher1-3/+1
This should fix the build. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-28s3: Open gencache_notrans with TDB_NOSYNCVolker Lendecke1-1/+4
We are doing CLEAR_IF_FIRST here, and we are doing the transactions only to protect gencache_stabilize against concurrent writers. tdb's transaction.c says: - if TDB_NOSYNC is passed to flags in tdb_open then transactions are still available, but no fsync/msync calls are made. This means we are still proof against a process dying during transaction commit, but not against machine reboot. For gencache_notrans.tdb this is exactly what we want and avoids some expensive disk syncs. Reviewed by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Nov 28 03:13:56 CET 2012 on sn-devel-104
2012-11-27s3: Avoid some transaction_commit on gencache.tdbVolker Lendecke1-0/+110
Commits are expensive, and in some scenarios we are overwriting existing values again and again. Reviewed by: Jeremy Allison <jra@samba.org>
2012-11-27s3: Fix bug 9428 -- inotify detection brokenVolker Lendecke1-1/+1
Reviewed by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Nov 27 01:20:24 CET 2012 on sn-devel-104
2012-11-26s3: Do not free a string where we should notVolker Lendecke1-1/+1
Reviewed by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Mon Nov 26 22:03:05 CET 2012 on sn-devel-104
2012-11-26s3: Do not free a string where we should notVolker Lendecke1-1/+1
Reviewed by: Jeremy Allison <jra@samba.org>
2012-11-26s3: Fix Coverity ID 741407 -- resource leakVolker Lendecke1-0/+1
Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Mon Nov 26 19:20:05 CET 2012 on sn-devel-104
2012-11-26s3-rpc_client: try to use socket_addr if available in rpc_pipe_open_tcp() ↵Günther Deschner3-8/+19
(bug #9426) Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Nov 26 17:36:20 CET 2012 on sn-devel-104
2012-11-23configure(waf): Fail "configure --with-ads" if ads support is not availableMichael Adam1-24/+50
Fix for bug #9350 This establishes the "auto" mode as default for ads-support, when neither "--with-ads" nor "--without-ads" is specified for configure. Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Björn Baumbach <bb@sernet.de> Signed-off-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Fri Nov 23 19:34:55 CET 2012 on sn-devel-104
2012-11-23s3-rpc_client: lookup nametype 0x20 in rpc_pipe_open_tcp_port(). (bug #9426)Günther Deschner1-1/+1
The server name type (0x20) is much more likely to be available in the name cache, as this type gets stored by winbind itself - the primary user of the ncacn_ip_tcp code currently. Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri Nov 23 16:30:57 CET 2012 on sn-devel-104
2012-11-23Fix MD5 detection in the autoconf buildMatthieu Patou1-7/+34
This is a front port of patches made in 3.6.x branch for bugs: * 9037 * 9086 * 9094 * 9418 It checks if there is a library for md5 related functions (libmd or libmd5) and if so it checks for the presence of md5.h headers it also respect the need for osX build to not use samba's md5 implementation as it's already present in the system libs. Signed-off-by: Matthieu Patou <mat@matws.net> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri Nov 23 10:05:34 CET 2012 on sn-devel-104
2012-11-22build: Do not install testing binariesAndrew Bartlett3-2/+20
These binaries are for developer or selftest use, and are not supported for installation onto the system. The autoconf build does not install these binaries, and so neither should the waf build. Andrew Bartlett Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Nov 22 12:00:36 CET 2012 on sn-devel-104
2012-11-22build: Remove --enable-smbtorture, require bin/smbtorture (from waf) for ↵Andrew Bartlett3-20/+11
make test This simply moves this to being a side-effect of --enable-selftest. The flag was renamed from --enable-smbtorture4 in a recent patch. Make test now relies on smbtorture4, and so this code to make the dependency optional for the tests is not required any more. Andrew Bartlett Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-22build: Be consistent with the name of smbtorture binariesAndrew Bartlett4-33/+24
This ensures that in both build systems, smbtorture3 is the source3 binary, and smbtoture is our main smbtorture binary, built with waf. Also included in this is the removal of bin/ndrdump4 as a special case. This removes the last cases of binaries with different names in each build system. Andrew Bartlett Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-22torture: remove source3 locktest and masktestAndrew Bartlett3-722/+0
We now just build these in waf, using the source4/torture code. The source4 versions of these are tested in make test. Andrew Bartlett Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-22build: Use ntlm_auth from source3 as the only ntlm_auth installed on the systemAndrew Bartlett1-1/+1
The ntlm_auth4 binary is untested, and is missing major features compared with the source3 binary. The two are being slowly merged, but I have not finished that. Andrew Bartlett Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-20s3:smbd/aio do not mark file modified during readsChristian Ambach1-2/+0
this causes each file that is potentially just opened for reading to be marked as modified and lots of file change notifications will be send Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Tue Nov 20 21:02:34 CET 2012 on sn-devel-104
2012-11-20s3: Fix some blank line endingsVolker Lendecke1-10/+10
Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue Nov 20 19:18:33 CET 2012 on sn-devel-104
2012-11-20s3:librpc: add support for PFC_FLAG_OBJECT_UUID when parsing packets (bug #9382)Stefan Metzmacher1-0/+4
Now the logic matches the one in dcerpc_read_ncacn_packet_done(). Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-20s3:param: set "map archive = no" in ROLE_ACTIVE_DIRECTORY_DCStefan Metzmacher1-0/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-20build(waf): fix a typoChristian Ambach1-1/+1
Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue Nov 20 11:54:51 CET 2012 on sn-devel-104
2012-11-20More for #9374 - Allow smb2.acls torture test to pass against smbd with a ↵Jeremy Allison3-9/+11
POSIX ACLs backend. Change can_delete_directory() to can_delete_directory_fsp(), as we only ever call this from an open directory file handle. This allows us to use OpenDir_fsp() instead of OpenDir(). OpenDir() re-checks the ACL on the directory, which may refuse DIR_LIST permissions. OpenDir_fsp() does not. As this is a file-server internal check to see if the directory actually contains any files before setting delete on close, we can ignore the ACL here (Windows does). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue Nov 20 01:46:28 CET 2012 on sn-devel-104
2012-11-19Add comments explaining exactly *why* we don't check FILE_READ_ATTRIBUTES ↵Jeremy Allison1-3/+21
when evaluating file/directory ACE's. If we can access the path to this file, by default we have FILE_READ_ATTRIBUTES from the containing directory. See the section. "Algorithm to Check Access to an Existing File" in MS-FSA.pdf. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-17s3:modules:nfs4_acls remove unused mem_ctx parameter to smbacl4_fill_ace4Christian Ambach1-3/+1
Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sat Nov 17 01:11:07 CET 2012 on sn-devel-104
2012-11-16s3:modules:nfs4_acls fix memory hierarchy in smb_create_smb4aclChristian Ambach1-2/+1
the ACEs should be talloc children of the ACL itself and not be placed on talloc_tos() Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2012-11-16s3:vfs_gpfs fix a memory leak in gpfsacl_get_posix_aclChristian Ambach1-0/+3
Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2012-11-16s3:vfs_gpfs fix memory corruption in gpfs2smb_aclChristian Ambach1-0/+2
sys_acl_init returns a SMB_ACL_T with zero entries in the acl array reallocate the array to proper size before filling it, otherwise we overwrite memory This one is a result of a improper fixing in 7a6182962966e5edb42728c8 Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>