summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2008-10-01Fix use of DLIST_REMOVE as spotted by Constantine Vetoshev <gepardcv@gmail.com>.Jeremy Allison3-5/+5
This API is unusual in that if used to remove a non-list head it nulls out the next and prev pointers. This is what you want for debugging (don't want an entry removed from the list to be still virtually linked into it) but means there is no consistent idiom for use as the next and prev pointers get trashed on removal from the list, meaning you must save them yourself. You can use it one way when deleting everything via the head pointer, as this preserves the next pointer, but you *must* use it another way when not deleting everything via the head pointer. Fix all known uses of this (the main one is in conn_free_internal() and would not free all the private data entries for vfs modules. The other changes in web/statuspage.c and winbindd_util.c are not strictly neccessary, as the head pointer is being used, but I've done them for consistency. Long term we must revisit this as this API is too hard to use correctly. Jeremy.
2008-10-01Turn the socket connections into a refcounted list - in the common case ↵Jeremy Allison1-44/+95
there'll now only be one socket per smbd. Changed the format of the wire data to (a) include a version number (V1) as the first element. (b) removed the ";)" at the end an replaced it with a "\n". Receiver can change back if needed, and now receiver can just log "as-is" to a text file (making testing easier). Added my (C). Sorry Holger, but I've changed quite a bit now. Jeremy.
2008-09-30Convert to allocated strings. Use write_data(), not send as this doesn't ↵Jeremy Allison1-58/+42
correctly deal with EINTR. Jim and Holger please check this still works. Jeremy.
2008-09-30Revert erroneous commit.Jeremy Allison1-1/+1
Jeremy.
2008-09-30Remove current_user_info - not needed.Jeremy Allison2-5/+3
Jeremy.
2008-09-30Restructure the module so it connects to the remote data sinkJeremy Allison1-150/+156
on connect, and closes the socket on client disconnect. This should make it much more efficient. Store the remote fd in a private data pointer off the handle. Finally we need to remove the fstrings and convert to allocated buffer storage. Jeremy.
2008-09-30Fix the make test problem Karolin reported. Now rename_open_files actually ↵Jeremy Allison1-2/+2
works correctly we must emit the change notify before we change the name, not before. Jeremy.
2008-09-29Ensure we null out fsp after a close in all paths.Jeremy Allison1-0/+1
Jeremy.
2008-09-29Avoid freeing fsp twice when opening new_file fails. (Debian #431696)Jelmer Vernooij1-0/+1
If opening new_file fails, fsp would still be set to the files_struct of old_file.
2008-09-29s3:mapping_tdb: fix the del_aliasmem() functionStefan Metzmacher1-3/+2
We should not cancel the transaction, when we want to delete a key. metze
2008-09-29re-added "winbind:ignore domains" patchAndrew Tridgell1-0/+17
This option really is essential, as we discover again and again at customer sites. Due to bugs in winbind some domains are toxic. When you are installing at a site and a particular domain in a complex setup causes winbind to segfault or hang then you need a way to disable that domain and continue. In an ideal world winbind could handle arbitrarily complex ADS domains, but we are nowhere near that yet. If we ever get to that stage then we won't need this option.
2008-09-29fixed an (unlikely) memory leakAndrew Tridgell1-0/+1
2008-09-29fixed a segfault on the ctdb destructor codeAndrew Tridgell1-3/+10
2008-09-29removed unused variablesAndrew Tridgell1-2/+1
2008-09-29fixed segv on startup with trusted domainsAndrew Tridgell1-0/+16
With some setups, idmap_tdb2_allocate_id can be called before the allocate backend is initialised, leading to a segv. This change ensures that the db is opened in all paths that use it
2008-09-29[s3]fix build --with-cluster-support after ndr_[pull|push]_struct blob changes.Michael Adam1-2/+2
Michael
2008-09-29s4:configure: require tdb >= 1.1.3 from the systemStefan Metzmacher1-1/+1
metze
2008-09-29Fix async_connectVolker Lendecke1-1/+2
2008-09-27[s3]loadparm: refactor freeing of parameter data out and reduce memleak.Michael Adam1-35/+53
Add new functions free_parameter(), free_parameters() and free_global_parameters() and use these in the appropriate places, reducing code duplication. Also, always TALLOC_FREE data of type P_LIST, thus reducing mem-leaks: This had not been done in init_globals before. Michael
2008-09-27[s3]loadparm: in lp_do_parameter() use function lp_local_ptr()Michael Adam1-3/+1
instead of hard coded calculation. Michael
2008-09-27[s3]loadparm: remove superfluous talloc context / talloc_stackframe call.Michael Adam1-5/+0
Michael
2008-09-27[s3]loadparm: refactor setting parametric options in list outMichael Adam1-52/+45
into new function set_param_opt(). This unifies and clarifies two instances of the code. Michael
2008-09-27[s3]loadparm: fix memory error - free the right param_opt->list in copy_service.Michael Adam1-1/+1
Michael
2008-09-27[s3]loadparm: refactor freeing of parametric options into free_param_opts().Michael Adam1-41/+34
This code was there in three places. Michael
2008-09-27[s3]loadparm: rename process_registry_service() to process_smbconf_service().Michael Adam1-3/+3
There is nothing registry-specific in that function. Michael
2008-09-27[s3]testparm: give testparm one common exit point and call gfree_loadparm().Michael Adam1-6/+13
Michael
2008-09-27[s3]testparm: free the popt context when it is no longer used.Michael Adam1-0/+2
Michael
2008-09-27[s3]build: build the new test_lp_load command.Michael Adam1-0/+11
Michael
2008-09-27[s3]loadparm: add a command test_lp_load to test the lp_load function.Michael Adam1-0/+88
This is not like testparm, just a simple tool that runs lp_load_with_registry_shares the requested number of times. Michael
2008-09-26Second part of the fix for bug #5790 - samba returns ↵Jeremy Allison1-4/+6
STATUS_OBJECT_NAME_NOT_FOUND on set file disposition call. This was my fault. I use a singleton cache (positive and negative) to speed up pathname based qfileinfo/setfileinfo lookups for alternate fsp's open on the same path. I only invalidated the negative cache on adding a new file fsp, as I incorrectly imagined the new fsp was put at the *end* of the open files list. DLIST_ADD puts it at the start, meaning any subsequent open wasn't seen once the cache was set. Doh ! Jeremy.
2008-09-27libwbclient: fix doxygen warnings.Günther Deschner4-6/+6
Guenther
2008-09-27libgpo: add gpext_security module build to configure.Günther Deschner1-0/+1
Guenther
2008-09-27libgpo: fix copyright.Günther Deschner1-1/+1
Guenther
2008-09-27libgpo: add security CSE skeleton.Günther Deschner2-0/+273
Guenther
2008-09-26Fix bug #5797 - Moving readonly files fails. Reported by infomail@lordb.de.Jeremy Allison1-3/+1
We don't need to deny a DELETE open on a readonly file (I'm also adding a s4 torture test for this), the set_file_disposition call will return NT_STATUS_CANNOT_DELETE if the delete-on-close bit is set on a readonly file (and we already do this). Jeremy.
2008-09-26libgpo: fix invalid cast in scripts CSE.Günther Deschner1-1/+1
Guenther
2008-09-26net: Make share type lookup a function.Kai Blin4-12/+17
2008-09-26s3-srvsvc: fix _srvsvc_NetShareAdd segfault.Günther Deschner1-1/+3
parm_err is not a ref pointer. Guenther
2008-09-25Use IPv4/v6 independent calls. Change safe_strcpy/cat to strlcpy/cat (thisJeremy Allison1-84/+97
needs changing to talloc_sprintf) and fix file descriptor resource leaks in error paths. Jim and Holger please check ! Jeremy.
2008-09-25netapi: start supporting NetUserSetInfo level 3.Günther Deschner1-7/+46
Guenther
2008-09-25s3-nbt: further cleanup of dsgetdcname().Günther Deschner1-163/+25
Guenther
2008-09-25s3-nbt: remove double nbt netlogon opcodes.Günther Deschner3-30/+19
Guenther
2008-09-25idmap: Fix typo is gid2sid() that was caching using idmap_cache_set_sid2uid()Gerald W. Carter1-1/+1
2008-09-25Merge branch 'master' of ssh://jra@git.samba.org/data/git/sambaJeremy Allison1-0/+1
2008-09-25Remove these no longer used include files.Jeremy Allison2-3118/+0
Jeremy.
2008-09-25idmap_hash: Fix the nss_info link during "make install"Gerald W. Carter1-0/+1
2008-09-25idmap_adex: Fix the nss_info install link.Gerald W. Carter1-0/+1
2008-09-25s3:lib/ldb: Don't return already freed pointer on error.Stefan Metzmacher1-0/+1
metze Signed-off-by: Karolin Seeger <kseeger@samba.org>
2008-09-24Fix the new vfs_smb_traffic_analyzer build for static linksJim McDonough1-2/+2
2008-09-24SMB traffic analyzer vfs module from Holger Hetterich <hhetter@novell.com>Holger Hetterich3-2/+359
Used to gather data to feed to a database for live and historical analysis of usage per user, per share, etc. Helper apps to read the data still to come. This one still needs to be made ipv6 enabled (connection is made to the helper app).