Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
for TRANS2-QUERY_FS_INFO/Info Volume."
This reverts commit 042aafb87df6c05877b8fc7ef0d44877689d860a.
I need to test against OS/2 to see if this is something Win28K
breaks for older clients before allowing this.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Mar 26 01:19:55 CET 2011 on sn-devel-104
|
|
is configured.
As discovered by David Disseldorp <ddiss@suse.de>, convert_string_talloc()
doesn't always return consistent results for a zero length string. The
API states an incoming string must *always* contain the terminating null,
but unfotunately too much code expects passing in a zero source length
to return a null terminated string, so at least ensure we return a
correct null string in the required character set and return the
correct length.
Also ensure we cannot return a zero length for a converted string
(we ensure that the returned buffer is always allocated and zero
terminated anyway) as calling code depends on the fact that returning
true from this function will *always* return a non-zero length (as
it must include the terminating null).
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Mar 25 23:25:40 CET 2011 on sn-devel-104
|
|
cli_get_session_key() usage.
Thanks Volker!
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar 25 18:21:18 CET 2011 on sn-devel-104
|
|
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Mar 25 16:35:30 CET 2011 on sn-devel-104
|
|
This reverts commit 37261928bec145f4cbd85f3e409063563c00ac9e.
In source3 this creates a warning of the form
passdb/pdb_ldap.c:4565: warning: passing argument 2 of ‘pull_utf8_talloc’ from incompatible pointer type
include/proto.h:444: note: expected ‘char **’ but argument is of type ‘char ***’
for every use of CONST_DISCARD.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Mar 25 13:16:35 CET 2011 on sn-devel-104
|
|
|
|
lp_failed_convert_char() is not needed any more
|
|
This better reflects what this structure is
Andrew Bartlett
|
|
debug error display happens in the convert_string() outer function
|
|
use convert_string_error() instead
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
This replaces the push_ascii_nstring() implementation with a call to
convert_string_error()
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
This function returns errors rather than printing them.
Andrew Bartlett
|
|
a cast is not enough
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
we need to move towards eliminating smb_ucs2_t. This moves a couple of
the related macros into the only file they are used in
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
this starts the (long!) process of moving some of the SMB constants
into common files. This just moves the FLAGS2_ defines, which are
needed for common string routines (for FLAGS2_UNICODE_STRINGS)
|
|
|
|
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
hopefully there aren't any others lurking in the code
|
|
it is local to charcnv.c
|
|
|
|
this will allow the common charcnv library to use the string wrappers
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
When doing a non-locking fetch on a record of a persistent db when no
transaction is running, the old behaviour was to fetch locally and
do a ctdb call when the record was not found in the local db.
The call is useless for persistent dbs anyway since they are only
written to using transactions and hence kept in sync, but it is
also harmful, because a ctdb call will bump the record RSN when it
does actually migrate the record from one node to another.
Recently, ctdb has been changed to make all calls do a migration.
This uncovered the client misbehaviour for persistent dbs, because
now _each_ non-locking fetch will render the persistent db inconsistent:
A subsequent transaction which touches the record in question will
fail because the RSNs are out of sync.
This patch fixes this old bug.
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Mar 25 01:26:32 CET 2011 on sn-devel-104
|
|
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 24 23:54:25 CET 2011 on sn-devel-104
|
|
Guenther
|
|
We were not taking into account the existing posix attributes and thus failed
while trying to add a 2nd uid attribute.
Found by Sumit.
Guenther
|
|
Guenther
|
|
TRANS2-QUERY_FS_INFO/Info Volume.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Mar 24 23:07:09 CET 2011 on sn-devel-104
|
|
If IPv6 DNS names are turned on, but Samba isn't configured to
listen on an IPv6 interface, then is_myname_or_ipaddr() can return
false on a valid DNS name that it should detect is our own. If the
IPv6 addr is returned by preference, then looking at the first addr
only causes is_myname_or_ipaddr() to fail. We need to look at all the
addresses returned by the DNS lookup and check all of them against
our interface list. This is an order N^2 lookup, but there shouldn't
be enough addresses to make this a practical problem.
Jeremy.
|
|
Properly initialize variables at each cycle.
Convert to the right error when returning EPMAPPER ones.
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Thu Mar 24 20:43:49 CET 2011 on sn-devel-104
|
|
p->mem_ctx is the short-lived per request context, while this data is long
lived, allocate on p instead.
|
|
|
|
|
|
|
|
|
|
Do the assignment as the last action to make sure it's not overwritten
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 24 17:31:57 CET 2011 on sn-devel-104
|
|
|
|
convert_string*()
we shouldn't accept bad multi-byte strings, it just hides problems
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Mar 24 01:47:26 CET 2011 on sn-devel-104
|
|
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 24 00:52:01 CET 2011 on sn-devel-104
|
|
Guenther
|
|
Found by Sumit Bose <sbose@redhat.com>, thanks!
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 23 20:12:38 CET 2011 on sn-devel-104
|
|
Guenther
|
|
Guenther
|
|
Guenther
|
|
Guenther
|
|
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Wed Mar 23 18:06:54 CET 2011 on sn-devel-104
|
|
|
|
This is done automatically now.
|
|
|