summaryrefslogtreecommitdiff
path: root/source4/dsdb/kcc
AgeCommit message (Collapse)AuthorFilesLines
2012-08-17s4-dsdb: Use tmp_ctx in kccsrv_check_deleted to avoid leaking memory onto ↵Andrew Bartlett1-6/+11
part->dn The confusing use of do_dn as a memory context while legitimate created a bug when it was copied and modified to search on a DN from long-term state. By always using a temporary memory context it is clear what paramter is the memory context. This was found based on a log provided by Ricky Nance <ricky.nance@weaubleau.k12.mo.us>. Thanks Ricky! Andrew Bartlett Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Aug 17 18:24:10 CEST 2012 on sn-devel-104
2012-08-17s4-kcc: Avoid use-after-free of dn and add tmp_ctxAndrew Bartlett1-2/+9
By using a tmp_ctx we are clearer about allocating temporary memory. Andrew Bartlett
2012-08-14s4-dsdb: Add mem_ctx argument to samdb_ntds_settings_dnAndrew Bartlett3-4/+4
As this value is calculated new each time, we need to give it a context to live on. If the value is the forced value during provision, a reference is taken. This was responsible for the memory leak in the replication process. In the example I was given, this DN appeared in memory 13596 times! Andrew Bartlett Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue Aug 14 10:05:14 CEST 2012 on sn-devel-104
2012-08-14s4-dsdb: Improve memory handling in kccsrv_add_connection()Andrew Bartlett1-0/+5
2012-08-14s4-dsdb: Improve memory handling in kccsrv_find_connections() by adding a ↵Andrew Bartlett1-4/+15
tmp_ctx
2012-06-15lib/param: Create a seperate server role for "active directory domain ↵Andrew Bartlett1-1/+1
controller" This will allow us to detect from the smb.conf if this is a Samba4 AD DC which will allow smarter handling of (for example) accidentially starting smbd rather than samba. To cope with upgrades from existing Samba4 installs, 'domain controller' is a synonym of 'active directory domain controller' and new parameters 'classic primary domain controller' and 'classic backup domain controller' are added. Andrew Bartlett
2012-04-19s4-kcc: avoid a false alarm with rodcMatthieu Patou1-0/+7
Autobuild-User: Matthieu Patou <mat@samba.org> Autobuild-Date: Thu Apr 19 12:32:58 CEST 2012 on sn-devel-104
2012-03-14s4-dsdb: Fix the case for attribute name msDS-hasMasterNCsAmitay Isaacs1-2/+2
Autobuild-User: Amitay Isaacs <amitay@samba.org> Autobuild-Date: Wed Mar 14 11:59:02 CET 2012 on sn-devel-104
2011-12-23s4-kcc: Remove also deleted objects that are not in the Deleted Object containerMatthieu Patou2-2/+38
For the configuration container we do a full scan at every run of the kcc-delete service. For the base DN we introduce a new parameter that avoid the full scan to kick just when samba starts. Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-12-08Invocation of samba_kcc from KCC taskDave Craft2-20/+88
Modification to periodic and explicit invocation paths of the KCC topology generation code. Managed via samba_runcmd_send() API. The samba_kcc script is invoked if (kccsrv:samba_kcc = true) appears in smb.conf Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-12-08Add subreq and status to kcc_service structDave Craft1-2/+9
The subreq and status fields in the kcc_service struct are added for execution management of the external samba_kcc python script. Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-10-04s4-kcc: if we are a GC, auto-add partial replicasAndrew Tridgell1-3/+147
when we are a global catalog server, the KCC needs to add partial replicas for all domain partitions that we don't have copies of
2011-09-22s4-kcc: return partial replica NCs in drs showreplAndrew Tridgell1-24/+20
the showrepl operation should return all our replicated NCs, including partial replicas
2011-09-07s4-kcc: Fix the list of NCs for DRS replica informationAmitay Isaacs1-3/+21
AD DNS partitions (DomainDnsZones and ForestDnsZones) are listed under msDs-hasMasterNCs attribute for post-2003 windows servers.
2011-08-25s4-kcc: fixed _msdcs DNS nameAndrew Tridgell1-3/+1
we need to base this DNS name on the forest DNS name for multi-domain support Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
2011-08-13s4:dsdb: use tevent_ fn names instaed of legacy event_ onesSimo Sorce1-1/+1
2011-07-31s4-kcc: correctly populate the neighbor object when taking information from ↵Matthieu Patou1-0/+3
repsTo Autobuild-User: Matthieu Patou <mat@samba.org> Autobuild-Date: Sun Jul 31 00:17:17 CEST 2011 on sn-devel-104
2011-07-21s4-kcc: use dsdb_delete() instead of ldb_delete()Andrew Tridgell1-1/+1
this adds the DSDB_SEARCH_SHOW_DELETED flag, which fixes deletion of deleted objects Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-07-14Add intrasite code test switchDave Craft2-0/+9
kcc_service struct gets a intrasite_code boolean that is filled in via parametric parameter kccsrv:intrasite = [true/false] in smb.conf. This will allow us to continue to utilize old simple KCC topology as continuing default while newer intra-site topology matures further. Signed-off-by: Andrew Tridgell <tridge@samba.org> Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Thu Jul 14 00:19:12 CEST 2011 on sn-devel-104
2011-07-14Add kccsrv_add_repsFrom() possibility of NULL res argumentDave Craft1-2/+2
We need the ability to utilize this function in a different manner. KCC intra-site topology has already vetted the replica as being appropriate to produce a repsFrom from. We do not want kccsrv_add_repsFrom() to produce further checking as was the case for simple topology. Thus if we pass a NULL (res) parameter this extra check will be skipped. Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-07-14Remove static to allow availability to other KCC filesDave Craft1-4/+4
kccsrv_replica_flags() and kccsrv_add_repsFrom() need to be available to functions outside kcc_periodic.c Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-07-14kcc_connection invocation_id added to structDave Craft1-0/+1
Utilized by KCC to carry the invocation id of the NTDSDSA that we are replicating the name context from. Utilized when NTDSConnection is created (much like dsa_guid tracks the NTDSDSA objectGUID that we are replicating the name context from). Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-07-14KCC NTDSConnection should utilize NTDSCONN_OPT_IS_GENERATEDDave Craft1-1/+9
Previously this set an explicit (0x1) value whereas it can now utilize NTDSCONN_OPT_IS_GENERATED from flags.h Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-07-14NTDSConnection and NTDSA Site setting flagsDave Craft1-8/+0
Flags that were missing from flags.h or were incorrectly defined inline to the kcc_topology.c code (and thus unusable elsewhere). These are the NTDSConnection and NTDSDSA Site settings flags. Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-03-01s4:dsdb - always handle the attribute "options" as 32bit unsigned integerMatthias Dieter Wallnöfer2-19/+20
It is defined as LDAP syntax 2.5.5.9 so no need at all to treat it as 64-bit integer. Reviewed by: Kamenim and Metze Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org> Autobuild-Date: Tue Mar 1 12:46:15 CET 2011 on sn-devel-104
2011-02-10ldb: use #include <ldb.h> for ldbAndrew Tridgell5-5/+5
thi ensures we are using the header corresponding to the version of ldb we're linking against. Otherwise we could use the system ldb for link and the in-tree one for include Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-26s4-kcc: fixed valgrind errors in drs replicaInfo server sideAndrew Tridgell1-7/+5
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Fri Nov 26 03:52:30 CET 2010 on sn-devel-104
2010-11-24s4-kcc: disable the NDR printing of DRS getinfo requestsAndrew Tridgell1-0/+4
2010-11-18s4-rodc: enable the DRS_GET_ALL_GROUP_MEMBERSHIP flag for RODC replicationAndrew Tridgell1-0/+1
see the description of this flag in [MS-DRSR]
2010-11-17s4-kcc: fixed result_last_attempt in showreplAndrew Tridgell1-0/+1
2010-11-08s4-debug: lowered the debug level of some unimportant messagesAndrew Tridgell1-2/+2
2010-11-04s4:dsdb/kcc: fix memory leak in kcctpl_copy_output_edges()Stefan Metzmacher1-0/+1
metze
2010-10-23s4 dsdb kcc: Prefer msDS-hasMasterNCs over hasMasterNCs when replicatingKai Blin1-5/+10
2010-10-15s4:dsdb - remove "samdb_result_uint", "samdb_result_int64", ↵Matthias Dieter Wallnöfer2-20/+20
"samdb_result_uint64" and "samdb_result_string" We have ldb_msg_find_attr_as_* calls which do exactly the same. Therefore this reduces only code redundancies. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-10-10samdb: Add flags argument to samdb_connect().Jelmer Vernooij1-1/+1
2010-10-03s4:dsdb - substitute the "show_deleted" with the "show_recycled" controlMatthias Dieter Wallnöfer1-1/+1
We intend to see always all objects with the "show_deleted" control specified. To see also recycled objects (beginning with 2008_R2 function level) we need to use the new "show_recycled" control. As far as I see this is only internal code and therefore we don't run into problems if we do substitute it. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-10-03s4-kcc: silence "Testing kcctpl_create_intersite_connections" messageAndrew Tridgell1-1/+1
Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Sun Oct 3 04:51:44 UTC 2010 on sn-devel-104
2010-10-02s4-kcc: remove stale repsTo entries in the KCCAndrew Tridgell1-0/+32
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-09-29s4-kcc: fixed the replica_flags in repsFrom in the kccAndrew Tridgell1-31/+72
if our calculated replica_flags doesn't match the ones in our repsFrom then update it Pair-Programmed-With: Anatoliy Atanasov <anatoliy.atanasov@postpath.com>
2010-09-27s4-kcc: fixed a incorrect context to kcctpl_get_all_bridgehead_dcsAndrew Tridgell1-1/+1
2010-09-27s4-kcc: don't print "Testing kcctpl_create_intersite_connections"Andrew Tridgell1-1/+1
log level 0 is excessive for this!
2010-09-23s4/dsdb:kcc: cleanup and improve readabilityAnatoliy Atanasov1-4/+5
2010-09-23s4:dsdb/kcc: we don't need to manually allocate [out,ref] pointers anymoreStefan Metzmacher1-6/+1
metze Signed-off-by: Anatoliy Atanasov <anatoliy.atanasov@postpath.com>
2010-09-23s4-kcc: the kcc should not be setting the repsTo attributeAndrew Tridgell1-32/+2
repsTo is set by other DCs, when they ask to be notified about changes in a partition
2010-09-23s4-kcc: added service->am_rodcAndrew Tridgell4-21/+14
use a rodc flag on the service instead of calling samdb_rodc each time
2010-09-23s4-kcc: pass the service context into the kcc connection codeAndrew Tridgell2-64/+65
this will be used for the RODC changes needed for the kcc
2010-09-20s4-kcc: a bit more debug info on repsFrom creationAndrew Tridgell1-1/+7
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-09-15s4-kcc: removed redundent loop check Andrew Tridgell1-1/+1
el has already been checked for NULL
2010-09-09s4-dreplsrv: Do allocations on long-living context so that callback gets calledKamen Mazdrashki1-1/+1
2010-09-03s4:dsdb/kcc: use irpc_binding_handle_by_name()Stefan Metzmacher1-6/+39
metze