summaryrefslogtreecommitdiff
path: root/source4/dsdb/samdb
AgeCommit message (Collapse)AuthorFilesLines
2009-12-21s4-drs: Fix bug - prefixMap is not updated when adding new OIDs.Kamen Mazdrashki1-2/+1
The bug is that prefixMap is updated only memory when adding new Classs/Attribute that has and OID not in prefixMap already. Signed-off-by: Andrew Tridgell <tridge@samba.org>
2009-12-21s4-drs: another two unsigned comparison bugsAndrew Tridgell1-3/+5
2009-12-21s4-dsdb: don't use a non-constant format string for a printf formatAndrew Tridgell1-10/+3
2009-12-21s4-dsdb: added DSDB_MODIFY_RELAX flag to the dsdb_module_*() callsAndrew Tridgell2-0/+8
2009-12-21s4-dsdb: use varargs expression in dsdb_module_search()Andrew Tridgell1-1/+7
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2009-12-21s4-dsdb: give us an invocationID when in standalone modeAndrew Tridgell1-1/+79
To allow us to use the repl_meta_data module in standalone mode (and thus not have two module stacks to test), we need a invocationID stored somewhere when standalone. This creates a random one, and stores it in @SAMBA_DSDB. Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2009-12-18s4-dsdb: stop warnings about unknown struct GUID in prototypesAndrew Tridgell1-0/+1
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2009-12-18s4-dsdb: greatly simplify the subtree_delete moduleAndrew Tridgell1-117/+20
We can use dsdb_module_search() to make this much simpler Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2009-12-18s4-dsdb: fix handling of AUX classes in objectclass_sortBrendan Powers1-146/+133
This is done by sorting the classes by subClass_order, which will check if the last structural class is valid to add (in objectclass_do_add instead checking the last class in the list). They were being sorted by building a class tree, and adding the classes to the list in that order. However, AUX classes usually don't fit into that tree, so LDB_ERR_OBJECT_CLASS_VIOLATION was returned. I have changed the behavior to sort the classes by subClass_order instead. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2009-12-18s4-dsdb: return an error if samAccountName is not specified when creating a ↵Brendan Powers1-0/+7
user. Makes sure samAccountName has been specified before adding a user. This happened while I was trying to add a user with the posixAccount objectclass. I forgot to specify the user objectClass, and samba segfaulted. It now returns LDB_ERR_CONSTRAINT_VIOLATION. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2009-12-18s4-dsdb: Move get_last_structural class from descriptor.c to util.cBrendan Powers3-16/+30
It can now also be used by objectclass.c get_last_structural_class now ignores AUX classes, because they are not structural Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2009-12-18s4-dsdb: Add a check to prevent acl_modify from debuging a NULL messageBrendan Powers1-1/+5
Check to see if there were any messages passed to acl_modify before debugging the first one. I think I caused this by some malformed LDIF. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2009-12-17Fixed incorrect checking of PRINCIPAL_SELF permissions.Nadezhda Ivanova1-11/+86
If an ace has the PRINCIPAL_SELF as trustee, this sid has to be replaced with the onjectSid of the object being checked. PRINCIPAL_SELF is the way to grant rights to an account over itself.
2009-12-16s4-dsdb: also mark the relax control non-critical when doneAndrew Tridgell1-5/+3
2009-12-16s4-dsdb: it is a better pattern to mark a control as done than remove itAndrew Tridgell3-21/+7
removing a control means it can't be seen by any other modules, which is usually not what is wanted. Better to just mark it non-critical, which means anyone else who wants to look at it can, but if nobody does its not an error.
2009-12-16s4-dsdb: when the SD_FLAGS control is set, don't remove nTSecurityDescriptorAndrew Tridgell1-10/+19
2009-12-16s4-dsdb: don't actually remove the sd_flags control, just mark it non-criticalAndrew Tridgell1-14/+10
For controls that need to be seen by more than one module, it is best to just mark them non-critical when handled, instead of removing them. Otherwise lower modules can't see them. In this case we want the operational module to see the SD_FLAGS control
2009-12-16s4-dsdb: added a dsdb_module_rename() callAndrew Tridgell1-0/+43
This will be used by the replmd_delete() code Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2009-12-16s4-dsdb: added dsdb_module_modify()Andrew Tridgell1-0/+40
This is used to do a sync modify in a module Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2009-12-16s4-dsdb: fixed dsdb_module_dn_by_guid()Andrew Tridgell1-3/+7
needs to ask for the DN in storage format, plus fix compilation errors
2009-12-16s4-dsdb: dsdb_flags should be unsignedAndrew Tridgell1-1/+1
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2009-12-16s4-dsdb: rename dsdb_module_search_handle_flags to dsdb_request_add_controlsAndrew Tridgell3-6/+10
This function will be used for non-search controls, like relax
2009-12-16s4-dsdb: added dsdb_module_dn_by_guid()Andrew Tridgell1-0/+41
This finds a DN given a GUID, searching below the current module in the module stack. Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2009-12-16s4-dsdb: use dsdb_dn_is_deleted_val()Andrew Tridgell1-25/+22
This also moves the check to before we parse the DN, which saves some unnecessary work Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2009-12-15Fixed a problem with duplicate values of allowedAttributesEffective.Nadezhda Ivanova1-1/+3
2009-12-14s4-dsdb: added REVEAL_INTERNALS flag to dsdb_module_search_handle_flags()Andrew Tridgell2-0/+8
2009-12-14s4-dsdb: use the reveal control to hide/show extended DN componentsAndrew Tridgell1-1/+44
When reveal is set, then we show deleted linked attributes and all linkked attribute components. When not set we show a normal extended DN.
2009-12-12s4:operational LDB module - cosmetic - reorder an attribute listMatthias Dieter Wallnöfer1-8/+8
This matches the default handling order in the "password_hash" module (it's nice to have this consistent).
2009-12-10Implementation of sDRightsEffective, allowedAttributesEffective and ↵Nadezhda Ivanova2-43/+612
allowedChildClassesEffective. Behavior as documented in WSPP and tested. Needs optimisation though.
2009-12-10s4-dsdb: use GUID_to_ndr_blob()Andrew Tridgell2-20/+10
2009-12-10s4-dsdb: simplify linked attributes code using GUID functionsAndrew Tridgell1-18/+16
2009-12-09s4-dsdb: added dsdb_functional_level() helper functionAndrew Tridgell3-15/+4
2009-12-09s4-dsdb: use dsdb_module_search_dn in repl_meta_dataAndrew Tridgell1-1/+4
This allows us to search below the current module. That will be important when we start using the results of this search to get the linked attributes meta data right
2009-12-09s4-dsdb: fixed steal of parentGUID for empty msgAndrew Tridgell1-4/+10
msg->elements could be NULL before we add parentGUID
2009-12-07s4:dsdb Use ldb_match_msg_objectclass in operational.cAndrew Bartlett1-6/+1
This avoids not only a possibly non-portable compiler expression, but also the need to look up the schema each time. Andrew Bartlett
2009-12-07s4:dsdb Make primaryGroupToken calculation more efficient and correctAndrew Bartlett1-20/+46
The original code here would do a subtree search under each object, attempting to determine if it was a group. This was incorrect, and inefficient - we just need to ask for the objectClass attribute, and check that value before returning the group's RID. (Much of this patch reworks operational.c to allow a search for 2 attributes for this calculation). Andrew Bartlett
2009-12-07s4:dsdb Make parentGUID handler use dsdb_module_search_dn()Andrew Bartlett1-18/+29
This avoids doing a new search from the top of the module stack. This also removes the helper function dsdb_find_parentguid_by_dn() which is now unused. Andrew Bartlett
2009-12-07s4:dsdb Hide the LM password by default tooAndrew Bartlett1-1/+2
2009-12-04s4-ldb: fixed show_deleted module not to corrupt parse treesAndrew Tridgell1-23/+26
The show_deleted module was using a static private ptr in the module to hold a parse tree to save on parsing. The code caused this static ptr to change with each search, which caused incorrect searches and numerous valgrind errors. This patch replaces it with a hand-built parse tree.
2009-12-04s4-drsutil: fixed a memory leak in samdb_search_countAndrew Tridgell1-1/+4
In general functions that don't return any memory should not take a memory context. Otherwise it is too easy to have a bug like this where memory is leaked
2009-12-03s4:operational LDB module - Fix usage of LDB constantsMatthias Dieter Wallnöfer1-4/+4
2009-12-03s4-drs: fixed updating of uSNChanged in replmd_modifyAndrew Tridgell1-3/+2
Updating of uSNChanged broke in a recent change
2009-11-30s4-drs: Using dsdb_msg_add_guid() utility functionFernando J V da Silva3-46/+5
Uses the dsdb_msg_add_guid() to add any kind of GUID attribute to a ldb_message in several places of samba4 code. Signed-off-by: Andrew Tridgell <tridge@samba.org>
2009-11-30s4-ldb: changed ldb_msg_add_dn() to ldb_msg_add_linearized_dn()Crístian Deives1-3/+3
this makes the usage clearer Signed-off-by: Andrew Tridgell <tridge@samba.org>
2009-11-30s4-dsdb: don't call ldb_next_init() twice in objectclass moduleAndrew Tridgell1-1/+1
2009-11-28s4: fix SD update and password change in upgrade scriptMatthieu Patou1-4/+11
- reserve a new Samba OID for recalculate SD control - fix the update SD function - fix handling of kvno in the update_machine_account_password function - fix handling of handles in RPC winreg server Signed-off-by: Andrew Tridgell <tridge@samba.org>
2009-11-27s4:dsdb Don't segfault with ldb_transaction_prepare_commit() without begin()Andrew Bartlett1-0/+4
It is up to other modules to complain if ldb_transaction_prepare_commit() is called before ldb_transaction_begin_transaction() Andrew Bartlett
2009-11-26s4:objectclass LDB module - Prevent write operations on constructed attributesMatthias Dieter Wallnöfer1-6/+19
2009-11-26s4:operational LDB module - Don't do the write checks hereMatthias Dieter Wallnöfer1-16/+0
Let this perform the schema in the "objectclass" module.
2009-11-25s4:dsdb Make samba_dsdb easier to use in upgrades - assume default valuesAndrew Bartlett1-4/+7