Age | Commit message (Collapse) | Author | Files | Lines |
|
Just for consistency since all other LDB counters are unsigned as well.
And also the debug output specifier has been chosen to be "%u" - so it
really should be unsigned.
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Apr 8 09:17:47 CEST 2011 on sn-devel-104
|
|
|
|
- Integer handling was modeled after validate code from "schema_syntax.c".
- Double handling was modeled similar, but with a dynamic buffer.
I don't know if there is a maximum literal length for double values but an
allocation shouldn't a problem here since doubles are rare.
- String handlind is enhanced with a terminating "0" test for safety.
Reviewed-by: abartlet + metze
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Apr 7 16:38:57 CEST 2011 on sn-devel-104
|
|
|
|
failed
This is required to better detect failures and should raise the
compatiblity to "ldapadd"/"ldapmodify".
Reviewed-by: abartlet
|
|
|
|
The callers do compare against LDB error codes - hence don't give back
"-1".
Reviewed-by: Tridge + abartlet
|
|
Reviewed-by: abartlet
|
|
we were sometimes using 'paged_result' and sometimes using 'paged_results'.
The latter seemed to be more common, so I changed the two places that
used the 'paged_result' string to 'paged_results'
|
|
use feof() to detect parsing errors in ldif files
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Mar 29 08:24:04 CEST 2011 on sn-devel-104
|
|
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sun Mar 20 12:13:50 CET 2011 on sn-devel-104
|
|
|
|
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Mar 16 09:58:22 CET 2011 on sn-devel-104
|
|
|
|
|
|
Suggested by Tridge
|
|
The size for an additional "struct ldb_control" shouldn't hurt and so
the excluded control can also be NULL.
Added an ending "talloc_realloc" to resize the chunk to the
effective needed size (requested by tridge).
|
|
Reviewed by: Tridge
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Mar 4 22:51:57 CET 2011 on sn-devel-104
|
|
Reviewed by: Tridge
|
|
If we immediately afterwards perform an LDB base operation then we don't
need an explicit "ldb_dn_validate" check anymore (only OOM makes sense).
Reviewed by: Tridge
|
|
"ldb_dn_validate" is NULL-safe and does the check implicitly.
Reviewed by: Tridge
|
|
This is a much better solution than we had before - so all important DN
checks are enforced for each type of LDB database (and not limited to DSDB).
Many "ldb_dn_validate" checks will now become obsolete.
Reviewed by: Tridge
|
|
Reviewed by: Tridge
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Mar 4 09:39:22 CET 2011 on sn-devel-104
|
|
Not all LDB databases have further DN checks.
Reviewed by: Tridge
|
|
I've forgotten this in my first patchset.
Reviewed by: Tridge
|
|
using os.putenv() causes too much confusion, as it doesn't update
os.getenv()
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
|
|
|
|
Add a function to marshall a control to a string
Refactor the code of ldb_control_parse_strings to allow to extract the
core code into ldb_control_parse_from_string so that this function can
be called for just 1 string
|
|
Samba4 now depends on a new macro defined in the public ldb_modules.h header:
LDB_FLAG_INTERNAL_FORCE_SINGLE_VALUE_CHECK.
Bump up the minor release of ldb accordingly.
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Mon Feb 14 19:39:31 CET 2011 on sn-devel-104
|
|
this caused an intermittent failure in some tests
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
this allows a ldb module to force an element as single valued
|
|
this gives us a single piece of logic for single value checking in the
tdb backend
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
|
|
tests in the testsuite
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sun Feb 13 00:14:24 CET 2011 on sn-devel-104
|
|
values, helps to avoid bugs
|
|
defined in ldb.h
Allow to have less magic value in the control code and will allow not to
duplicate names when doing a function that marshal a control to it's
string representation
|
|
|
|
Simo pointed out that the module loading change should have been
combined with a major version number. That seems like a good excuse
for a 1.0 release
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
|
|
this fixes a problem with the installed ldb_modules.h header, which
depended on LDB_VERSION being defined.
Thanks to Simo for noticing this!
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
Use "return" when located in "main" for consistency ("exit" would do the
same).
The patchset has been discussed with Jelmer Vernooij and afterwards LDB
maintainer Simo Sorce.
|
|
Otherwise return "LDB_ERR_OPERATIONS_ERROR".
|
|
|
|
|
|
|
|
Use it for computing the program exit code. The "result" has not to be
free'd explicitly since it's a child by "ldb" which itself is child by
"mem_ctx".
|
|
"modify_record" returns "-1" when failing, otherwise the number of
modifies performed as an "unsigned int" converted to "int".
When we get "-1" we immediately need to stop (the error message has
already been generated by the function itself).
|
|
|
|
|