Age | Commit message (Collapse) | Author | Files | Lines |
|
Reviewed by: Tridge
|
|
If we immediately afterwards perform an LDB base operation then we don't
need an explicit "ldb_dn_validate" check anymore (only OOM makes sense).
Reviewed by: Tridge
|
|
"ldb_dn_validate" is NULL-safe and does the check implicitly.
Reviewed by: Tridge
|
|
This is a much better solution than we had before - so all important DN
checks are enforced for each type of LDB database (and not limited to DSDB).
Many "ldb_dn_validate" checks will now become obsolete.
Reviewed by: Tridge
|
|
Reviewed by: Tridge
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Mar 4 09:39:22 CET 2011 on sn-devel-104
|
|
Not all LDB databases have further DN checks.
Reviewed by: Tridge
|
|
I've forgotten this in my first patchset.
Reviewed by: Tridge
|
|
using os.putenv() causes too much confusion, as it doesn't update
os.getenv()
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
|
|
|
|
Add a function to marshall a control to a string
Refactor the code of ldb_control_parse_strings to allow to extract the
core code into ldb_control_parse_from_string so that this function can
be called for just 1 string
|
|
Samba4 now depends on a new macro defined in the public ldb_modules.h header:
LDB_FLAG_INTERNAL_FORCE_SINGLE_VALUE_CHECK.
Bump up the minor release of ldb accordingly.
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Mon Feb 14 19:39:31 CET 2011 on sn-devel-104
|
|
this caused an intermittent failure in some tests
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
this allows a ldb module to force an element as single valued
|
|
this gives us a single piece of logic for single value checking in the
tdb backend
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
|
|
tests in the testsuite
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sun Feb 13 00:14:24 CET 2011 on sn-devel-104
|
|
values, helps to avoid bugs
|
|
defined in ldb.h
Allow to have less magic value in the control code and will allow not to
duplicate names when doing a function that marshal a control to it's
string representation
|
|
|
|
Simo pointed out that the module loading change should have been
combined with a major version number. That seems like a good excuse
for a 1.0 release
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
|
|
this fixes a problem with the installed ldb_modules.h header, which
depended on LDB_VERSION being defined.
Thanks to Simo for noticing this!
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
Use "return" when located in "main" for consistency ("exit" would do the
same).
The patchset has been discussed with Jelmer Vernooij and afterwards LDB
maintainer Simo Sorce.
|
|
Otherwise return "LDB_ERR_OPERATIONS_ERROR".
|
|
|
|
|
|
|
|
Use it for computing the program exit code. The "result" has not to be
free'd explicitly since it's a child by "ldb" which itself is child by
"mem_ctx".
|
|
"modify_record" returns "-1" when failing, otherwise the number of
modifies performed as an "unsigned int" converted to "int".
When we get "-1" we immediately need to stop (the error message has
already been generated by the function itself).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
for the builds that use waf only, these are no longer needed and just
cause confusion
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
This wasn't actually causing problems before, as the structures were
the same size.
Andrew Bartlett
|
|
when user requires binary data to be displayed
using samba user-friendly ldif handlers
Found using following test search:
bin/ldbsearch -H st/dc/private/sam.ldb -b "CN=Deleted Objects,DC=samba,DC=example,DC=com" \
"(objectGUID=97b52eac-6d89-434d-b935-1e5f2e086ffc)" replPropertyMetaData --show-deleted --show-binary
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Tue Jan 18 00:40:01 CET 2011 on sn-devel-104
|
|
LDB_FLG_SHOW_BINARY is data representation flag and should
not modify behavior of data checking functions.
This lead to a bug in lib/ldb/ldb_tdb/ldb_index.c as ltdb_index_key()
function relies on ldb_should_b64_encode function to determine
how to process index keys.
Found using following test search:
bin/ldbsearch -H st/dc/private/sam.ldb -b "CN=Deleted Objects,DC=samba,DC=example,DC=com" \
"(objectGUID=97b52eac-6d89-434d-b935-1e5f2e086ffc)" replPropertyMetaData --show-deleted --show-binary
|
|
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Jan 17 06:09:23 CET 2011 on sn-devel-104
|
|
this is used to mark a ldb child request trusted, if the caller has
validated all inputs. This will be used when creating new child
requests with trusted inputs.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
|
|
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Jan 14 10:43:29 CET 2011 on sn-devel-104
|
|
|
|
this removes any extraneous components from a DN. For an extended DN,
this means removing the string DN and all but the first extended
component.
This is needed as AD returns "invalid syntax" if you don't use
a minimal DN as the base DN for a search. A non-minimal DN also
doesn't ever match in a search expression.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|