Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2010-03-22 | s4:registry - "patchfile_dotreg.c" - fix a memory leak | Matthias Dieter Wallnöfer | 1 | -3/+5 | |
Here we allocate memory on the "NULL" context through "reg_val_data_string" on each call of "set_value". So when we have written out the allocated data on the specified file descriptor we should immediately free this memory! Otherwise we may end up with a big memory consumption on big registry databases. | |||||
2010-03-22 | s4:registry - "patchfile" - add comments | Matthias Dieter Wallnöfer | 1 | -0/+6 | |
Helps to understand when we need to generate the hive diffs. | |||||
2010-03-22 | s4:registry - "patchfile.c" - consider also the hives in the generated diffs | Matthias Dieter Wallnöfer | 1 | -0/+9 | |
Apparently the diffs for the hives weren't generated previously. | |||||
2010-03-22 | s4:registry - "patchfile.c" - fix a typo | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2010-03-21 | s4:regtree - fix counter variables to be "unsigned" | Matthias Dieter Wallnöfer | 1 | -3/+4 | |
2010-03-21 | s4:registry - "LDB backend" - "reg_ldb_unpack_value" | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
When the name isn't found it is the default value. Call it "" to be consistent. | |||||
2010-03-21 | s4:registry - "LDB backend" - "reg_key_get_info" | Matthias Dieter Wallnöfer | 1 | -2/+29 | |
Consider also the default value (if it exists) as value. That means: - count it when setting "num_values" - take also his buffer length as a candidate for the maximum value buffer length This is what Windows does. | |||||
2010-03-21 | s4:registry - "LDB backend" - "ldb_get_default_value" | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
There exist also key objects (the hives) which don't contain a "key" entry at all. This prevented to display their default value (my fault). | |||||
2010-03-21 | s4:registry - "LDB backend" - make the key argument "const" of ↵ | Matthias Dieter Wallnöfer | 1 | -1/+2 | |
ldb_get_default_value | |||||
2010-03-21 | s4:registry - "LDB backend" - fix indentation | Matthias Dieter Wallnöfer | 1 | -2/+2 | |
2010-03-21 | s4:regshell - here we don't need a newline - "ctime" itself provides one | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2010-03-21 | s4:regshell - don't return an error code if we get a security descriptors error | Matthias Dieter Wallnöfer | 1 | -2/+2 | |
s4 itself doesn't support them so print only the error code out (in s4's case WERR_NOT_SUPPORTED). | |||||
2010-03-21 | s4:registry - "LDB backend" - reg_key_get_info - adapt max. subkey and value ↵ | Matthias Dieter Wallnöfer | 1 | -8/+8 | |
length Those lengths are measured in UTF8 string lengths and not in UTF16 ones (the returned strings are generally in this format). Discovered this by checking the s3 registry code. Therefore we have to multiply the both numbers by two. Discovered with the "regedt32" (old NT registry editor). | |||||
2010-03-21 | s4:registry - "LDB backend" - don't test for "0" as string termination on ↵ | Matthias Dieter Wallnöfer | 1 | -2/+1 | |
binary and unknown typed values | |||||
2010-03-21 | s4:registry - handle type "DWORD_BIG_ENDIAN" as type "DWORD" | Matthias Dieter Wallnöfer | 3 | -16/+5 | |
Further tests show that (at least per default) there aren't any differences between them. | |||||
2010-03-21 | s4:registry - "LDB backend" - fix up memory allocation for dynamic integers | Matthias Dieter Wallnöfer | 1 | -2/+2 | |
We don't need to reserve memory for NULL termination when storing data as integers. | |||||
2010-03-21 | s4:registry - "LDB backend" - Fix up the storage of binary ↵ | Matthias Dieter Wallnöfer | 1 | -11/+12 | |
REG_SZ/REG_EXPAND_SZ values There seem to exist also UTF16 sequences which have byte sizes of a multiple of two but are invalid (gd's winreg test shows this). | |||||
2010-03-16 | s4:registry - use a macro for reverse byte order | Matthias Dieter Wallnöfer | 2 | -10/+4 | |
2010-03-16 | s4:registry - check also for other registry value types in the generic test | Matthias Dieter Wallnöfer | 1 | -0/+16 | |
2010-03-16 | s4:registry - add a test for the "REG_DWORD_BIG_ENDIAN" datatype | Matthias Dieter Wallnöfer | 1 | -0/+14 | |
2010-03-16 | s4:registry - introduce the "REG_DWORD_BIG_ENDIAN" datatype | Matthias Dieter Wallnöfer | 2 | -4/+26 | |
It's like the normal REG_DWORD type but the byte order swapped | |||||
2010-03-15 | s4:registry - rpc - don't crash when communication partner isn't available | Matthias Dieter Wallnöfer | 1 | -4/+4 | |
2010-03-15 | s4:registry - util.c - treat unsupported and binary values as the same in ↵ | Matthias Dieter Wallnöfer | 1 | -17/+5 | |
the conversion functions We don't need to provide an extra representation for all available registry types. But if we treat all unsupported types as binary we also get our tools (regtree, regshell, regdiff...) working with them in a basic manner. | |||||
2010-03-15 | s4:registry - util.c - move the "REG_NONE" case in the conversion functions ↵ | Matthias Dieter Wallnöfer | 1 | -6/+6 | |
on top of the switch (As in the "reg_value_types" structure) | |||||
2010-03-15 | s4:registry - local testsuite - add a test for REG_QWORD | Matthias Dieter Wallnöfer | 1 | -1/+15 | |
Change also here to fixed-length HEX values output to test for the right representation. | |||||
2010-03-15 | s4:registry - fix up the output of hexadecimal values | Matthias Dieter Wallnöfer | 2 | -14/+6 | |
Use a fixed-length representation to avoid platform-specific issues. | |||||
2010-03-15 | s4:registry - add support for REG_QWORD values | Matthias Dieter Wallnöfer | 2 | -1/+82 | |
Basically the same as REG_DWORD but these are eight byte long. | |||||
2010-03-14 | s4:registry - util.c - add harder checks for inputs on "reg_val_data_string" | Matthias Dieter Wallnöfer | 1 | -12/+16 | |
("NULL" result is error on most data types). | |||||
2010-03-14 | s4:registry - ldb.c - provide a mechanism for storing UTF8/binary REG_DWORD ↵ | Matthias Dieter Wallnöfer | 1 | -12/+47 | |
values We need to support this as gd's WINREG torture test shows. | |||||
2010-03-14 | s4:registry - ldb.c - provide a mechansim for storing UTF8/binary ↵ | Matthias Dieter Wallnöfer | 1 | -7/+39 | |
REG_SZ/REG_EXPAND_SZ values We need to support this as gd's WINREG torture test shows. | |||||
2010-03-14 | s4:registry - ldb.c - fix up a strange LDB filter | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2010-03-14 | s4:registry - ldb.c - fix up the memory handling in "reg_ldb_unpack_value" | Matthias Dieter Wallnöfer | 1 | -3/+8 | |
Don't substitute existing data blobs with new ones and make sure, that the result objects in the data blob don't have memory dependencies of the LDB value input. | |||||
2010-03-14 | s4:registry - ldb.c - check more for possible "Out of memory" circumstances | Matthias Dieter Wallnöfer | 1 | -4/+10 | |
2010-03-14 | s4:registry - ldb.c - remove superfluous "query" variable | Matthias Dieter Wallnöfer | 1 | -4/+2 | |
2010-03-14 | s4:registry - ldb.c - Consider result values in "reg_ldb_pack_value" | Matthias Dieter Wallnöfer | 1 | -17/+59 | |
Break on errors and return NULL and otherwise the message pointer. | |||||
2010-03-14 | s4:registry - ldb.c - Move the "val" structure | Matthias Dieter Wallnöfer | 1 | -3/+5 | |
Move it into the REG_SZ/REG_EXPAND_SZ case block since it's used only there. Plus convert it from static into dynamic talloc'ed. | |||||
2010-03-12 | s4:lib/registry/rpc: convert to use dcerpc_binding_handle stubs | Stefan Metzmacher | 1 | -16/+17 | |
metze | |||||
2010-03-11 | winreg: add winreg_KeyType enum. | Günther Deschner | 1 | -1/+1 | |
Guenther | |||||
2010-03-11 | s4-registry: add all winreg types to reg_value_types table. | Günther Deschner | 1 | -3/+11 | |
Guenther | |||||
2010-03-10 | s4:registry/ldb.c - if "name" isn't set we should return WERR_INVALID_PARAM | Matthias Dieter Wallnöfer | 1 | -1/+5 | |
2010-03-10 | s4:lib/registry/ldb.c - fix up registry backend to be more robust | Matthias Dieter Wallnöfer | 1 | -9/+5 | |
This should let the new WINREG tests written by gd at least pass against us. | |||||
2010-03-06 | s4:lib/registry/ldb.c - fix trailing whitespaces | Matthias Dieter Wallnöfer | 1 | -6/+6 | |
2010-03-06 | s4:registry library - fix up "reg_ldb_set_value" | Matthias Dieter Wallnöfer | 1 | -9/+23 | |
The previous logic was wrong since it tried to add empty data in some cases which always ended in an error. This problem should be fixed with the new logic. | |||||
2010-03-06 | s4:registry library - make "reg_ldb_pack/unpack_value" more robust | Matthias Dieter Wallnöfer | 1 | -28/+35 | |
This to prevent segmentation faults, wrong server inputs ecc. | |||||
2010-03-06 | s4:libregistry - change counters to be "unsigned" | Matthias Dieter Wallnöfer | 10 | -40/+41 | |
Also the s4 registry library has to have "unsigned" counters like the Windows one. | |||||
2010-02-22 | s4:registry/regf.c - specify the context when freeing the "regf" variable | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
Otherwise we get a "talloc_free with references" warning. | |||||
2010-02-22 | Spelling fixes for source4/lib/registry. | Brad Hards | 4 | -8/+8 | |
Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de> | |||||
2010-02-09 | s4:Remove "Py_RETURN_NONE" compatibility code | Matthias Dieter Wallnöfer | 1 | -4/+0 | |
This was needed only by Python 2.3 which we no longer support. | |||||
2010-02-07 | s4-registry: fixed byte order assumptions | Andrew Tridgell | 4 | -7/+9 | |
the registry tests were broken on big-endian systems | |||||
2010-01-20 | Fix unintentional free of the last value when adding a new value to a key. | Wilco Baan Hofman | 1 | -4/+8 | |
Signed-off-by: Jelmer Vernooij <jelmer@samba.org> |