summaryrefslogtreecommitdiff
path: root/source4/lib/tdb/common
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r10891: I noticed that the secrets.db was not being backed up on my system dueAndrew Tridgell1-0/+9
to msync/mmap not changing the mtime of the file. This patch ensures that for successfully completed transactions we update the mtime. I don't do this on all tdb writes as its too expensive, but doing it just on transactions is bearable, as those cost quite a lot anyway. (This used to be commit b2934732dd62f705f59c124f19460c5436a9a422)
2007-10-10r10524: SAFE_FREE() in tdb does not need the discard_const_p()Andrew Tridgell1-10/+1
the discard_const_p() was causing problems on openbsd where intptr_t is not defined (This used to be commit f02a92787b179a4070227d87e37b7ac092d9e6eb)
2007-10-10r10522: finally got the locking working on solaris10. This adds a read lock onAndrew Tridgell1-0/+12
the transaction lock in tdb_traverse_read(). This prevents a pattern of locks which triggers the deadlock detection code in solaris10. I suspect solaris10 is trying to prevent lock starvation by granting locks in the order they were requested, which makes it much easier to produce deadlocks. (This used to be commit 54203aacd138c30826d54c5d9b6cc8d6e9e270f8)
2007-10-10r10496: - added configure test for sys/time.hAndrew Tridgell1-2/+2
- print length of failed locks (This used to be commit 11739ad31d7b3e1cf94ebf395608647e341257c4)
2007-10-10r10495: older redhat boxes need sys/time.h for select()Andrew Tridgell1-0/+3
(This used to be commit a11762e7bc139b0280e457e682722d955b81d8e5)
2007-10-10r10494: - don't generate a tdb log message for any type of failed lock probeAndrew Tridgell1-5/+2
- if the lock upgrade loop ever fails then log a warning (This used to be commit 1b03c4e6c7e89452a835ef5ff39c07f58b715a22)
2007-10-10r10493: we need sys/select.h to enable select() in the solaris workaroundAndrew Tridgell1-0/+3
(This used to be commit 144cc3da5eadf0dcb28ef722feeed813c033e08a)
2007-10-10r10492: work around a bug in solaris which cases lock upgrades to fail withAndrew Tridgell3-1/+28
EDEADLK even when progress can be made. This is not a good solution, but I can't find anything better. (This used to be commit 980dd17f7d0a622cd772afc9ba15e50007ad9c6e)
2007-10-10r10484: try to fix the pread/pwrite declaration problemsAndrew Tridgell1-7/+1
(This used to be commit 196995ea38414ce5a57031c4cdf61b3ed548196a)
2007-10-10r10483: fixed some uninitialised variables warningsAndrew Tridgell2-1/+3
(This used to be commit 315653cf1ecc11c435ee35b20e6cf9c73a67fa68)
2007-10-10r10471: stratos doesn't have getpagesize(), so guess 8k on systems that don'tAndrew Tridgell1-0/+4
have it. Overestimating is harmless. (This used to be commit ab953c8c72060c496876b6f39d388ad2f7e3c7e0)
2007-10-10r10469: use the older style of structure initialisation for tdb to make itAndrew Tridgell2-12/+12
more portable. tdb is used in more than just Samba4, and I think the portability/readability balance is a bit different (This used to be commit fc692dc61f06d61cb9126d2a8ccc240cecd11da6)
2007-10-10r10468: - terminate tdbtorture quickly when an error is detectedAndrew Tridgell2-0/+8
- more workarounds for aix not handling malloc of size 0 (This used to be commit c2b1739c6389503854f55fa8407c55071781eff4)
2007-10-10r10467: aix doesn't like zero length malloc :(Andrew Tridgell1-0/+5
(This used to be commit 0177c6ca3e9baa223b5f7b29adc12d862dcb19d8)
2007-10-10r10466: work around missing pread/pwrite declaration on openbsdAndrew Tridgell1-0/+8
(This used to be commit e615f36733966f9992670e3650fbe9b20d7d218c)
2007-10-10r10465: separate out a read_only db from a read-only traversal to ensure weAndrew Tridgell6-12/+13
don't end up doing a mmap read only (This used to be commit 294ccfd46a0c4e1af9365d028acdabec03c41ad3)
2007-10-10r10461: fixed tdb build on systems without stdint.hAndrew Tridgell1-2/+2
(This used to be commit 83168c7e76c7e3adcdb0eec1611827d4db09f858)
2007-10-10r10460: fixed portability of transaction code to systems with integerAndrew Tridgell1-6/+7
alignment constraints (like sparc) (This used to be commit bce35ad237a55376b6af98416eec92a7c4b422a6)
2007-10-10r10459: fixed some portability problemsAndrew Tridgell1-0/+2
(This used to be commit 03942dd54b31e7a4cf9c6270b26ccf68a3234b40)
2007-10-10r10424: for caller convenience, automatically turn a tdb_traverse() into aAndrew Tridgell1-0/+4
tdb_traverse_read() for read only databases (This used to be commit 9b53e04377d2ff652c4a9496798d2e3aa0dccab3)
2007-10-10r10421: following on discussions with simo, I have worked out a way ofAndrew Tridgell7-29/+100
allowing searches to proceed while another process is in a transaction, then only upgrading the transaction lock to a write lock on commit. The solution is: - split tdb_traverse() into two calls, called tdb_traverse() and tdb_traverse_read(). The _read() version only gets read locks, and will fail any write operations made in the callback from the traverse. - the normal tdb_traverse() call allows for read or write operations in the callback, but gets the transaction lock, preventing transastions from starting inside the traverse In addition we enforce the following rule that you may not start a transaction within a traverse callback, although you can start a traverse within a transaction With these rules in place I believe all the deadlock possibilities are removed, and we can now allow for searches to happen in parallel with transactions (This used to be commit 7dd31288a701d772e45b1960ac4ce4cc1be782ed)
2007-10-10r10405: added transactions into tdb, and hook them into ldb. See myAndrew Tridgell10-66/+1138
samba-technical posting for more details on the transactions design. This also adds a number of command line arguments to tdbtorture, making it more flexible, and fixes some lock deadlock conditions in the tdbtorture code. (This used to be commit 06bd8abba942ec9f1e23f5c5d546cbb71ca3a701)
2007-10-10r10258: Fix an unused/duplicate local variable.Tim Potter1-2/+0
(This used to be commit 360be7028c2244391cdd9ed6d156cec8dab9e9e9)
2007-10-10r10253: a fairly large tdb cleanup and re-organise. Nearly all of this changeAndrew Tridgell11-2395/+2128
just involves splitting up the core tdb.c code into separate files on logical boundaries, but there are some minor functional changes as well: - move the 'struct tdb_context' into tdb_private.h, hiding it from users. This was done to allow the structure to change without breaking code that uses tdb. - added accessor functions tdb_fd(), tdb_name(), and tdb_log_fn() to access the elements of struct tdb_context that were used by external code but are no longer visible - simplied tdb_append() to use tdb_fetch()/tdb_store(), which is just as good due to the way tdb locks work - changed some of the types (such as tdb_off to tdb_off_t) to make syntax highlighting work better - removed the old optional spinlock code. It was a bad idea. - fixed a bug in tdb_reopen_all() that caused tdbtorture to sometimes fail or report nasty looking errors. This is the only real bug fixed in this commit. Jeremy/Jerry, you might like to pickup this change for Samba3, as that could definately affect smbd in Samba3. The aim of all of these changes is to make the tdb transactions/journaling code I am working on easier to write. I started to write it on top of the existing tdb.c code and it got very messy. Splitting up the code makes it much easier to follow. There are more cleanups we could do in tdb, such as using uint32_t instead of u32 (suggested by metze). I'll leave those for another day. (This used to be commit 4673cdd0d261614e707b72a7a348bb0e7dbb2482)
2007-10-10r9774: r11605@blu: tridge | 2005-08-30 12:02:19 +1000Andrew Tridgell1-0/+3
make sure we don't walk off the end of the hash array (This used to be commit 3c32f24e2c6a99ec294fb16e1684cd22b08f2df4)
2007-10-10r9773: r11599@blu: tridge | 2005-08-30 11:55:57 +1000Andrew Tridgell1-5/+13
optimise this case a bit more. The total speedup using non-indexed ldbtest is now around a factor of 80x. The code is ugly as hell, but I think this speed is worth it. Of course, if we only ever do indexed searches in ldb then this doesn't help, but it seems all too common that we get unindexable searches, so the optimisation is worthwhile (This used to be commit 2e14fb893dd9815cdb2488c630131dc549e5c361)
2007-10-10r9769: r11592@blu: tridge | 2005-08-30 10:40:19 +1000Andrew Tridgell1-0/+37
added a tdb optimisation that speeds up non-indexed ldb by a large margin (often 10x or more). I'd be interested in any comments on the safety of this optimisation. See the comment in the code for an explanation. (This used to be commit 7f9efaceb6d6dfc0c82923344cc45ec34493f2ed)
2007-10-10r8624: removed valgrind comment on tdb that no longer appliesAndrew Tridgell1-19/+0
(This used to be commit 8f222c8c7a750c739d3288da0b1edb1efc3b1ffc)
2007-10-10r7641: Fix based on work from "Shlomi Yaakobovich" <Shlomi@exanet.com> to catchJeremy Allison1-6/+7
loops in corrupted tdb files. Jeremy. (This used to be commit f9f3037d6855259edd56fd5a23d63dbb37f0a751)
2007-10-10r7276: - moved static tdb function ltdb_dn_fold() into common/ so that it can beDerrell Lipman1-1/+10
called from multiple backends. (ldb_sqlite3 needs it too.) Added parameter for a callback function that determines whether an attribute needs case folding. - begin to prepare for sqlite3 in build process - work-in-progress updates, on ldb_sqlite3 (This used to be commit a80bced0b96ffb655559a43cf7f4d7a34deb5a7d)
2007-10-10r6528: - in tdb_fetch() we effectively disallowed zero length records byAndrew Tridgell1-7/+4
returning NULL/0, which is the same as we used for a failure. Having to look at tdb->ecode (which we never do) is too error prone. Instead, tdb_fetch() should behave like malloc() and talloc(), where zero length is not special and malloc(0) returns a valid pointer. - similarly in data_blob(), asking for data_blob(NULL, 0) should return a zero blob, but asking for data_blob(ptr, 0) should return a zero length blob with a valid pointer, just like talloc() and malloc() This change fixes the SummaryInformation stream stored in the tdb backend when manipulated from w2k. The w2k client was using SET_EOF_INFORMATION to create a zero-length stream, which we return STATUS_NOT_FOUND on, as the tdb_fetch() gave us back a NULL/0 blob, which we returned as not-found (This used to be commit 162bbe4402b9de6ac06103df904b9fc204fbff29)
2007-10-10r6238: Ensure if realloc fails on an internalJeremy Allison1-3/+8
tdb we fail gracefully. Jeremy. (This used to be commit d69f7c05468ae54e0474b188fedabe14e7297d53)
2007-10-10r5780: Remove unused arguments.Tim Potter1-6/+6
(This used to be commit 1ee84e373e2b44c96f9353f194b766d6a144e7ce)
2007-10-10r5779: Remove signal and timeout gubbage from tdb.Tim Potter2-126/+4
(This used to be commit dbb56e9a59cf00d57b09ded6d60bf9424d5f1f4c)
2007-10-10r5533: Patch to detect infinite loops when traversing a tdb from "Shlomi ↵Jeremy Allison1-0/+7
Yaakobovich" <Shlomi@exanet.com> Jeremy. (This used to be commit 84f6d2b3dd29c1aa478708db9617a79382158f64)
2007-10-10r5298: - got rid of pstring.h from includes.h. This at least makes it a bitAndrew Tridgell2-0/+3
less likely that anyone will use pstring for new code - got rid of winbind_client.h from includes.h. This one triggered a huge change, as winbind_client.h was including system/filesys.h and defining the old uint32 and uint16 types, as well as its own pstring and fstring. (This used to be commit 9db6c79e902ec538108d6b7d3324039aabe1704f)
2007-10-10r5296: - only include the tdb headers where they are neededAndrew Tridgell3-2/+3
- removed the u32 hack in events.c as I think this was only needed as tdb.h defines u32. Metze, can you check that this hack is indeed no longer needed on your suse system? (This used to be commit 6f79432fe656164d4770dbce114a30dda5e7bf9a)
2007-10-10r4466: rather than defining "STANDALONE" for building tdb, ldb and tallocAndrew Tridgell2-4/+4
outside the tree, instead defined _SAMBA_BUILD_ inside the Samba build. This makes it easier to pull code out of Samba for external use. (This used to be commit 09e98c8745cca7ccb1ad7134c0c09b8e4c0f4f06)
2007-10-10r3480: moved some signal defines into include/systemAndrew Tridgell1-0/+1
(This used to be commit a954e707ef5b23af84ef8f622336e36379c4a373)
2007-10-10r3463: separated out some more headers (asn_1.h, messages.h, dlinklist.h and ↵Andrew Tridgell1-1/+2
ioctl.h) (This used to be commit b97e395c814762024336c1cf4d7c25be8da5813a)
2007-10-10r3454: moved a few more things out if includes.h into the include/system/ ↵Andrew Tridgell1-0/+1
include files. this brings us down to about 11k lines of headers included with includes.h, while still retaining the speed of building with pch (This used to be commit 10188869ef072309ca580b8b933e172571fcdda7)
2007-10-10r3447: more include/system/XXX.h include filesAndrew Tridgell1-0/+2
(This used to be commit 264ce9181089922547e8f6f67116f2d7277a5105)
2007-10-10r2985: got rid of the unused tdb_lockkeys() and tdb_unlockkeys() functionsAndrew Tridgell1-71/+0
they have been broken for 4 years (ever since they were added) and have been never used, which makes them prime candidates for destruction. (This used to be commit 0b53ab85aae4569c04495f07c18a65fd6b47bf4c)
2007-10-10r2981: Fix incorrect locks/unlocks in tdb_lockkeys()/tdb_unlockkeys().Jeremy Allison1-3/+3
Spotted by Taj Khattra <taj.khattra@gmail.com>. Jeremy. (This used to be commit a7d92301bbf45cb9e475e4876fdbb37644ad5871)
2007-10-10r2634: use discard_const_p() in a few placesAndrew Tridgell1-1/+1
(This used to be commit 56ecda2178e33508c55c6195ccec41c06e099d6f)
2007-10-10r2238: the tdb_debug() function was totally bogus - remove it (you can'tAndrew Tridgell2-33/+22
convert a ... varargs function to a va_list by just a cast!!) also mark the tdb log function with PRINTF_ATTRIBUTE() and fixed some bad format errors in tdb.c that jim found. (This used to be commit c26c92eb8f538748fcbb2ae5a0a8a02bffbbbf86)
2007-10-10r2154: Merge of Jim's format string fixup in r2130:2131Tim Potter1-1/+1
(This used to be commit 17a53eaac2d0d76413c8bb27a6f1c80536ccf3a7)
2007-10-10r2034: Allow user-selectable hash functions on open only.Jeremy Allison1-15/+17
Jeremy. (This used to be commit b43320ee5c9ac14c330e61ae62e0786b088e04fa)
2007-10-10r1053: Make tdb build standalone:Tim Potter2-14/+15
- #include <stdint.h> - uint_t isn't a valid type, change back to unsigned int (This used to be commit f690325565d2393bba3cb9f6e7cdf3753cbd4423)
2007-10-10r962: convert 'unsigned' and 'unsigned int' to uint_tStefan Metzmacher2-3/+3
metze (This used to be commit 57151e80eb1090281401930c8fe25b20a8cf3a38)