Age | Commit message (Collapse) | Author | Files | Lines |
|
to msync/mmap not changing the mtime of the file. This patch ensures
that for successfully completed transactions we update the mtime.
I don't do this on all tdb writes as its too expensive, but doing it
just on transactions is bearable, as those cost quite a lot anyway.
(This used to be commit b2934732dd62f705f59c124f19460c5436a9a422)
|
|
then StaticLibrary()
(This used to be commit b53313dc517986c69a4e4cb8fe3885b696f8faa1)
|
|
the discard_const_p() was causing problems on openbsd where intptr_t is not defined
(This used to be commit f02a92787b179a4070227d87e37b7ac092d9e6eb)
|
|
the transaction lock in tdb_traverse_read(). This prevents a pattern
of locks which triggers the deadlock detection code in solaris10. I
suspect solaris10 is trying to prevent lock starvation by granting
locks in the order they were requested, which makes it much easier to
produce deadlocks.
(This used to be commit 54203aacd138c30826d54c5d9b6cc8d6e9e270f8)
|
|
- print length of failed locks
(This used to be commit 11739ad31d7b3e1cf94ebf395608647e341257c4)
|
|
(This used to be commit a11762e7bc139b0280e457e682722d955b81d8e5)
|
|
- if the lock upgrade loop ever fails then log a warning
(This used to be commit 1b03c4e6c7e89452a835ef5ff39c07f58b715a22)
|
|
(This used to be commit 144cc3da5eadf0dcb28ef722feeed813c033e08a)
|
|
EDEADLK even when progress can be made. This is not a good solution,
but I can't find anything better.
(This used to be commit 980dd17f7d0a622cd772afc9ba15e50007ad9c6e)
|
|
(This used to be commit 196995ea38414ce5a57031c4cdf61b3ed548196a)
|
|
(This used to be commit 315653cf1ecc11c435ee35b20e6cf9c73a67fa68)
|
|
right)
(This used to be commit a795fc0aa141c08af6e37af07c88164bad3db35b)
|
|
have it. Overestimating is harmless.
(This used to be commit ab953c8c72060c496876b6f39d388ad2f7e3c7e0)
|
|
this is just a solaris issue this patch changes the default to 3, and
I'll see how many build farm boxes break
(This used to be commit c85836bafc9c042deac2a02ef6fddbfeaa5f47f1)
|
|
more portable. tdb is used in more than just Samba4, and I think the
portability/readability balance is a bit different
(This used to be commit fc692dc61f06d61cb9126d2a8ccc240cecd11da6)
|
|
- more workarounds for aix not handling malloc of size 0
(This used to be commit c2b1739c6389503854f55fa8407c55071781eff4)
|
|
(This used to be commit 0177c6ca3e9baa223b5f7b29adc12d862dcb19d8)
|
|
(This used to be commit e615f36733966f9992670e3650fbe9b20d7d218c)
|
|
don't end up doing a mmap read only
(This used to be commit 294ccfd46a0c4e1af9365d028acdabec03c41ad3)
|
|
(This used to be commit d9ee0e8b59ee52ed1e41865cffe97e32b504e7e7)
|
|
same directory
as the source
(This used to be commit 312491b2511039f3d6308e70c849810c35a3259c)
|
|
(This used to be commit 83168c7e76c7e3adcdb0eec1611827d4db09f858)
|
|
alignment constraints (like sparc)
(This used to be commit bce35ad237a55376b6af98416eec92a7c4b422a6)
|
|
(This used to be commit 03942dd54b31e7a4cf9c6270b26ccf68a3234b40)
|
|
tdb_traverse_read() for read only databases
(This used to be commit 9b53e04377d2ff652c4a9496798d2e3aa0dccab3)
|
|
allowing searches to proceed while another process is in a
transaction, then only upgrading the transaction lock to a write lock
on commit.
The solution is:
- split tdb_traverse() into two calls, called tdb_traverse() and
tdb_traverse_read(). The _read() version only gets read locks, and
will fail any write operations made in the callback from the
traverse.
- the normal tdb_traverse() call allows for read or write operations
in the callback, but gets the transaction lock, preventing
transastions from starting inside the traverse
In addition we enforce the following rule that you may not start a
transaction within a traverse callback, although you can start a
traverse within a transaction
With these rules in place I believe all the deadlock possibilities are
removed, and we can now allow for searches to happen in parallel with
transactions
(This used to be commit 7dd31288a701d772e45b1960ac4ce4cc1be782ed)
|
|
(This used to be commit 749b19d34f6105c696a07cc2cd39d5acecfc735b)
|
|
code as they are marked as NOPROTO in the config.mk files.
(This used to be commit 5f530eacbae073e9df6adde316404f70ecfe9122)
|
|
but it definately needs transaction.c now
(This used to be commit fa353a5bc562fa1ace0daf6586c42d1d5698c6e4)
|
|
samba-technical posting for more details on the transactions design.
This also adds a number of command line arguments to tdbtorture,
making it more flexible, and fixes some lock deadlock conditions in
the tdbtorture code.
(This used to be commit 06bd8abba942ec9f1e23f5c5d546cbb71ca3a701)
|
|
(This used to be commit 40a8ad2d1eb26d1635b8f188036b04319ffd41b4)
|
|
(This used to be commit 21e5c328a033a4b452b3fd696069ad8bbfa6b9cc)
|
|
is busted though.
(This used to be commit 54882f88cad1427b6adcb4c956a63e534e7d13e4)
|
|
(This used to be commit 59d4450453c25f5cce9b67b808ff0c4433c1d194)
|
|
(This used to be commit f35c4763d5c681a74af1f59e75a2f93e99d645cb)
|
|
Start on custom Samba scons tools (for handling proto generation, pidl, etc)
(This used to be commit 4bffe4435944fffa3f9680b5a2fe63f2bdd98003)
|
|
(This used to be commit 360be7028c2244391cdd9ed6d156cec8dab9e9e9)
|
|
just involves splitting up the core tdb.c code into separate files on
logical boundaries, but there are some minor functional changes as well:
- move the 'struct tdb_context' into tdb_private.h, hiding it from
users. This was done to allow the structure to change without
breaking code that uses tdb.
- added accessor functions tdb_fd(), tdb_name(), and tdb_log_fn() to
access the elements of struct tdb_context that were used by
external code but are no longer visible
- simplied tdb_append() to use tdb_fetch()/tdb_store(), which is just
as good due to the way tdb locks work
- changed some of the types (such as tdb_off to tdb_off_t) to make
syntax highlighting work better
- removed the old optional spinlock code. It was a bad idea.
- fixed a bug in tdb_reopen_all() that caused tdbtorture to sometimes
fail or report nasty looking errors. This is the only real bug
fixed in this commit. Jeremy/Jerry, you might like to pickup this
change for Samba3, as that could definately affect smbd in
Samba3.
The aim of all of these changes is to make the tdb
transactions/journaling code I am working on easier to write. I
started to write it on top of the existing tdb.c code and it got very
messy. Splitting up the code makes it much easier to follow.
There are more cleanups we could do in tdb, such as using uint32_t
instead of u32 (suggested by metze). I'll leave those for another day.
(This used to be commit 4673cdd0d261614e707b72a7a348bb0e7dbb2482)
|
|
make sure we don't walk off the end of the hash array
(This used to be commit 3c32f24e2c6a99ec294fb16e1684cd22b08f2df4)
|
|
optimise this case a bit more. The total speedup using non-indexed
ldbtest is now around a factor of 80x. The code is ugly as hell, but
I think this speed is worth it.
Of course, if we only ever do indexed searches in ldb then this
doesn't help, but it seems all too common that we get unindexable
searches, so the optimisation is worthwhile
(This used to be commit 2e14fb893dd9815cdb2488c630131dc549e5c361)
|
|
added a tdb optimisation that speeds up non-indexed ldb by a large
margin (often 10x or more). I'd be interested in any comments on the
safety of this optimisation. See the comment in the code for an
explanation.
(This used to be commit 7f9efaceb6d6dfc0c82923344cc45ec34493f2ed)
|
|
(This used to be commit 7548a5012aad41bde0652d4532d184545997be86)
|
|
(This used to be commit 9ea601c0a675767f8ea5f316c9355572dffbc4c0)
|
|
Autogenerate list of binaries (rather then having them hardcoded in build/smb_build/makefile.pm)
Add INSTALLDIR keyword to .mk files
(This used to be commit ce0935112b846486cf705ec69f12350be9c4c89d)
|
|
(This used to be commit 8f222c8c7a750c739d3288da0b1edb1efc3b1ffc)
|
|
- reduced the torture size so it doesn't kill the build farm hosts
(This used to be commit 7a88a9f06cbe5c125edad0da7908b94bcedfe4fc)
|
|
(This used to be commit 4a61a5c70efdf3842e19ae74a2b56c4b10e8e294)
|
|
'make bin/tdbtest' manually in the tdb tree
(This used to be commit 28dd79587df523c5622d09bd6d59305ae79af479)
|
|
don't have libgdbm, and the configure test for gdbm is broken
(This used to be commit 5c4c3e9a8d9d853028271f228ad36388f4cb2012)
|
|
loops in corrupted tdb files.
Jeremy.
(This used to be commit f9f3037d6855259edd56fd5a23d63dbb37f0a751)
|