summaryrefslogtreecommitdiff
path: root/source4/lib
AgeCommit message (Collapse)AuthorFilesLines
2009-09-06s4: Fix typoMatthias Dieter Wallnöfer1-2/+2
2009-09-06s4:ldb_errors - add spacesMatthias Dieter Wallnöfer1-0/+2
2009-09-04ldb: make ldb module programming less error proneAndrew Tridgell2-0/+17
When a top level method in a module returns an error, it is supposed to call ldb_module_done(). We ran across a case where this wasn't done, and then found that in fact that are hundreds of similar cases in our modules. It took Andrew and I a full day to work out that this was the cause of a subtle segv in another part of the code. To try to prevent this happening again, this patch changes ldb_next_request() to catch the error by checking if a module returning an error has called ldb_module_done(). If it hasn't then the call is made on behalf of the module.
2009-09-04ldb: ensure we cancel a ldb transactionAndrew Tridgell2-3/+9
When we fail a ldbadd or ldbedit we should cancel the transaction to prevent ldb giving a warning about having a open transaction in the ldb destructor
2009-09-03always use prepare_commit in ldb transaction commits if possibleAndrew Tridgell3-6/+51
The reason we need this is to make multi-tdb transactions safe, with the partition module. The linked_attributes and repl_meta_data modules now do extra processing when the transaction ends, and that processing can fail. When it fails we need to cancel the transaction, which we can only do if the hook is on the prepare commit instead of the end transaction call. Otherwise the partition module cannot ensure that no commit has been done on another partition.
2009-09-02show the full set of command line options for ldb toolsAndrew Tridgell5-29/+6
I always found it hard to remember some of the options. We might as well use popt to give us the full list
2009-09-02use ldb_cmdline_help() in ldbsearchAndrew Tridgell2-8/+3
2009-09-02added ldb_cmdline_help()Andrew Tridgell1-29/+36
This allows the ldb tools to show their full command line options
2009-09-02don't allow two controls to be added with the same OIDAndrew Tridgell1-1/+7
Two controls with the same OID makes no sense, as they may have different data attached
2009-09-02added ldb_ldif_message_string()Andrew Tridgell2-0/+28
This function provides a easy function for displaying a ldb_message structure in a human readable format. It is especially useful for calling in gdb.
2009-08-30ldb: Depend on libtalloc 2.0.0Simo Sorce1-1/+1
2009-08-30ldb: cosmetic changes in ldb_dnSimo Sorce1-193/+292
- remove trailing spaces and tabs - shorten some variable names for readability - try to break superlong lines for readability
2009-08-28s4:ldb Don't sleep(100) in this error case, but debug the LDIFAndrew Bartlett1-6/+6
2009-08-28s4-ldb: update dlinklist.h to match main copy (lib/util/dlinklist.h)Michael Adam1-6/+5
Michael
2009-08-26s4:ldb Add ldb_ldif_write_string() and python wrappersAndrew Bartlett4-1/+95
This allows us to turn a python LdbMessage back into a string. Andrew Bartlett
2009-08-26s4:ldb Add hooks to get/set the flags on a ldb_message_elementAndrew Bartlett2-5/+65
Also add tests to prove that we got this correct, and correct the existing tests which used the wrong constants. Andrew Bartlett
2009-08-24s4:ldb Add python binding and test for ldb_msg_diff()Andrew Bartlett2-0/+43
2009-08-24s4:cmdline: setup talloc log and abort functionsStefan Metzmacher1-0/+7
metze
2009-08-21s4:ldb Python requires that a 'compare' handler return -1, 0 or 1Andrew Bartlett1-1/+5
2009-08-21s4:ldb Use length-limited printf to avoid walking off end of stringsAndrew Bartlett1-1/+1
This should ensure the debug messages do not have random characters at their ends. Andrew Bartlett
2009-08-17s4: Make the int32 problem more clear - and fix another errorMatthias Dieter Wallnöfer1-0/+4
2009-08-17s4: Fixed the int32 datatype supportMatthias Dieter Wallnöfer1-3/+3
Should finally fix bug #6136 ("groupType", "sAMAccountType" ... attributes).
2009-08-17s4:ldb python bindings: Handle the parameters of the connect call in the ↵Matthias Dieter Wallnöfer1-2/+8
right way
2009-08-17s4:ldb Remove obsolete comment about ldb_tdb's sequence numAndrew Bartlett1-2/+0
2009-08-17fixed the updateNow schema test to use a canonical OIDAndrew Tridgell1-1/+2
The expression time.strftime("%s", time.gmtime())[3:] leads to a string with a leading 0. When added then read back from the prefix map this leads to a different string, so it is never found. Use the simpler str(random.randint(a,b)) expression instead
2009-08-14s4:ldb - Free the asynchronous resultMatthias Dieter Wallnöfer1-0/+2
2009-08-14s4: Better way to call "dom_sid_to_rid" from ldap.pyMatthias Dieter Wallnöfer1-4/+2
2009-08-11ldb: Don't break the standalone LDB build (operational module removed)Matthias Dieter Wallnöfer1-2/+2
2009-08-11s4:test for "primaryGroupToken"Matthias Dieter Wallnöfer1-10/+58
Tests for the right behaviour of this introduced constructed attribute. Since we don't support the read-only-ness of those attributes yet, I commented some lines out. Also I had to add a function for python which converts domain SIDs in RIDs. And a small fix for the "groupType" test.
2009-08-11s4:operational module - move and enhancementsMatthias Dieter Wallnöfer2-326/+0
This moves the "operational" LDB module to the right place under "dsdb/samdb/ldb_modules" (suggested by abartlet) and enhances it for supporting dynamic generated "primaryGroupToken" for AD groups. This should fix bug #6466.
2009-08-12raise the debug level for a common messageAndrew Tridgell1-1/+1
when a client disconnects we expect this to happen, so don't print an error each time
2009-08-07fixed several places that unnecessarily take a reference to the event contextAndrew Tridgell1-1/+1
These references were triggering the ambiguous talloc_free errors from the recent talloc changes when the server is run using the 'standard' process model instead of the 'single' process model. I am aiming to move the build farm to use the 'standard' process model soon, as part of an effort to make our test environment better match the real deployment of Samba4. The references are not needed as the way that the event context is used is as the 'top parent', so when the event context is freed then all of the structures that were taking a reference to the event context were actually freed as well, thus making the references redundent.
2009-08-07make sure we never look past the end of either string in ldb_comparison_fold()Andrew Tridgell1-26/+44
This fixes a bug in the samba3sam test with the python libraries as noticed by abartlet
2009-08-07s4:ldb Make error message in rnd_name more usefulAndrew Bartlett1-3/+9
2009-08-05s4:ldb Cosmetic corrections in "rdn_name" moduleMatthias Dieter Wallnöfer1-4/+4
2009-08-05pyldb: Fix reference counting on ldb_message_elements, add extra typeJelmer Vernooij1-1/+9
check.
2009-08-05s4:ldb initialise e->values[i].length before use in python bindingsAndrew Bartlett1-1/+1
2009-08-04Add constAndrew Bartlett1-1/+1
2009-08-04s4:ldif_handlers Allow a binary nTsecurityDescriptor when parsing LDIFAndrew Bartlett1-1/+17
Also allow a SDDL security descriptor, using the domain SID attached to the session (it will search for it during the LDIF parse if need be). Andrew Bartlett
2009-08-04pyldb: Properly keep copies of Python string contents, rather thanJelmer Vernooij1-9/+21
relying on reference leaks :-)
2009-08-03pyldb: Raise proper exception when attempting to assign a string to a dnJelmer Vernooij2-5/+24
attribute.
2009-07-31s4:tls: avoid using talloc_reference() in tls_init_client()Stefan Metzmacher1-6/+2
metze
2009-07-31s4:tls: avoid using talloc_reference() in tls_init_server()Stefan Metzmacher1-8/+1
metze
2009-07-30DCE/RPC(Python): Rename py_talloc_import to py_talloc_steal.Jelmer Vernooij1-7/+7
Use py_talloc_reference in DCE/RPC code, fixes access to SAMR pipe.
2009-07-28s4:tls Enable GnuTLS back to version 1.4 (an into the future)Andrew Bartlett1-1/+1
We think we have the bug fixed. Andrew Bartlett
2009-07-23s4:ldb: add support for the new Recycle Bin Feature LDAP controlsStefan Metzmacher2-0/+68
LDB_CONTROL_SHOW_RECYCLED_OID 1.2.840.113556.1.4.2064 LDB_CONTROL_SHOW_DEACTIVATED_LINK_OID 1.2.840.113556.1.4.2065 metze
2009-07-19source4/lib/registry/patchfile.c(reg_diff_load): fixed possible resource leak.Slava Semushin1-0/+1
File descriptor leaks when write(2) fails and we are returning from function. Found by cppcheck: [./source4/lib/registry/patchfile.c:319]: (error) Resource leak: fd
2009-07-19Remove unnecessary include, update README.Jelmer Vernooij2-4/+0
2009-07-19Remove outdated status file about samba3 -> samba4 upgrade project.Jelmer Vernooij1-68/+0
2009-07-18Actually fill in ldb modules directory.Jelmer Vernooij1-1/+1