Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2010-03-22 | s4:registry - "reg_key_del/add_abs": call "talloc_free" only on valid objects | Matthias Dieter Wallnöfer | 1 | -6/+6 | |
2010-03-22 | s4:registry - "reg_import_hive_key" - change a "talloc_steal" into a ↵ | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
"talloc_reference" Use a "talloc_reference" since the "hive" variable can continue to exist also after the destructed "struct local_key" object. It is also referenced by the "mountpoints" structure under the "ctx" object. | |||||
2010-03-22 | s4:registry - "patchfile" - add another "W_ERROR_HAVE_NO_MEMORY" macro call | Matthias Dieter Wallnöfer | 1 | -0/+1 | |
2010-03-22 | s4:registry - "local" - add also here more "W_ERROR_HAVE_NO_MEMORY" macro tests | Matthias Dieter Wallnöfer | 1 | -8/+26 | |
2010-03-22 | s4:registry - "util.c" - initialise "result" in "reg_key_add_abs" | Matthias Dieter Wallnöfer | 1 | -0/+2 | |
2010-03-22 | s4:registry - "samba.c" - add a "talloc_free" | Matthias Dieter Wallnöfer | 1 | -0/+2 | |
2010-03-22 | s4:registry - add more "W_ERROR_HAVE_NO_MEMORY" invocations (on talloc'ed stuff) | Matthias Dieter Wallnöfer | 4 | -1/+13 | |
2010-03-22 | s4:registry - "util" - remove "const" from "reg_abs_path" | Matthias Dieter Wallnöfer | 1 | -3/+3 | |
Here it's not really needed | |||||
2010-03-22 | s4:registry - adaptions for "add also a memory context argument for ↵ | Matthias Dieter Wallnöfer | 2 | -2/+2 | |
"reg_key_del_abs" | |||||
2010-03-22 | s4:registry - "util" - add also a memory context argument for "reg_key_del_abs" | Matthias Dieter Wallnöfer | 2 | -5/+4 | |
2010-03-22 | s4:registry - "util" - make "reg_key_add_abs" consistent with "reg_key_del_abs" | Matthias Dieter Wallnöfer | 1 | -6/+3 | |
2010-03-22 | s4:registry - "util" - fix up memory allocated data | Matthias Dieter Wallnöfer | 1 | -1/+10 | |
2010-03-22 | s4:registry - "dir.c" - fix up dynamic memory allocation operations | Matthias Dieter Wallnöfer | 1 | -15/+50 | |
- Added free operations where needed - Use always the "mem_ctx" for temporary data - Proof with W_ERROR_HAVE_NO_MEMORY if stuff was allocated | |||||
2010-03-22 | s4:registry - adaptions for "add memory contexts for delete value/key functions" | Matthias Dieter Wallnöfer | 13 | -62/+57 | |
2010-03-22 | s4:registry - registry.h - add memory contexts for delete value/key functions | Matthias Dieter Wallnöfer | 1 | -8/+16 | |
2010-03-22 | s4:registry - "RPC backend" - use "talloc_steal" and not "talloc_reference" | Matthias Dieter Wallnöfer | 1 | -4/+4 | |
No need to create additional references but we need to assign the strings to the right context. | |||||
2010-03-22 | s4:registry - "patchfile" - check if strings could be allocated | Matthias Dieter Wallnöfer | 1 | -0/+10 | |
2010-03-22 | s4:registry - "patchfile" - initialise the data blobs | Matthias Dieter Wallnöfer | 1 | -2/+2 | |
2010-03-22 | s4:registry - "patchfile" - add more "talloc_free"s to save memory | Matthias Dieter Wallnöfer | 1 | -5/+30 | |
2010-03-22 | s4:registry - "util.c" - "reg_string_to_val" - consider always the return values | Matthias Dieter Wallnöfer | 1 | -7/+9 | |
In some cases we didn't consider them. | |||||
2010-03-22 | s4:registry - "patchfile_preg.c" - also here don't accumulate the memory usage | Matthias Dieter Wallnöfer | 1 | -4/+26 | |
Free always the unused stuff. | |||||
2010-03-22 | s4:registry - "patchfile_dotreg.c" - fix a memory leak | Matthias Dieter Wallnöfer | 1 | -3/+5 | |
Here we allocate memory on the "NULL" context through "reg_val_data_string" on each call of "set_value". So when we have written out the allocated data on the specified file descriptor we should immediately free this memory! Otherwise we may end up with a big memory consumption on big registry databases. | |||||
2010-03-22 | s4:registry - "patchfile" - add comments | Matthias Dieter Wallnöfer | 1 | -0/+6 | |
Helps to understand when we need to generate the hive diffs. | |||||
2010-03-22 | s4:dsdb Rework schema loading and add schema reloading | Andrew Bartlett | 1 | -1/+4 | |
This commit reworks Samba4's schema loading code to detect when it needs to reload the schema. This is done by watching the @REPLCHANGED special DN. The reload happens by means of a callback, which is only set when the schema is loaded from the ldb - not when loaded from an LDIF file or DRS. We also rework the global schema handling - instead of storing the pointer to the global schema in each ldb, we store a flag indicating that the global schema should be returned at run time. This makes it much easier to switch to a new global schema. Andrew Bartlett | |||||
2010-03-22 | s4:registry - "patchfile.c" - consider also the hives in the generated diffs | Matthias Dieter Wallnöfer | 1 | -0/+9 | |
Apparently the diffs for the hives weren't generated previously. | |||||
2010-03-22 | s4:registry - "patchfile.c" - fix a typo | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2010-03-21 | s4:regtree - fix counter variables to be "unsigned" | Matthias Dieter Wallnöfer | 1 | -3/+4 | |
2010-03-21 | s4:registry - "LDB backend" - "reg_ldb_unpack_value" | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
When the name isn't found it is the default value. Call it "" to be consistent. | |||||
2010-03-21 | s4:registry - "LDB backend" - "reg_key_get_info" | Matthias Dieter Wallnöfer | 1 | -2/+29 | |
Consider also the default value (if it exists) as value. That means: - count it when setting "num_values" - take also his buffer length as a candidate for the maximum value buffer length This is what Windows does. | |||||
2010-03-21 | s4:registry - "LDB backend" - "ldb_get_default_value" | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
There exist also key objects (the hives) which don't contain a "key" entry at all. This prevented to display their default value (my fault). | |||||
2010-03-21 | s4:registry - "LDB backend" - make the key argument "const" of ↵ | Matthias Dieter Wallnöfer | 1 | -1/+2 | |
ldb_get_default_value | |||||
2010-03-21 | s4:registry - "LDB backend" - fix indentation | Matthias Dieter Wallnöfer | 1 | -2/+2 | |
2010-03-21 | s4:regshell - here we don't need a newline - "ctime" itself provides one | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2010-03-21 | s4:regshell - don't return an error code if we get a security descriptors error | Matthias Dieter Wallnöfer | 1 | -2/+2 | |
s4 itself doesn't support them so print only the error code out (in s4's case WERR_NOT_SUPPORTED). | |||||
2010-03-21 | s4:registry - "LDB backend" - reg_key_get_info - adapt max. subkey and value ↵ | Matthias Dieter Wallnöfer | 1 | -8/+8 | |
length Those lengths are measured in UTF8 string lengths and not in UTF16 ones (the returned strings are generally in this format). Discovered this by checking the s3 registry code. Therefore we have to multiply the both numbers by two. Discovered with the "regedt32" (old NT registry editor). | |||||
2010-03-21 | s4:registry - "LDB backend" - don't test for "0" as string termination on ↵ | Matthias Dieter Wallnöfer | 1 | -2/+1 | |
binary and unknown typed values | |||||
2010-03-21 | s4:registry - handle type "DWORD_BIG_ENDIAN" as type "DWORD" | Matthias Dieter Wallnöfer | 3 | -16/+5 | |
Further tests show that (at least per default) there aren't any differences between them. | |||||
2010-03-21 | s4:registry - "LDB backend" - fix up memory allocation for dynamic integers | Matthias Dieter Wallnöfer | 1 | -2/+2 | |
We don't need to reserve memory for NULL termination when storing data as integers. | |||||
2010-03-21 | s4:registry - "LDB backend" - Fix up the storage of binary ↵ | Matthias Dieter Wallnöfer | 1 | -11/+12 | |
REG_SZ/REG_EXPAND_SZ values There seem to exist also UTF16 sequences which have byte sizes of a multiple of two but are invalid (gd's winreg test shows this). | |||||
2010-03-16 | s4:registry - use a macro for reverse byte order | Matthias Dieter Wallnöfer | 2 | -10/+4 | |
2010-03-16 | s4:dsdb Change dsdb_get_schema() callers to use new talloc argument | Andrew Bartlett | 1 | -1/+1 | |
This choses an appropriate talloc context to attach the schema too, long enough lived to ensure it does not go away before the operation compleates. Andrew Bartlett | |||||
2010-03-16 | s4:registry - check also for other registry value types in the generic test | Matthias Dieter Wallnöfer | 1 | -0/+16 | |
2010-03-16 | s4:registry - add a test for the "REG_DWORD_BIG_ENDIAN" datatype | Matthias Dieter Wallnöfer | 1 | -0/+14 | |
2010-03-16 | s4:registry - introduce the "REG_DWORD_BIG_ENDIAN" datatype | Matthias Dieter Wallnöfer | 2 | -4/+26 | |
It's like the normal REG_DWORD type but the byte order swapped | |||||
2010-03-15 | s4:registry - rpc - don't crash when communication partner isn't available | Matthias Dieter Wallnöfer | 1 | -4/+4 | |
2010-03-15 | s4:registry - util.c - treat unsupported and binary values as the same in ↵ | Matthias Dieter Wallnöfer | 1 | -17/+5 | |
the conversion functions We don't need to provide an extra representation for all available registry types. But if we treat all unsupported types as binary we also get our tools (regtree, regshell, regdiff...) working with them in a basic manner. | |||||
2010-03-15 | s4:registry - util.c - move the "REG_NONE" case in the conversion functions ↵ | Matthias Dieter Wallnöfer | 1 | -6/+6 | |
on top of the switch (As in the "reg_value_types" structure) | |||||
2010-03-15 | s4:registry - local testsuite - add a test for REG_QWORD | Matthias Dieter Wallnöfer | 1 | -1/+15 | |
Change also here to fixed-length HEX values output to test for the right representation. | |||||
2010-03-15 | s4:registry - fix up the output of hexadecimal values | Matthias Dieter Wallnöfer | 2 | -14/+6 | |
Use a fixed-length representation to avoid platform-specific issues. | |||||
2010-03-15 | s4:registry - add support for REG_QWORD values | Matthias Dieter Wallnöfer | 2 | -1/+82 | |
Basically the same as REG_DWORD but these are eight byte long. |