summaryrefslogtreecommitdiff
path: root/source4/lib
AgeCommit message (Collapse)AuthorFilesLines
2013-09-19lib/messaging: Check the server_id type correctlyAndrew Bartlett1-1/+1
Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Sep 19 23:19:16 CEST 2013 on sn-devel-104
2013-08-19registry4: Fix CID 1034911 Dereference before null checkVolker Lendecke1-1/+1
curbegin is always != NULL here (curend + 1) and is dereferenced by strchr. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-08-19registry4: Fix CID 1034911 Dereference before null checkVolker Lendecke1-1/+1
curbegin is always != NULL here (curend + 1) and is dereferenced by strchr. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-07-24s4-lib/socket: Allocate a the larger sockaddr_un and not just a sockaddr_in ↵Stefan Metzmacher1-2/+2
in unixdom_get_my_addr() This caused crashes in _tsocket_address_bsd_from_sockaddr() when we read past the end of the allocation. (similar to commit e9ae36e9683372b86f1efbd29904722a33fea083) Bug: https://bugzilla.samba.org/show_bug.cgi?id=10042 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Jul 24 14:37:43 CEST 2013 on sn-devel-104
2013-07-23s4-lib/socket: Allocate a the larger sockaddr_un and not just a sockaddr_in ↵Andrew Bartlett1-2/+2
in unixdom_get_peer_addr() This caused crashes in _tsocket_address_bsd_from_sockaddr() when we read past the end of the allocation. Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-03-05s4-libregistry: Improve NULL handling of name.Andreas Schneider1-3/+4
Reviewed-by: David Disseldorp <ddiss@samba.org>
2013-03-05s4-libregistry: Fix path check and improve while loops.Andreas Schneider1-6/+6
Reviewed-by: David Disseldorp <ddiss@samba.org>
2013-03-05s4-libregistry: Make sure we don't dereference a NULL pointer.Andreas Schneider1-1/+3
Reviewed-by: David Disseldorp <ddiss@samba.org>
2013-03-04s4-lib/socket: Return the original EMSGSIZE when sendto() and setsockopt() ↵Andrew Bartlett1-1/+1
both fail This ensures that should we be unable to increase the socket size, we return an error that the application layer above might expect and be able to make as reasonable response to (such as switching to a stream-based transport). This fixes up c692bb02b039ae8fef6ba968fd13b36ad7d62a72. As suggested by metze in https://bugzilla.samba.org/show_bug.cgi?id=9697#c4 Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-03-02Handle EMSGSIZE on UNIX domain sockets.Landon Fuller1-9/+26
On some systems (eg, FreeBSD) the default SO_SNDBUF for UNIX domain sockets is to small, and EMSGSIZE is returned. Other systems provide a larger default send buffer, but there is still no guarantee that the buffer will be sized appropriately. This patch modifies the sendto() path to attempt to resize the SO_SNDBUF dynamically upon an EMSGSIZE failure, and then retry the send. This fixes local DCE/RPC errors on FreeBSD, eg: https://lists.samba.org/archive/samba-technical/2013-January/089881.html Signed-Off-By: Landon Fuller <landonf@bikemonkey.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sat Mar 2 23:34:03 CET 2013 on sn-devel-104
2013-03-02Move python modules from source4/scripting/python/ to python/.Jelmer Vernooij1-1/+1
Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sat Mar 2 03:57:34 CET 2013 on sn-devel-104
2013-02-28s4:lib/events: make use of samba_tevent_set_debug()Stefan Metzmacher1-35/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-02-28s4:pyregistry: make use of samba_tevent_context_init()Stefan Metzmacher1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-02-22s4-lib: Don't leak plugin handle on error.Andreas Schneider1-0/+1
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22s4-policy: Fix memory leaks in push_recursive().Andreas Schneider1-14/+26
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22s4-registry: Don't leak file descriptor.Andreas Schneider1-2/+1
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22s4-registry: Don't leak memory on error.Andreas Schneider1-0/+7
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-19s4:lib/com: make use of samba_tevent_context_init()Stefan Metzmacher1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-02-14waf: Make sure we link against samba-util.Andreas Schneider1-0/+1
libcmdline-credentials.so needs samba_getpass() from libsamba-util.so, so we need to link against it. Reviewed-by: Andrew Bartlet <abartlet@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Feb 14 16:56:29 CET 2013 on sn-devel-104
2013-01-26pymessaging: Pass around the server_id struct to python callbacks rather ↵Andrew Bartlett1-3/+13
than the tuple This is not used currently, but may avoid going to and from the python types when we do not need to. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-01-26pymessaging: Use correct unsigned types for server ID tuple elememntsAndrew Bartlett1-3/+3
This is needed if we start using the top bits of these values. Andrew Bartlett Reviewed-by: Matthieu Patou <mat@matws.net> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-01-09Use the new directory_create_or_exist_strict() function.Andreas Schneider1-1/+1
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-01-09s4:lib/messaging: terminate the irpc_servers_byname() result with ↵Stefan Metzmacher2-4/+4
server_id_set_disconnected() (bug #9540) Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2012-12-21s4-regsitry: Check return value of ldb_msg_add_empty().Andreas Schneider1-1/+7
Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-21s4-lib: Use directory_create_or_exist() to create messaging dir.Andreas Schneider1-1/+6
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-12s4-socket: Make sure unix socket addresses are null terminated.Andreas Schneider1-5/+5
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-03cmdline: Use new samba_getpass() function.Andreas Schneider1-5/+9
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
2012-11-29docs: man regtree: Add missing meta data.Karolin Seeger1-0/+3
This avoids warnings during the waf build and removes "FIXME" entries from the manpage. Karolin Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-29docs: man regshell: Add missing meta data.Karolin Seeger1-0/+3
This avoids warnings during the waf build and removes "FIXME" entries from the manpage. Karolin Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-29docs: man regpatch: Add missing meta data.Karolin Seeger1-0/+3
This avoids warnings during the waf build and removes "FIXME" entries from the manpage. Karolin Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-29docs: man regdiff: Add missing meta data.Karolin Seeger1-0/+3
This avoids warnings during the waf build and removes "FIXME" entries from the manpage. Karolin Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-15popt_common: Fix typos.Karolin Seeger1-2/+2
Karolin Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed by: Jelmer Vernooij <jelmer@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Nov 15 01:31:50 CET 2012 on sn-devel-104
2012-10-31pymessaging: Add irpc_servers_byname() and irpc_all_servers()Andrew Bartlett1-0/+99
This will allow python scripts to inspect the process list. Andrew Bartlett
2012-10-31pymessaging: Use the server_id IDL structure rather than a tupleAndrew Bartlett1-5/+20
This will make it easier to pass this structure in and out. The tuple is still accepted as input. Andrew Bartlett
2012-10-31imessaging: Add irpc_all_servers() to list all available serversAndrew Bartlett2-0/+73
This is implemented with a tdb_traverse_read(), and will allow a tool to disover the name and server_id of all Samba processes, as each process registers itself to recieve messages. Andrew Bartlett
2012-08-09s4-events: Do not vasprintf() the tevent debug messages that will not be shownAndrew Bartlett1-4/+6
This malloc() and free() actually shows up quite high on a call profile of provision of the AD DC. Andrew Bartlett
2012-08-06s4:libcli/pyerrors: s/PyErr_WERROR_IS_ERR_RAISE/PyErr_WERROR_NOT_OK_RAISE/Stefan Metzmacher1-12/+12
metze
2012-07-27lib/param: Remove use of lp{cfg,}_socket_address outside the NBT client and ↵Andrew Bartlett1-10/+0
server In these other cases, control of the sockets to bind to can be obtained using "bind interfaces only = yes" and "interfaces = ". Andrew Bartlett
2012-07-18s4-lib/tls: Try socket_send() multiple times to send partial packetsAndrew Bartlett1-13/+26
This works around an artificial limitation in socket_wrapper that breaks some versions of GnuTLS when we return a short write. Instead, keep pushing until the OS will not take it. The correct solution will be to use tls_tstream, but the client code for this is not yet tested and needs the ldap client layer changed to use it. Andrew Bartlett Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Jul 18 11:23:55 CEST 2012 on sn-devel-104
2012-07-13s4:registry:regdiff: use existing talloc context for the event contextMichael Adam1-1/+1
Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Fri Jul 13 02:51:44 CEST 2012 on sn-devel-104
2012-07-13s4:registry:regdiff: add TALLOC_CTX * argument to open_backend()Michael Adam1-6/+7
2012-07-13s4:registry: add a TALLOC_CTX argument to reg_open_remote()Michael Adam4-5/+7
2012-06-12s4:registry:testsuite: fix use of non-existent word (existant)Michael Adam1-3/+3
2012-06-07build: Add missing deps and make MESSAGING a private libraryAndrew Bartlett1-2/+3
To remove finddcs_nbt these missing deps need to be added. These subsystems linked to to implicit dependencies provided by finddcs. Due to the new arrangmenet of subsystems, MESSAGING needs to be a private library to avoid being a source of duplicate symbols. Andrew Bartlett
2012-05-14s4:lib/events: no longer define TEVENT_COMPAT_DEFINESStefan Metzmacher1-3/+0
metze
2012-05-14s4:lib/events: remove unused event_context_find() prototypeStefan Metzmacher1-1/+0
metze
2012-05-11s4:lib: remove unused wscript_build fileMichael Adam1-7/+0
This only contains a "GENCACHE" subsystem that is not referenced anywhere.
2012-05-03UTIL_TDB: lowercase name.Jelmer Vernooij1-1/+1
Autobuild-User: Jelmer Vernooij <jelmer@samba.org> Autobuild-Date: Thu May 3 20:18:22 CEST 2012 on sn-devel-104
2012-04-30s4-messaging: Fill in the whole server_id in all use casesAndrew Bartlett1-1/+6
This started per https://bugzilla.samba.org/show_bug.cgi?id=8872#c4 and avoids any possible collision with a different process. We also need to ensure that across a Samba installation on a single node that id.vnn is the same. Samba4 previously used 0, while Samba3 used NONCLUSTER_VNN. When a message is sent between these 'different' nodes, the error NT_STATUS_INVALID_DEVICE_REQUEST is raised. Andrew Bartlett
2012-04-25s4-messaging: Use generate_random() to get a unique ID for messaging clientsAndrew Bartlett1-1/+2
The call to random() resulted in duplicate values for s3fs configurations which, due to the forked child, all started with the same random seed. A future improvement would be to move to a proven unique value. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Wed Apr 25 11:43:40 CEST 2012 on sn-devel-104
generated by cgit (git 2.34.1) at 2024-11-03 23:58:48 +0000