summaryrefslogtreecommitdiff
path: root/source4/lib
AgeCommit message (Collapse)AuthorFilesLines
2010-03-09Fix typo and convert spaces to tabsSimo Sorce1-4/+4
2010-03-09s4:ldb fix escape parsingSimo Sorce1-2/+24
sscanf can return also on short reads, in this case an invalid escape sequence like '\1k' would be accepted, returning 1 as value and swallowing the 'k'. Use an auxiliar function to validate and convert hex escapes.
2010-03-09Fixed a bug in acl tests - python error when we create user/group/ou with a ↵Nadezhda Ivanova1-23/+23
descriptor.
2010-03-09Added a check for permissions to modify the RDN attribute on rename.Nadezhda Ivanova1-0/+32
Necessary because rdn module will be moved lower than acl in the stack.
2010-03-08LDB:asq module - change counters to "unsigned" where appropriateMatthias Dieter Wallnöfer1-4/+5
2010-03-08LDB:sort module - change counters to "unsigned" where appropriateMatthias Dieter Wallnöfer1-4/+5
2010-03-08LDB:rdn name module - change counters to "unsigned" where appropriateMatthias Dieter Wallnöfer1-2/+3
2010-03-08LDB:paged searches module - change counters to "unsigned" where appropriateMatthias Dieter Wallnöfer1-2/+2
2010-03-08LDB:paged results module - change counters to "unsigned" where appropriateMatthias Dieter Wallnöfer1-4/+4
2010-03-08LDB:common - Change counters to "unsigned" where appropriateMatthias Dieter Wallnöfer11-67/+76
To count LDB objects use variables of type "unsigned (int)" or "long long int" on binary or downto searches. To count characters in strings use "size_t". To calculate differences between pointers use "ptrdiff_t".
2010-03-08s4:LDB TDB index code - reintroduce accidentally removed code partMatthias Dieter Wallnöfer1-1/+3
This was removed by 95d726f3018ef5d249f89d56bde24b7ee0c24ecf. Sorry.
2010-03-08s4:ldb_ldap.c - fix indentationMatthias Dieter Wallnöfer1-1/+1
2010-03-08LDB:TDB backend - change counter variables to "unsigned" where appropriateMatthias Dieter Wallnöfer5-16/+19
2010-03-08LDB:SQLITE3 backend - change counter variables to "unsigned" where appropriateMatthias Dieter Wallnöfer1-8/+10
2010-03-08LDB:LDAP backend - change a counter variable to "unsigned"Matthias Dieter Wallnöfer1-1/+1
2010-03-08LDB:map - make LDB "signed-safe" on counter variables where appropriateMatthias Dieter Wallnöfer3-21/+28
2010-03-08s4:ldif_handlers - Change "unsigned int" to "uint32_t" which fits better hereMatthias Dieter Wallnöfer1-1/+1
2010-03-06s4:lib/registry/ldb.c - fix trailing whitespacesMatthias Dieter Wallnöfer1-6/+6
2010-03-06s4:registry library - fix up "reg_ldb_set_value"Matthias Dieter Wallnöfer1-9/+23
The previous logic was wrong since it tried to add empty data in some cases which always ended in an error. This problem should be fixed with the new logic.
2010-03-06s4:registry library - make "reg_ldb_pack/unpack_value" more robustMatthias Dieter Wallnöfer1-28/+35
This to prevent segmentation faults, wrong server inputs ecc.
2010-03-06s4:libregistry - change counters to be "unsigned"Matthias Dieter Wallnöfer10-40/+41
Also the s4 registry library has to have "unsigned" counters like the Windows one.
2010-03-06LDB:tools - change counters to be unsignedMatthias Dieter Wallnöfer6-32/+38
In most cases we do count LDB objects which are enumerated within the "unsigned" type. Therefore no need to use "signed" counters.
2010-03-05s4-messaging: use auto-close on the socketAndrew Tridgell1-0/+1
2010-03-04s4:ldap.py - give the "primaryGroupToken" test a better nameMatthias Dieter Wallnöfer1-3/+3
It tests also some other constructed attributes in a basic way.
2010-03-04s4:ldap.py - add test for "tokenGroups"Matthias Dieter Wallnöfer1-0/+44
2010-03-04Refactored ACL python testsNadezhda Ivanova1-441/+256
Made each type into a separate class to be easily run individually, removed code duplication
2010-03-04s4:ldif_handlers - Use "unsigned int" for counting purposesMatthias Dieter Wallnöfer1-4/+4
I changed "uint32_t" to "unsigned int" since the LDB specification prescrives "unsigned (int)" for counter variables (number of attributes, number of values...).
2010-03-03s4/ildap: fine tune ildb_callback()Kamen Mazdrashki1-3/+3
Actually ildb_context pointer is not supposed to be valid after calling ildb_request_done(). This is due to the fact that when calling ildb_request_done() caller will (most probably) free any locally built ldap_request objects - thus rendering ildb_context invalid. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-03-02LDB:NSS - make LDB "signed-safe" on counter variablesMatthias Dieter Wallnöfer1-2/+2
"i" needs to be unsigned on both places since it counts till a "count" variable of a "struct ldb_result" object which itself is unsigned. I see counting variables much better as "unsigned" since in most cases we don't use negative values at all. We've only to be careful on binary searches and downto counts regarding them.
2010-03-01s4:LDB - cosmetic fix for a "for" loopMatthias Dieter Wallnöfer1-1/+1
2010-02-26s4:ldb_dn: fix an uninitialized variable (found by make valgrindtest)Stefan Metzmacher1-1/+1
metze
2010-02-26s4:ldb_dn: remove dn->ext_linearized when ext_components is modified.Stefan Metzmacher1-3/+4
metze
2010-02-26s4:ldb_dn: reset dn->ext_comp_num in ldb_dn_explode()Stefan Metzmacher1-2/+2
metze
2010-02-25s4:ldb Fix segfault in ldbsearch store_referral callbackAndrew Bartlett1-6/+1
sctx->refs_store was not initialised, and that made talloc_realloc grumpy once we started actually returning referrals regularly from Samba4's partitions module (0be57c747825737fa9d64411223e693b055b5f8f by mdw). We now just use talloc_zero() and forget about this manual initialisation work. Tracking down use of uninitialised variables with valgrind was the grand idea when this started, but in practice we just get segfaults in unusual places. Andrew Bartlett
2010-02-22ldb:web Fix typoSimo Sorce1-1/+1
2010-02-22s4:registry/regf.c - specify the context when freeing the "regf" variableMatthias Dieter Wallnöfer1-1/+1
Otherwise we get a "talloc_free with references" warning.
2010-02-22Spelling fixes for source4/lib/registry.Brad Hards4-8/+8
Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
2010-02-22Typo fix.Brad Hards1-1/+1
Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
2010-02-22LDB related spelling fixes.Brad Hards11-11/+11
Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
2010-02-17s4/ldap: Refactor the fix for ldap nested searchesKamen Mazdrashki1-9/+15
Current implementation synchronizes processing for all types of LDAP request, not only LDAP_Search ones. Synchronization for ldap replies processing is done locally in ldb_ildap module as this concerns only ildb_callback() function. Signed-off-by: Anatoliy Atanasov <anatoliy.atanasov@postpath.com>
2010-02-15s4-ldb: fixed permissions on urgent_replication.pyAndrew Tridgell1-0/+0
2010-02-15s4-test: minor fixes to urgent_replication.pyAndrew Tridgell1-27/+4
- fix usage name - remove unnecessary python functions - remote unused gc ldb
2010-02-15s4-drs: Test situations for Urgent ReplicationFernando J V da Silva1-0/+414
Checks if the partition's uSNUrgent is updated or not, depending on the class of the object which is created, modified or deleted. Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-02-14s4-ldb: use TYPESAFE_QSORT() in the rest of the ldb codeAndrew Tridgell5-11/+20
2010-02-13s4:popt_common.c - fix intendationMatthias Dieter Wallnöfer1-1/+1
2010-02-13s4: use LDB_TYPESAFE_QSORT() instead of ldb_qsort()Andrew Tridgell2-5/+2
2010-02-13s4-ldb: added LDB_TYPESAFE_QSORT()Andrew Tridgell1-0/+18
Like TYPESAFE_QSORT() but for the ldb_qsort() function
2010-02-13s4-socket: use TYPESAFE_QSORT() in netif codeAndrew Tridgell1-1/+2
2010-02-11ldb_match - Ignore ":dn" part of extended matches for nowMatthias Dieter Wallnöfer1-2/+5
It's not fully clear what this ":dn" part means for us. What we know is that older AD implementations (Windows Server 2000, 2003) need it to have extended matches working in the expected way. To be able to interoperate with s3's winbind and other tools I and gd decided to transform this into a warning until we know what to do. This should fix bug #6511.
2010-02-12s4-pyldb: null terminate string ldb message elements from pythonAndrew Tridgell1-4/+4
We need to eventually get rid of ldb_msg_find_attr_as_string() (or add a mem_ctx to it), but meanwhile we have too many places that break if we don't add a nul to the end of ldb msg strings from python.