Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
Patch from Andrew Kroeger wasn't fully correct - we need a "talloc_free" after
the "if (ac->r_current == NULL)" statement.
|
|
|
|
As found when running "make test" with the MALLOC_CHECK_ and MALLOC_PERTURB_
environment variables set.
|
|
|
|
These are updated second eddition unittests using ldb.add_ldif()
and ldb.modify_ldif(). Unittests are found to work when using
the right local domain SID. Negative test separated.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
|
|
print replUpToDateVector and replPropertyMetaData using NDR format if
--show-binary is given.
|
|
|
|
print security descriptors in NDR format if --show-binary is
given. This is easier to read than sddl format.
|
|
In normal usage this makes no difference, but if you add --show-binary
then you can see the NDR printed out in the usual ndr_print_*() format
|
|
|
|
|
|
This add --show-binary to ldbsearch. When this flag is set, binary
blobs will be shown as-is, instead of base64 encoded. This is useful
for some XML encoded attributes, and will also be used as part of some
NDR print formatting for attributes like repsTo.
|
|
Outputs shouldn't clash with metadata characters (|,()), special characters
should be escaped, "NULL" values should be reported as "(null)" string.
For the full explaination look at bug #6076.
|
|
|
|
This passes the Windows Server behaviour. Also SAMBA 4 should match it.
Also some small enhancement.
|
|
|
|
|
|
When a top level method in a module returns an error, it is supposed
to call ldb_module_done(). We ran across a case where this wasn't
done, and then found that in fact that are hundreds of similar cases
in our modules. It took Andrew and I a full day to work out that this
was the cause of a subtle segv in another part of the code.
To try to prevent this happening again, this patch changes
ldb_next_request() to catch the error by checking if a module
returning an error has called ldb_module_done(). If it hasn't then the
call is made on behalf of the module.
|
|
When we fail a ldbadd or ldbedit we should cancel the transaction to
prevent ldb giving a warning about having a open transaction in the
ldb destructor
|
|
The reason we need this is to make multi-tdb transactions safe, with
the partition module. The linked_attributes and repl_meta_data modules
now do extra processing when the transaction ends, and that processing
can fail. When it fails we need to cancel the transaction, which we
can only do if the hook is on the prepare commit instead of the end
transaction call. Otherwise the partition module cannot ensure that no
commit has been done on another partition.
|
|
I always found it hard to remember some of the options. We might as
well use popt to give us the full list
|
|
|
|
This allows the ldb tools to show their full command line options
|
|
Two controls with the same OID makes no sense, as they may
have different data attached
|
|
This function provides a easy function for displaying a ldb_message
structure in a human readable format. It is especially useful for
calling in gdb.
|
|
|
|
- remove trailing spaces and tabs
- shorten some variable names for readability
- try to break superlong lines for readability
|
|
|
|
Michael
|
|
This allows us to turn a python LdbMessage back into a string.
Andrew Bartlett
|
|
Also add tests to prove that we got this correct, and correct the
existing tests which used the wrong constants.
Andrew Bartlett
|
|
|
|
metze
|
|
|
|
This should ensure the debug messages do not have random characters at
their ends.
Andrew Bartlett
|
|
|
|
Should finally fix bug #6136 ("groupType", "sAMAccountType" ... attributes).
|
|
right way
|
|
|
|
The expression time.strftime("%s", time.gmtime())[3:] leads to a
string with a leading 0. When added then read back from the prefix map
this leads to a different string, so it is never found.
Use the simpler str(random.randint(a,b)) expression instead
|
|
|
|
|
|
|
|
Tests for the right behaviour of this introduced constructed attribute.
Since we don't support the read-only-ness of those attributes yet, I commented
some lines out.
Also I had to add a function for python which converts domain SIDs in RIDs.
And a small fix for the "groupType" test.
|
|
This moves the "operational" LDB module to the right place under "dsdb/samdb/ldb_modules"
(suggested by abartlet) and enhances it for supporting dynamic generated
"primaryGroupToken" for AD groups. This should fix bug #6466.
|
|
when a client disconnects we expect this to happen, so don't print an
error each time
|
|
These references were triggering the ambiguous talloc_free errors from
the recent talloc changes when the server is run using the 'standard'
process model instead of the 'single' process model. I am aiming to
move the build farm to use the 'standard' process model soon, as part
of an effort to make our test environment better match the real
deployment of Samba4.
The references are not needed as the way that the event context is
used is as the 'top parent', so when the event context is freed then
all of the structures that were taking a reference to the event
context were actually freed as well, thus making the references
redundent.
|
|
This fixes a bug in the samba3sam test with the python libraries as
noticed by abartlet
|
|
|