summaryrefslogtreecommitdiff
path: root/source4/lib
AgeCommit message (Collapse)AuthorFilesLines
2010-03-29s4:registry/util.c - remove those "talloc_free"sMatthias Dieter Wallnöfer1-3/+0
They're not really necessary.
2010-03-29s4:registry/tests/generic.c - fix the DWORD_* types test to work also ↵Matthias Dieter Wallnöfer1-6/+6
against big endian platforms
2010-03-29s4:registry/ldb.c - Break with "NULL" as an error case when the data doesn't ↵Matthias Dieter Wallnöfer1-2/+5
fit in the "reg_ldb_pack_value" function
2010-03-29s4:registry/ldb.c - Always check the "name" attribute for != NULLMatthias Dieter Wallnöfer1-2/+22
If it's NULL return invalid parameter as Windows does. The name is "" if it refers to the default value.
2010-03-29s4:registry - move the UTF16 length calculation for "reg_key_get_info" into ↵Matthias Dieter Wallnöfer1-8/+0
the RPC server code It does fit better there.
2010-03-29s4:registry/util.c - fix indentationMatthias Dieter Wallnöfer1-2/+2
2010-03-29registry: Fix compilation.Jelmer Vernooij3-9/+5
2010-03-29Revert reordering from commit 51bedf939568717424edd7732e1e315faa333849Wilco Baan Hofman1-3/+3
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-03-29Revert "s4:registry - util.c - add harder checks for inputs on ↵Wilco Baan Hofman1-15/+11
"reg_val_data_string"" This reverts commit eb8c8a0ecaa9bfd29f090db21fccdad7751767ae. Conflicts: source4/lib/registry/util.c Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-03-29Revert "s4:registry - util.c - move the "REG_NONE" case in the conversion ↵Wilco Baan Hofman1-6/+6
functions on top of the switch" This reverts commit 4e6c0e1f6f37a7e04d10dbf7abbf626f52232aaf. Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-03-29Revert "s4:registry - util.c - treat unsupported and binary values as the ↵Wilco Baan Hofman1-6/+18
same in the conversion functions" This reverts commit cc3eec1681bb6d614e688f51e48bd76f6d513e67. Conflicts: source4/lib/registry/util.c Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-03-29Revert "s4:registry - adaptions for "add memory contexts for delete ↵Wilco Baan Hofman1-2/+5
value/key functions"" This reverts commit 43170dafbcbe7464bce9b4c6d76532d7d0bf5b9a. Conflicts: source4/lib/registry/dir.c source4/lib/registry/util.c Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-03-29Revert "s4:registry - "util" - make "reg_key_add_abs" consistent with ↵Wilco Baan Hofman1-6/+9
"reg_key_del_abs"" This reverts commit 9d8592978e28c492d971a3b5a4c0133febc149ea. Conflicts: source4/lib/registry/util.c Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-03-29Revert of commit 5b6ad54f43741c0c25b35e44cafe5fed352ff133 in registry.hWilco Baan Hofman1-2/+1
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-03-29Remove incorrect const, something that was correct in commit ↵Wilco Baan Hofman1-2/+2
9c3e6249fd984b823a77cab0514601d2a487920a Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-03-29Revert "s4:registry - "util" - remove "const" from "reg_abs_path""Wilco Baan Hofman1-3/+3
This reverts commit 9c3e6249fd984b823a77cab0514601d2a487920a. Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-03-29ldap.py: Fix syntax error.Jelmer Vernooij1-1/+1
2010-03-29s4-python: Format to PEP8, simplify tests.Jelmer Vernooij2-21/+22
2010-03-29pytalloc: allow for using a system libtalloc-dev with pytallocAndrew Tridgell1-1/+1
When we have a system talloc library, we still need to grab pytalloc.h from lib/talloc. We don't want to just use -Ilib/talloc, as otherwise we'll get the in-tree talloc.h which may not be compatible with the system talloc.h So we need to give the path to pytalloc.h
2010-03-26libutil: moved the networking defines to util_net.hAndrew Tridgell3-0/+3
These were causing thousands of warnings on solaris8
2010-03-25s4-ldb: removed unused command line options -I and -OAndrew Tridgell2-4/+0
These are not used anywehere, so they just confuse people Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-03-25python: use '#!/usr/bin/env python' to cope with varying install locationsAndrew Tridgell9-9/+9
this should be much more portable
2010-03-24s4:cmdline Add --sign and --encrypt options to our common command lineAndrew Bartlett1-1/+28
This allows ldbsearch to accept --sign and --encrypt. I'll soon work to integrate with the --signing= option in smbclient. Andrew Bartlett
2010-03-23s4:lib/messaging: pymessaging needs libndr.hStefan Metzmacher1-0/+1
metze
2010-03-23s4:registry - "reg_ldb_pack_value" - provide workarounds when the server ↵Matthias Dieter Wallnöfer1-0/+9
receives non-standard data. For now we reset/delete the "data" attribute. Anyway there is the need to find a better solution (we probably want to change the format and save all data as we got it like Windows itself does). These workarounds are needed since for example the Windows 2000 Registry Editor initialises empty REG_SZ strings with content '\0' and length 1 (not a valid UTF16 sequence - "convert_string_talloc" breaks). So we simply reset/delete the "data" attribute which works (no content).
2010-03-23s4:registry - "LDB backend" - fix indentationMatthias Dieter Wallnöfer1-1/+2
2010-03-23s4:registry - "LDB backend" - revert the length check for UTF16 stringsMatthias Dieter Wallnöfer1-10/+5
Let this do the "convert_string_talloc" function as it was before.
2010-03-23s4:registry - "LDB backend" - revert the binary storage of "REG_SZ", ↵Matthias Dieter Wallnöfer1-110/+19
"REG_DWORD" and "REG_QWORD" We agreed that this hack isn't the best of the possible solutions.
2010-03-22s4:registry - "reg_key_del/add_abs": call "talloc_free" only on valid objectsMatthias Dieter Wallnöfer1-6/+6
2010-03-22s4:registry - "reg_import_hive_key" - change a "talloc_steal" into a ↵Matthias Dieter Wallnöfer1-1/+1
"talloc_reference" Use a "talloc_reference" since the "hive" variable can continue to exist also after the destructed "struct local_key" object. It is also referenced by the "mountpoints" structure under the "ctx" object.
2010-03-22s4:registry - "patchfile" - add another "W_ERROR_HAVE_NO_MEMORY" macro callMatthias Dieter Wallnöfer1-0/+1
2010-03-22s4:registry - "local" - add also here more "W_ERROR_HAVE_NO_MEMORY" macro testsMatthias Dieter Wallnöfer1-8/+26
2010-03-22s4:registry - "util.c" - initialise "result" in "reg_key_add_abs"Matthias Dieter Wallnöfer1-0/+2
2010-03-22s4:registry - "samba.c" - add a "talloc_free"Matthias Dieter Wallnöfer1-0/+2
2010-03-22s4:registry - add more "W_ERROR_HAVE_NO_MEMORY" invocations (on talloc'ed stuff)Matthias Dieter Wallnöfer4-1/+13
2010-03-22s4:registry - "util" - remove "const" from "reg_abs_path"Matthias Dieter Wallnöfer1-3/+3
Here it's not really needed
2010-03-22s4:registry - adaptions for "add also a memory context argument for ↵Matthias Dieter Wallnöfer2-2/+2
"reg_key_del_abs"
2010-03-22s4:registry - "util" - add also a memory context argument for "reg_key_del_abs"Matthias Dieter Wallnöfer2-5/+4
2010-03-22s4:registry - "util" - make "reg_key_add_abs" consistent with "reg_key_del_abs"Matthias Dieter Wallnöfer1-6/+3
2010-03-22s4:registry - "util" - fix up memory allocated dataMatthias Dieter Wallnöfer1-1/+10
2010-03-22s4:registry - "dir.c" - fix up dynamic memory allocation operationsMatthias Dieter Wallnöfer1-15/+50
- Added free operations where needed - Use always the "mem_ctx" for temporary data - Proof with W_ERROR_HAVE_NO_MEMORY if stuff was allocated
2010-03-22s4:registry - adaptions for "add memory contexts for delete value/key functions"Matthias Dieter Wallnöfer13-62/+57
2010-03-22s4:registry - registry.h - add memory contexts for delete value/key functionsMatthias Dieter Wallnöfer1-8/+16
2010-03-22s4:registry - "RPC backend" - use "talloc_steal" and not "talloc_reference"Matthias Dieter Wallnöfer1-4/+4
No need to create additional references but we need to assign the strings to the right context.
2010-03-22s4:registry - "patchfile" - check if strings could be allocatedMatthias Dieter Wallnöfer1-0/+10
2010-03-22s4:registry - "patchfile" - initialise the data blobsMatthias Dieter Wallnöfer1-2/+2
2010-03-22s4:registry - "patchfile" - add more "talloc_free"s to save memoryMatthias Dieter Wallnöfer1-5/+30
2010-03-22s4:registry - "util.c" - "reg_string_to_val" - consider always the return valuesMatthias Dieter Wallnöfer1-7/+9
In some cases we didn't consider them.
2010-03-22s4:registry - "patchfile_preg.c" - also here don't accumulate the memory usageMatthias Dieter Wallnöfer1-4/+26
Free always the unused stuff.
2010-03-22s4:registry - "patchfile_dotreg.c" - fix a memory leakMatthias Dieter Wallnöfer1-3/+5
Here we allocate memory on the "NULL" context through "reg_val_data_string" on each call of "set_value". So when we have written out the allocated data on the specified file descriptor we should immediately free this memory! Otherwise we may end up with a big memory consumption on big registry databases.