| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
rafal
(This used to be commit 0e45dc3bac0e699b2da5b7f8df9d4bf7bd80a0f5)
|
|
stuff.
- don't use SMBCLI_REQUEST_* state's in the genreic composite stuff
- move monitor_fn to libnet.
NOTE: I have maybe found some bugs, in code that is dirrectly in DONE or ERROR
state in the _send() function. I haven't fixed this bugs in this
commit! We may need some composite_trigger_*() functions or so.
And maybe some other generic helper functions...
metze
(This used to be commit 4527815a0a9b96e460f301cb1f0c0b3964c166fc)
|
|
rafal
(This used to be commit 5be8479d5cf119bcda4046bf1c5d7c3b876e718d)
|
|
specific routines like resolving a pdc).
Also, couple of formatting fixes.
rafal
(This used to be commit b9deaa995da3a732514d5ceab0010adb58be5fe0)
|
|
rafal
(This used to be commit cd89cf991923ee1184af41be4d48b372ca963062)
|
|
This makes more clear where the functions belong to. Also
the rule will be that lowercased function names are not
part of "official" libnet API (though it doesn't mean one
absolutely cannot use them).
rafal
(This used to be commit f6ef7b882acc6ee07422944a417a8d9013c9d8d2)
|
|
rafal
(This used to be commit a784c46dd40ee2ea00fb67caeb358e76cdc0712f)
|
|
any possibility to pass such pointer from calling function... :)
rafal
(This used to be commit 08a8878436f3ba21666f43e9abafb27055a02e8a)
|
|
composite call.
rafal
(This used to be commit 227c9fb45bdba5ac795ee14f7e51ccaa18a2a0e1)
|
|
rafal
(This used to be commit ebf151ca6e740fb7939161de14a0adfc47f80010)
|
|
- talloc should always be done in the right context. For example, when creating
the userinfo_state structure, place it inside the composite
structure, not directly on the pipe. If this isn't done then
correct cleanup can't happen on errors (as cleanup destroys the top
level composite context only)
- define private structures like userinfo_state in the userinfo.c
code, not in the public header
- only keep the parameters we need in the state structure. For
example, the domain_handle is only needed in the first call, so we
don't need to keep it around in the state structure, but the level is
needed in later calls, so we need to keep it
- always initialise [out,ref] parameters in RPC calls. The [ref] part
means that the call assumes the pointer it has been given is
valid. If you don't initialise it then you will get a segv on
recv. This is why the code was dying.
- don't use internal strucrure elements like the pipe
pipe->conn->pending outside of the internal rpc implementation. That
is an internal list, trying to use it from external code will cause crashes.
- rpc calls assume that rpc call strucrures remain valid for the
duration of the call. This means you need to keep the structures
(such as "struct samr_Close") in the userinfo_state strucrure,
otherwise it will go out of scope during the async processing
- need to remember to change c->state to SMBCLI_REQUEST_DONE when the
request has finished in the close handler, otherwise it will loop
forever trying to close
Mimir, please look at the diff carefully for more detailed info on the fixes
(This used to be commit 01ea1e7762e214e87e74d6f28d6efeb6cdea9736)
|
|
rafal
(This used to be commit 01cbed98b32c2050a665aec51a99288e4afb29c1)
|
|
used to be)
Add oxid mapping table support in DCOM
(This used to be commit e193555f0eec2dda8c8760e9668181200fef0a1e)
|
|
rafal
(This used to be commit ec177c92266713e9a486e536c2d81af4eaa2425e)
|
|
rafal
(This used to be commit e5daf6911b49cd4aa0bff050fe8c559d6604859e)
|
|
rafal
(This used to be commit bfb4dfaa8c039378b4c29f130cbcdc89eac951b9)
|
|
It does only compile. Completely untested yet, so almost certainly
broken, but I don't want it to lay on my laptop only.
rafal
(This used to be commit dcab843da35f5dd2ffc694922ee762b3c36dbd35)
|
