Age | Commit message (Collapse) | Author | Files | Lines |
|
In this error path we were leaking "fd".
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
|
|
This disables the posix permission override if the calculated
permissions did not come from a NT ACL.
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Dec 1 05:14:49 CET 2011 on sn-devel-104
|
|
metze
|
|
Several places want "microseconds from current time", and several were
simply handing "usecs" values which could be over a million.
Using a helper to do this is safer and more readable.
I didn't replace any obviously correct callers (ie. constants).
I also renamed wait_nsec in source3/lib/util_sock.c; it's actually
microseconds not nanoseconds (introduced with this code in Volker's
19b783cc Async wrapper for open_socket_out_send/recv).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
|
|
|
|
Signed-off-by: Pavel Shilovsky <piastry@etersoft.ru>
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Feb 15 11:09:17 CET 2011 on sn-devel-104
|
|
|
|
This allows for root override, which fixes many problems with
mismatches between NT ACL permissions and unix permissions.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
This should make is easier to track down some bug reports
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
Re-using two of the create_options bits was bound to eventually
cause problems, and indeed, Windows7 now uses one of those bits
when opening text files.
Fixes bug 7189
|
|
pvfs can be NULL if the directory a share points to does not exist. In
this case, there would be no open files, so it is safe to just return
from the function.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
|
|
matching windows behaviour is not always the right thing to do!
|
|
This caused havoc on the build farm. Interestingly, it only affected
gcc 4.3.3, not gcc 4.4.1
|
|
Previously when a file was created, we produces the resulting access
mask based on an ACL check against the parent. This change means we
now calculate the inherited ACL much earlier, and produce the
resulting access mask from that ACL, or the user supplied ACL.
|
|
Construct the filename from the old handle and the new name.
|
|
This bug was caused by two things:
1) in the unix ACL mapping, we were not taking into account group
write permssions for the SEC_STD_DELETE flag
2) when a file is created using OVERWRITE mode, a fchmod() would
fail if the user is not the file owner. We resolve that by only
doing the fchmod() if the mapped file attribute does not match the
desired file attribute
|
|
metze
|
|
metze
|
|
|
|
|
|
metze
(This used to be commit 3c6cadf76861d6522c5ec41953df1ba2fac4910d)
|
|
(This used to be commit 4f6646f06988b1fb8be9e0c8ae833bb9792184af)
|
|
Also in particular the 'sync' flags (which Samba has traditionally
ignored).
Thanks to Olivier Salamin <olivier.salamin@gmail.com> for pointing out
more flags that needed to be handled.
Andrew Bartlett
(This used to be commit 370bb39cd79fe49efd36a1ceb3e896d386e6d3ce)
|
|
The MS-SMB document explains that some of these options should be
ignored. The test proves it.
/* Must be ignored by the server, per MS-SMB 2.2.8 */
/* Must be ignored by the server, per MS-SMB 2.2.8 */
If we implement HSM in samba4 (likely) we should honour this bit.
/* Don't pull this file off tape in a HSM system */
Andrew Bartlett
(This used to be commit 502739ff90d56d2c9aabe8e224317f6ceb175c17)
|
|
Note: that libreplace always provides utimes()
metze
(This used to be commit 61bad69e2d7f84e2c6d6fb82917cfa86b17f54b0)
|
|
metze
(This used to be commit 7f033ce4fb6fc897f8159926d5a6d2e45dd447b6)
|
|
metze
(This used to be commit 58c118ab4d2b76c4ea68d79b711b81900634f767)
|
|
By default get the current write time from the opendb,
but allow callers to pass PVFS_RESOLVE_NO_OPENDB
for performance reasons, if they don't need to the write time.
metze
(This used to be commit def52cc0988c26a815e74b3391e5857512408d90)
|
|
metze
(This used to be commit 3868d8ce630c71e2c70aae442fcdbd68ba1eb708)
|
|
(This used to be commit 4eb49335d5f0319f9aa47ded5215a2977d3336bf)
|
|
(This used to be commit 884c32fcef48244bd260026a61790332bd706eb4)
|
|
Not all of them are honoured yet, but they are all parsed and the ones
that have SMB equivalents are honoured
(This used to be commit 9fc70e2ed6a54f6d9a0530f4d37c0f8acadb6778)
|
|
(This used to be commit 2633bc749792c224acc73a2e4ca723404331c19c)
|
|
(This used to be commit 2ac27bfffa557d6c0f71c443b43a8d1967edb177)
|
|
(This used to be commit 897f4582bee72e319874e8a2d064ba442415571d)
|
|
(This used to be commit 8c263f91bda97eb910c8589b6cd987ec4a62d770)
|
|
(This used to be commit 067f1271adaa13d537bbc92b19fe8d633cbaaf50)
|
|
(This used to be commit dcdaa9f5fd9150b16fb277213e864e5c39d831d6)
|
|
(This used to be commit a7b5689a73adde59de28770aa3949660441291ea)
|
|
metze
(This used to be commit 1421b1cc0c442be839be702647009ed5295f34a3)
|
|
(This used to be commit dd21e3d9d788a67d4673625ed4892a875f4600dc)
|
|
file or a directory
(This used to be commit c05b58940f06b01b9770c218eb0708cb621215ef)
|
|
I'll fix this more correctly very soon,
so that we'll pass the BASE-DELAYWRITE test.
metze
(This used to be commit b09dd6b65d533832a025a51509dcc84f84b048aa)
|
|
Otherwise we may not clean up in the destructor.
metze
(This used to be commit 218ec98a1694080748d1ac12baa90ffcda364833)
|
|
Otherwise they're not cleaned up when the request is finished.
metze
(This used to be commit 055760f0f4aadd2079b0a4999b59ac3dbe5edf8a)
|
|
In case a unix application as an oplock or share mode on
a file we need to retry periodicly as there's no way
to get a notification from the kernel when the oplock
is released.
metze
(This used to be commit 4d40f3a02643b4cdacee31f0b7bc9fc77cc9869a)
|
|
metze
(This used to be commit eeb0b8c349552517b521f1b8d7d9341e0ef630f2)
|
|
metze
(This used to be commit 80f5f9362100b971fa12ffee33705b745131770e)
|
|
metze
(This used to be commit 5fdca988c687f58fe2fddd3c8eff5f461207065b)
|
|
odb_open_file() will later change to not redo the logic of
odb_can_open().
metze
(This used to be commit b09a1461ac595be1b6530221b7df5211084884cc)
|