summaryrefslogtreecommitdiff
path: root/source4/rpc_server/winreg/rpc_winreg.c
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r18584: found one of the fd leaks. The registry backend was using aAndrew Tridgell1-1/+4
talloc(NULL, xxx) to allocate the registry context. That had two consequences 1) it was a massive memory leak, as all winreg operations leaked their entire context (including an open ldb database) every time 2) event_context_find() never found the exsting event context, so we used a new event context each time, which called epoll_create() each time, which caused a fd to be allocated (This used to be commit 1c0a3de39828b43149d8981fc7f10e7c8b59a392)
2007-10-10r18566: fixed the winreg pipe and winreg testsAndrew Tridgell1-0/+4
Jerry, there is a big difference on the wire between these two: [out] uint32 x; and [out] uint32 *x; if you change from [out] uint32 x; then you need to change to: [out,ref] uint32 *x; otherwise it changes the format on the wire, which means we are no longer compatible with MS servers. but be aware that even if you change to a ref ptr, you also need to change all the client code to set all the return variables in the out part of the structure. That's why I don't like the MIDL restriction of forcing the use of ref pointers for output variables - it makes life much harder when writing client code, and makes the code much more error prone (just look at all the extra code needed to make this work again). I know we could auto-allocate these variables in the generated client side NDR code, but if we did that then we would have no way of doing a _real_ ref out pointer, which we really wanted to set to some already allocated variable. So please hold off on changing our idl to use the MIDL convention for output variables until Jelmer and I have had a good "chat" about this :-) (This used to be commit 555aed43ba3c08360ca7fa921622b80732a7f657)
2007-10-10r18561: Fix [out] pointers in winreg IDLGerald Carter1-7/+7
(This used to be commit 694677dafefdd94fa0a9bed93efab70c528dcb26)
2007-10-10r18330: don't mix pointer types in RPC repliesAndrew Tridgell1-1/+5
(This used to be commit cc86719f53a47e3ca25b19d7a765314ce967ab01)
2007-10-10r15358: Fix some compiler warnings / type safety. Found by tccJelmer Vernooij1-2/+2
(This used to be commit 12ba42de5886f9f4f9b1698476557e0c217d06f3)
2007-10-10r14599: Pass ACLs down the registry layer.Jelmer Vernooij1-1/+1
(This used to be commit 6cdefd8945eee5513a6993350ea71f12d4dbd6fa)
2007-10-10r14464: Don't include ndr_BASENAME.h files unless strictly required, insteadJelmer Vernooij1-0/+1
try to include just the BASENAME.h files (containing only structs) (This used to be commit 3dd477ca5147f28a962b8437e2611a8222d706bd)
2007-10-10r11261: Rename access_required field in winreg idl to access_mask so it matchesTim Potter1-1/+1
the other interfaces. (This used to be commit 8eb582b5780188b6304c560b3e84fd7d75c483f8)
2007-10-10r10026: Move registry header file to lib/registryJelmer Vernooij1-1/+1
Add support for showing security descriptor in regshell Add support for saving files in NT4 registry backend (This used to be commit 47cecd4726e6568f1aafb404646d2664f630a9bb)
2007-10-10r10007: Merge data_blk and data_len member of registry_value into a DATA_BLOB.Jelmer Vernooij1-7/+10
Fix handling of REG_DWORD in the LDB backend. Fix a couple of warnings (This used to be commit 709fdc7ebf5a77cfb50359fad978884777decc3b)
2007-10-10r9567: fixed the winreg IDL for CreateKey, including a securityAndrew Tridgell1-4/+21
descriptor. To keep it simple I just use normal IDL buffers for now, avoiding the complex methods metze used in spoolss. We might change that later Also added decoding of the security_descriptor in winreg_GetKeySecurity() in smbtorture (This used to be commit 439f34a9621e2e96329c30cfed8d78b8fdfbd8a2)
2007-10-10r9410: - a winreg_CloseKey() should return a zero key on success (zeroing theAndrew Tridgell1-7/+4
callers key). This is the normal pattern with rpc handles. - fixed reference to undefined error variable in winreg_DeleteKey() (This used to be commit 6757d51a280d6c393648a384f1ef3ca403517352)
2007-10-10r9388: we should fault bad handles given to winreg_GetVersion()Andrew Tridgell1-1/+5
(This used to be commit 00e55be9efc6050e3bda13603270b028dbc19c3f)
2007-10-10r9359: don't check for size overflow if value is NULLAndrew Tridgell1-1/+2
this gets viewing the product options in smbd HKLM from w2k3 regedit working (This used to be commit 17f3250dd61bc9aad5cf3804e271383e219752f6)
2007-10-10r9358: - opening a winreg key of "" is the same as re-opening the hive. TheAndrew Tridgell1-11/+17
w2k3 regedit does this. - w2k3 expects null termination is string lengths (This used to be commit bcef9e592acd96a2fd7028b299d3d93968d044ae)
2007-10-10r9338: fixed the winreg IDL to be correct for the EnumKey and EnumValueAndrew Tridgell1-12/+38
calls. The previous IDL was just a workaround for the limitations of our older rpc infrastructure. Now that Jelmer has added much improved string support using the charset keyword we can correctly implemenent the unusual winreg string buffers. Jelmer, note the little comment I put on winreg_StringBuf() about why I couldn't use [value()] for the length field. This also fixes EnumKey() and EnumValue() to use NTTIME fields for the last_changed_time. I don't know why we were using a pair of uint32's, as it is just a NTTIME. (This used to be commit 8354b016122cc4f3cff042b3ada1de07e1614eb7)
2007-10-10r5298: - got rid of pstring.h from includes.h. This at least makes it a bitAndrew Tridgell1-1/+1
less likely that anyone will use pstring for new code - got rid of winbind_client.h from includes.h. This one triggered a huge change, as winbind_client.h was including system/filesys.h and defining the old uint32 and uint16 types, as well as its own pstring and fstring. (This used to be commit 9db6c79e902ec538108d6b7d3324039aabe1704f)
2007-10-10r5037: got rid of all of the TALLOC_DEPRECATED stuff. My apologies for theAndrew Tridgell1-6/+6
large commit. I thought this was worthwhile to get done for consistency. (This used to be commit ec32b22ed5ec224f6324f5e069d15e92e38e15c0)
2007-10-10r4640: first stage in the server side support for multiple context_ids on ↵Andrew Tridgell1-40/+28
one pipe this stage does the following: - simplifies the dcerpc_handle handling, and all the callers of it - split out the context_id depenent state into a linked list of established contexts - fixed some talloc handling in several rpc servers that i noticed while doing the above (This used to be commit fde042b3fc609c94e2c7eedcdd72ecdf489cf63b)
2007-10-10r4213: Store REG_SZ in UTF16, not the unix charset..Jelmer Vernooij1-2/+8
It is now possible to use the "Add..." button in the Security tab of the File Properties Dialog box. (This used to be commit 9fa25260d3f18dd0dd041477c48571b53d86f3c4)
2007-10-10r4209: Fix several smaller bugsJelmer Vernooij1-2/+18
Add "predef" and "set" commands in regshell Some of the remote calls from a Windows box work now. (This used to be commit f3e05782804fe4b4942fa966f1b9650c64bc234d)
2007-10-10r4204: Arguments to reg_del_key more like the RPC for more efficient usageJelmer Vernooij1-4/+1
Fix small bug in regpatch Fix segfault in regshell cmdline completion Implement set_value and del_value in ldb backend (This used to be commit 8e2aa58abeafa78afe7dafb9723f5f365e756527)
2007-10-10r4168: Implement QueryValue in the serverJelmer Vernooij1-1/+27
IDL for NotifyChangeKeyValue (This used to be commit a40214243136ed5208a1bec494ad1fbf821524ba)
2007-10-10r4166: More small API fixes, keep registry structs as small as possible.Jelmer Vernooij1-6/+4
Implement DelValue in the RPC server (This used to be commit f6b9ec89af934e837069fb26c0e3491fc78ebc12)
2007-10-10r4155: More destinction between hives and predefined keysJelmer Vernooij1-1/+1
(This used to be commit c37d6f3c581673d74e7ec6a644ab6a7d13a55535)
2007-10-10r4154: Add definitions for HKEY_PERFORMANCE_TEXT and HKEY_PERFORMANCE_NLSTEXTJelmer Vernooij1-2/+2
Hives and predefined keys (HKEY_*) are not necessarily the same thing. (This used to be commit 217e4e5841cfedb2b18dce3f89dd88ea4a36fe8f)
2007-10-10r4132: - Bunch of rather large fixes in the registryJelmer Vernooij1-32/+26
- Added some README files Not everything works yet, e.g. the EnumValue test appears to be broken. (This used to be commit c169e86c1f52763b83e77e509f89cb91f9b69071)
2007-10-10r4118: don't assume that "unsigned int" is the same type as uint32_tAndrew Tridgell1-1/+2
(This used to be commit 1ddab01d2ac0a51278cbd13d6d9369973c7a5b3a)
2007-10-10r4117: fixed EnumValue in winreg serverAndrew Tridgell1-7/+5
(This used to be commit f2f21033b65b82251b5ea0b2475ceb1bb3657fb3)
2007-10-10r4106: Add full name of two more hivesJelmer Vernooij1-2/+2
(This used to be commit c1023db5e8336e495c06acae1773a28d7fc90658)
2007-10-10r3468: split out dcerpc_server.hAndrew Tridgell1-0/+1
(This used to be commit 729e0026e4408f74f140375537d4fe48c1fc3242)
2007-10-10r3464: split out registry.h, rap.h and ldap_server.hAndrew Tridgell1-0/+1
(This used to be commit 70d2090f6bf2c7e0caf1e9c020f330de88871f8e)
2007-10-10r3428: switched to using minimal includes for the auto-generated RPC code.Andrew Tridgell1-0/+1
The thing that finally convinced me that minimal includes was worth pursuing for rpc was a compiler (tcc) that failed to build Samba due to reaching internal limits of the size of include files. Also the fact that includes.h.gch was 16MB, which really seems excessive. This patch brings it back to 12M, which is still too large, but better. Note that this patch speeds up compile times for both the pch and non-pch case. This change also includes the addition iof a "depends()" option in our IDL files, allowing you to specify that one IDL file depends on another. This capability was needed for the auto-includes generation. (This used to be commit b8f5fa8ac8e8725f3d321004f0aedf4246fc6b49)
2007-10-10r3369: More registry updatesJelmer Vernooij1-3/+61
We now pass the RPC-WINREG torture test. Also, constructions like the following work now: regtree <-> smbd <-> NTUSER.DAT (This used to be commit df952e95cd1cbbfb62b4620e9452993aaef44ad3)
2007-10-10r3367: More registry updates.Jelmer Vernooij1-2/+7
Add support flush_key and close_hive. (This used to be commit c526273df238c994c4de3c1704c6e95433f2331c)
2007-10-10r3348: More registry fixes and additions. The following functions work right ↵Jelmer Vernooij1-1/+1
now against samba 4, at least with a ldb backend: winreg_Open* winreg_OpenKey winreg_EnumKey winreg_DeleteKey winreg_CreateKey (This used to be commit a71d51dd3b136a1bcde1704fe9830985e06bb01b)
2007-10-10r3340: Various fixes in the registry code. Implement the EnumKey callJelmer Vernooij1-1/+9
in the server. (This used to be commit da65a248c292a90342e1394ee4132ef2c7afd3c8)
2007-10-10r3338: More work on the winreg RPC server. Opening hives is now supported, ↵Jelmer Vernooij1-65/+69
most other calls return WERR_NOT_SUPPORTED for now. Hive backends can be set like this: registry:HKEY_LOCAL_MACHINE = ldb:tdb://registry.tdb registry:HKEY_CURRENT_USER = gconf registry:HKEY_USERS = dir:/tmp/registry registry:HKEY_CLASSES_ROOT = nt4:/path/to/NTUSER.DAT registry:HKEY_PERFORMANCE_DATA = w95:/path/to/USER.DAT (This used to be commit 42844a4e3422bbbe891ba944c0e97861db7763ec)
2007-10-10r2696: DCOM updates:Jelmer Vernooij1-10/+15
- Start working on OXIDResolver interface - Add torture test for SimplePing() (This used to be commit b54d14a01a71082251ff926ab57974c6eb3c0a41)
2007-10-10r2627: use the new talloc capabilities in a bunch more places in the rpcAndrew Tridgell1-1/+1
server code. This fixes a number of memory leaks I found when testing with valgrind and smbtorture, as the cascading effect of a talloc_free() ensures that anything derived from the top level object is destroyed on disconnect. (This used to be commit 76d0b8206ce64d6ff4a192979c43dddbec726d6e)
2007-10-10r2519: Registry RPC pipe fixes (use struct registry_key instead of REG_KEY, etc)Jelmer Vernooij1-23/+19
(This used to be commit 00de28876df70dbb6ca67c1a90aa9793583351bf)
2007-10-10r465: we need common.h in two more rpc server pipesAndrew Tridgell1-0/+1
(This used to be commit d96b68169a5ab46cc0550732d4fe94af75e06fd6)
2007-10-10r464: a big improvement to the API for writing server-side RPCAndrew Tridgell1-81/+75
servers. Previously the server pipe code needed to return the RPC level status (nearly always "OK") and separately set the function call return using r->out.result. All the programmers writing servers (metze, jelmer and me) were often getting this wrong, by doing things like "return NT_STATUS_NO_MEMORY" which was really quite meaningless as there is no code like that at the dcerpc level. I have now modified pidl to generate the necessary boilerplate so that just returning the status you want from the function will work. So for a NTSTATUS function you return NT_STATUS_XXX and from a WERROR function you return WERR_XXX. If you really want to generate a DCERPC level fault rather than just a return value in your function then you should use the DCESRV_FAULT() macro which will correctly generate a fault for you. As a side effect, this also adds automatic type checking of all of our server side rpc functions, which was impossible with the old API. When I changed the API I found and fixed quite a few functions with the wrong type information, so this is definately useful. I have also changed the server side template generation to generate a DCERPC "operation range error" by default when you have not yet filled in a server side function. This allows us to correctly implement functions in any order in our rpc pipe servers and give the client the right information about the fault. (This used to be commit a4df5c7cf88891a78d82c8d6d7f058d8485e73f0)
2007-10-10r424: let this code compile on every machine hopefullyStefan Metzmacher1-2/+2
metze (This used to be commit 3e911db7c2cbcb38667f06e6b0282bce1b7991cb)
2007-10-10r355: Fix a bunch of compiler warnings in the registry code.Tim Potter1-5/+3
(This used to be commit 0be7a866dc39e2d63c9c114d0f668287259e7c9e)
2007-10-10r128: Another registry update. Changes:Jelmer Vernooij1-110/+104
- Start with the LDB backend - The API is now more windows-like, which should make it easier to use in rpc_server - Added a GTK+ front-end - Added some more IDL More updates will follow, especially in the RPC field.. (This used to be commit 3adffa021779b26047a20f16a3c0b53d74751560)
2007-10-10r126: - add first srvsvc and wkssvc server side stuffStefan Metzmacher1-2/+2
- we know can browse the server via the Windows Explorer - some little fixes to the winreg server pipe metze (This used to be commit 6f213a3494d3b5ab629944394b20a84075a04438)
2007-10-10r62: Fix the buildJelmer Vernooij1-2/+4
(This used to be commit 1396db85372af1824592ef66f963603e3f35803c)
2007-10-10r61: - Implement first call in the winreg rpc serverJelmer Vernooij1-1/+46
- Add some initial implementation of the ldb backend - More checks in the winreg torture test (This used to be commit ae2b63b6f1821bc4f693cb8e2a5f78718c483c24)
2007-10-10r31: More registry updates. regdiff/regpatch work now.Jelmer Vernooij1-13/+0
(This used to be commit 98224f5436695eb265f5d997cf4bc9cf735a4fb9)