Age | Commit message (Collapse) | Author | Files | Lines |
|
convert_string*()
we shouldn't accept bad multi-byte strings, it just hides problems
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Mar 24 01:47:26 CET 2011 on sn-devel-104
|
|
Signed-off-by: Stefan Metzmacher <metze@samba.org>
|
|
|
|
|
|
consistency with Samba 3.
|
|
|
|
make them wrappers around convert_string{,talloc}_convenience().
|
|
functions.
|
|
set always
metze
|
|
This was found during testing at the CIFS plugfest.
No other client seems to honour or use this bit, but it is quite
ligitimately required by the spec.
Andrew Bartlett
|
|
The approach I have used is as set out in
https://www.securecoding.cert.org/confluence/display/seccode/ARR38-C.+Do+not+add+or+subtract+an+integer+to+a+pointer+if+the+resulting+value+does+not+refer+to+an+element+within+the+array
(This used to be commit 92d5fb531db39be655f0cbd2d75b5f675a0a4cfa)
|
|
(This used to be commit a1280252ce924df69d911e597b7f65d8038abef9)
|
|
We needed a flag in bufinfo to mark packets as SMB2, as it seems that
SMB2 uses a different format for the RenameInformation buffer than SMB
does
Also handle the fact that SMB2 clients give the full path to the
target file in the rename, not a relative path
(This used to be commit 52d7972d95ddc19d22a4187b4d4428a6c3ed32d5)
|
|
This converts our SMB and SMB2 code to use a common structure "struct
request_bufinfo" for information on the buffer bounds of a packet,
alignment information and string handling. This allows us to use a
common backend for SMB and SMB2 code, while still using all the same
string and blob handling functions.
Up to now we had been passing a NULL req handle into these common
routines from the SMB2 side of the server, which meant that we failed
any operation which did a bounds checked string extraction (such as a
RenameInformation setinfo call, which is what Vista uses for renaming
files)
There is still some more work to be done on this - for example we can
now remove many of the SMB2 specific buffer handling functions that we
had, and use the SMB ones.
(This used to be commit ca6d9be6cb6a403a81b18fa6e9a6a0518d7f0f68)
|
|
(This used to be commit d37136b7abfbba75ef2e5ab855eb3382b9648b8c)
|
|
(This used to be commit f6420d933b5b011d428974f3a2a57edf19e6f482)
|
|
(This used to be commit c9651e2c5c078edee7b91085e936a93625c8d708)
|
|
There are still a few tidyups of old FSF addresses to come (in both s3
and s4). More commits soon.
(This used to be commit fcf38a38ac691abd0fa51b89dc951a08e89fdafa)
|
|
by the correct session in the SMB frontend server
metze
(This used to be commit 8a5bc18c5a3fa01848c02fdd855f35d6402866f3)
|
|
(fixes crash bugs)
metze
(This used to be commit b7418aec33033577de2420c70a8b94a2fb7901dd)
|
|
requests on the smbsrv_connection, to be able to match then on
ntcancel
metze
(This used to be commit 04f0d3d03179b6060fd013b867d13caa92ec6460)
|
|
the smb2srv code
metze
(This used to be commit 6c304a1a5f5dc6b2d3774682303874444a59b07d)
|
|
- to use a struct ntvfs_handle instead of a uint16_t fnum.
(to make it independend from the frontend protocol)
- the allocation of handles now is provided by the frontend
(smbsrv_*) via callbacks and not by each backend module
- this also makes sure that file handles are only passed
to the ntvfs subsystem when the tcon and session matches,
so modules can rely on this and need to check this.
- this allows multiple modules in the ntvfs module chain
to allocate file handles. This can be used for virtual
files like "\\$Extend\\$Quota:$Q:$INDEX_ALLOCATION"...
- also this will make SMB2 with 128 bit file handles possible
metze
(This used to be commit 287fc1c22d670f6e568014b420f7f4cb31dc7958)
|
|
(This used to be commit 3ef9326386ba1c210166302cbcf02d2ed3f19944)
|
|
(This used to be commit 7af59357b94e3819415b3a9257be0ced745ce130)
|
|
disconnect
(This used to be commit 85d70f1c150b6c8370deeb188dbf9e87c8b8d7ac)
|
|
with this it's now possible to write a
ntvfs_test programm like the vfstest in samba3
also smb2 support will be possible later
metze
(This used to be commit 7253153691e35cd206346fbd4e9b9f95c042f602)
|
|
the 3 bytes for WordCount and ByteCount are included in MIN_SMB_SIZE...
metze
(This used to be commit 4ff3fb35e88643a4637bfca032a6505f9dce3843)
|
|
now smbsrv_setup_reply() and req_setup_chain_reply() do the same thing
tridge: can you please check if this is correct,
I wonder why we don't got valgrind errors...
as the over allocation is disabled currently
metze
(This used to be commit 3441a4a74fb324a4dfbca13219df4c55ebcfbf6c)
|
|
but I don't to get the commit to large, to I'll do this tomorrow...
metze
(This used to be commit 10e627032d7d04f1ebf6efed248c426614f5aa6f)
|
|
smbsrv_send_error(..,NT_STATUS_DOS())
metze
(This used to be commit 60d7920527cd0e4142427fa59b9e617d99e3d984)
|
|
metze
(This used to be commit e6275db7b926d3660ad4a0f40041a5129001427a)
|
|
metze
(This used to be commit bd3162e6a7f154630c2d88be70ce19e8dd977133)
|
|
(This used to be commit af6606fe987fd8ef15e3ed03e71e92e7a7484ce7)
|
|
metze
(This used to be commit 7cf1423bc850aca93453d337b49ba593a034000d)
|
|
(This used to be commit 70e7449318aa0e9d2639c76730a7d1683b2f4981)
|
|
(This used to be commit 87f665a1d5ba74289974bf9d8f9441c162e6f1b1)
|
|
metze
(This used to be commit 5fea278cb65076cea71bb6c921e51c4feffc37d7)
|