Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
- Close unused policy handle for created group
- re-align code - it is more readable this way IMHO
|
|
- fix a flaw that user RID is not returned in case
user is recreated
- close unused policy handle to created user
- do not take into account the result from
test_samr_close_handle - we don't case
|
|
|
|
|
|
Pre-connecting SAMR and LSA pipes is implemented in
test_libnet_context_init() function
|
|
|
|
This way we ensure that LIBNET call will be issued against
the DC we are testing against
|
|
Caller of this function may not need group RID and
in such case it passes NULL for rid parameter
|
|
and create rpc connections to SAMR and LSA pipes.
This function should be used in cases where we need
'deterministic' connection to the DC we are testing against.
The problem is that most of the test follow the pattern:
1. Connect to server supplied on command line
2. Create user/group through connection in 1.
3. Use 'fresh' libnet_context to query/alter the object in
step 2.
In singe-DC environment this work well. But in multiple-DC
environment libnet may connect to another DC (step 3), not
the one we use in step 1 and 2. This leads to false error -
object created in step 2 is not found on DC we are querying
in step 3.
|
|
'name' var is changed during the test execution and should
contain samAccountName for the user, while test_user_cleanup()
expects account RDN to be passed
|
|
In case group already exists, we should get NT_STATUS_GROUP_EXISTS.
|
|
We already have common implementation for create/delete
group in libnet/utils.c
|
|
We already have a nice common test_domain_open()
function in libnet/util.c
|
|
implementation instead of not-so-informative test_cleanup()
|
|
We always call this function with user's account RDN
while samr_LookupNames() searches for samAccountName.
|
|
|
|
We now have a nice common test_samr_close_handle() function to use
|
|
We have same functionality already implemented by
test_user_create() in libnet/utils.c
|
|
- param names made more clear what they stand for
- user RID out param is now optional, so that this function may
be used in cases where we don't need user RID
- SAMR connection handle is closed as it is not used further
(we should play nice with servers)
|
|
|
|
|
|
- name changed to test_domain_open to be more alike athore functions
in utils.c file
- output parameters moved to the end param list definition just
after mem_ctx so it is somehow more clear those params are OUT
|
|
- param names made more clear what they stand for
- dom_sid out param is now optional, so that this function may
be used in cases where we don't need dom_sid
- SAMR connection handle is closed as it is not used further
|
|
It is to be used further for closing opened handles when testing
using SAMR interface
|
|
Test may be further refactored to be converted as a test case
(what it is actually)
|
|
|
|
In multi-DC environment, NBT name resolution may resolv
domain name to any of DCs.
This make this test to fail, as we are modifying the user account
on one DC and query user info immediately after that on another DC.
|
|
There is no need anymore to modify samAccountName
of the testing user to original value as test_cleanup()
will spot the right samAccountName to delete
|
|
test_cleanup() is called always with RDN name of the user to be deleted.
When modify-user test fails however, we end up with a user
with RDN = libnetusertest and samAccountName = random_name.
This way we can not delete the user and the error message is
quite misleading (I've spent a *lot* of time trying to figure out
if the database is corrupted because of this error).
|
|
|
|
This patch replaces hand-make count of fields to be tested
with defines for FIRST-LAST value for corresponding fields
to test with.
As a side-effect, 'acct_flags' is now included in tests.
|
|
|
|
The reason for this is that some systems include
<rpc/rpc.h> from within system headers. HP-UX 11.00
does so somewhere deep inside of <shadow.h>.
For torture/winbind/struct_based.c <rpc/rpc.h> resolves
to torture/rpc/rpc.h and breaks the build.
metze
|
|
Upstream subunit makes a ":" after commands optional, so I've fixed any
places where we might trigger commands accidently. I've filed a bug
about this in subunit.
|
|
Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
|
|
Guenther
|
|
torture tests.
Mimir, please check.
Guenther
|
|
Guenther
|
|
This choses an appropriate talloc context to attach the schema too,
long enough lived to ensure it does not go away before the operation
compleates.
Andrew Bartlett
|
|
metze
|
|
metze
|
|
metze
|
|
metze
|
|
The documentation shows that all these functions in fact use the same
flags variable type. To be consistent between functions, and to allow
easy reference to the WSPP docs, it is better for us to also use this
generic DrsOptions bitfield rather than one per operations.
|
|
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
|
|
The load of defaultObjectCategory as an extended DN means we need to
use the common parsing functions I just split out, rather than the
GET_DS_DN macro.
The objectGUIDs are loaded so that we can create the extended DN when
we load from LDIF (and are loaded for the other cases for
consistency).
Also adapt callers to API changes needed for common parsing code
Andrew Bartlett
|
|
libnet_BecomeDC and libnet_UnbecomeDC()
We're supposed to pass in source_dsa_address...
metze
|
|
This will allow us in future to do tests on the LDB values we generate
from the DRS replication.
Andrew Bartlett
|
|
Signed-off-by: Stefan Metzmacher <metze@samba.org>
|