Age | Commit message (Collapse) | Author | Files | Lines |
|
Guenther
(This used to be commit d6cc668a6c1dcf45d06a1f666d5341f2a6e7f131)
|
|
flag.
Guenther
(This used to be commit 3e42ccc6096198458f66841f91234f670ceb59c4)
|
|
Jerry, there is a big difference on the wire between these two:
[out] uint32 x;
and
[out] uint32 *x;
if you change from
[out] uint32 x;
then you need to change to:
[out,ref] uint32 *x;
otherwise it changes the format on the wire, which means we are no
longer compatible with MS servers.
but be aware that even if you change to a ref ptr, you also need to
change all the client code to set all the return variables in the out
part of the structure. That's why I don't like the MIDL restriction of
forcing the use of ref pointers for output variables - it makes life
much harder when writing client code, and makes the code much more
error prone (just look at all the extra code needed to make this work
again).
I know we could auto-allocate these variables in the generated client
side NDR code, but if we did that then we would have no way of doing a
_real_ ref out pointer, which we really wanted to set to some already
allocated variable.
So please hold off on changing our idl to use the MIDL convention for
output variables until Jelmer and I have had a good "chat" about this :-)
(This used to be commit 555aed43ba3c08360ca7fa921622b80732a7f657)
|
|
(This used to be commit ab0a798c57564901f0adcd8aedc1ef0928e79edd)
|
|
(This used to be commit 694677dafefdd94fa0a9bed93efab70c528dcb26)
|
|
Andrew Bartlett
(This used to be commit 1ea6b600f42d3ccfb75da98f2013928fda524450)
|
|
metze
(This used to be commit f1708fd9434ee2a9ae25e9d912f0c350d8e1a256)
|
|
- add a test for GidToSid
metze
(This used to be commit fb92643a8b64428e8259bc21fe04f876b24bfd84)
|
|
jelmer: I think there're a few ref pointer related bugs in pidl
we need to discuss them the next days
metze
(This used to be commit 8c4241ecbbd9686d990073cec53dc1fde0fdde9b)
|
|
(This used to be commit d46c3be9f9db6666be52b5584b0210da925106d1)
|
|
valgrind. Reduce to 50, which is plenty for testing the code
(This used to be commit 911c8e1c73bf3953591755ecb4c50f5644fc9c18)
|
|
d_printf() is. This fixes a crash on solaris
(This used to be commit 52d156671158fa25d3a84a46c98ca1d81e4a18d1)
|
|
(This used to be commit cc89ef3e1fd2f1d550ab65d32dfa894dc7963868)
|
|
(This used to be commit 06469a6ba0ee1cc8701214bcefa1d6c696b0150b)
|
|
fix the misleading idl names
(This used to be commit 8367b3bcee9338fa3e268b7342ae8db928008b55)
|
|
(This used to be commit 6e7e151432a31e48a67679df3966d2227d555317)
|
|
Andrew Bartlett
(This used to be commit 2aa0e6a1bf977d60a14314d5d82d176824751d00)
|
|
This commit cleans up a number of aspects of the LSA interface.
Firstly, we do 2 simple searches on opening the LSA policy, to obtain
the basic information we need. This also avoids us searching for
dnsDomain (an invented attribute).
While I was at it, I added and tested new LSA calls, including the
enumTrustedDomainsEx call. I have also merged the identical structures
lsa_DomainInformation and lsa_DomainList.
Also in this commit: Fix netlogon use of uninitialised variables.
Andrew Bartlett
(This used to be commit 3f3fa7f466df56612064029143fbae8effb668aa)
|
|
Make it easier to debug CrackNames failures.
Andrew Bartlett
(This used to be commit 5dd07074db0b25ea2e929bbdcf89f26e3665bd1c)
|
|
* Move dlinklist.h, smb.h to subsystem-specific directories
* Clean up ads.h and move what is left of it to dsdb/
(only place where it's used)
(This used to be commit f7afa1cb77f3cfa7020b57de12e6003db7cfcc42)
|
|
(This used to be commit 4242309d54d201b35e9cc96c0359ded64cf7485a)
|
|
(This used to be commit 8df16dce4d67c17a24aba934f0d656aa5670e539)
|
|
when the wrong macro is used on a field.
metze
(This used to be commit dd0f692d19416c82f237661710b814ba20163605)
|
|
(This used to be commit 9455b0340f634afa25a5af5ed4ea385212cf95a7)
|
|
objectclass
metze
(This used to be commit af1efa0c790a86f68bd7f761b22478895bfdaaea)
|
|
ref pointers!
I'm sure there're more places and more care is needed when idl files
are changed. Hopefully testing against windows in the build farm
find such bugs in future...
Why is in the client library this no more possible:
NTSTATUS foo([in,out,ref] uint8 *foo);
and then just
r.in.foo = &foo;
status = dcerpc_foo(p, mem_ctx, &r);
and r.out.foo will set to r.in.foo via pidl magic,
that worked some time ago...
metze
(This used to be commit d8952f00c77ba59e0806b0de802ac28ac977779c)
|
|
surface
of spoolss. If snum is to be removed, then we should make at least the attempt
to walk parts of the code before and after the changes.
This walks GetPrinterInfo level 0-7.
Volker
(This used to be commit 0c05f571a0eda2412896f340b7c751cf7cbdbd2a)
|
|
regression we had in 3.0.23...
Volker
(This used to be commit 0236f3b41a4f9015f8551ffb67db59fa48212bf5)
|
|
declarations.
Andrew Bartlett
(This used to be commit 15dd43b77328c4d56438bdb34b3e8139c5a83878)
|
|
metze
(This used to be commit 22463cbcdd159657d04657071451738e768d0b2a)
|
|
security
descriptor. This is something that W2k3 does _not_ pass and probably is not
expected to, it seems the don't check access at tconX time.
Thanks to metze for the hint how in the srvsvc_NetShareInfo1501 struct the
length of the sd can be encoded in idl.
As metze says, there's probably more to the share secdesc, this needs more
testing. This one is here to walk the samba3 code.
Volker
(This used to be commit 67185508229a8d7f144c22cb194f573c932d6de5)
|
|
and we
check if we can actually see the user SID on a fresh sessionsetup.
This also gives us the simple create_user, which can lead to more fun tests
:-)
Volker
(This used to be commit 92afe1156915ab6c7e21380000bdad93414d0829)
|
|
(This used to be commit 963878a5f394234229af5835b2ccdd6d4b369466)
|
|
(This used to be commit 4f13b7d53c0f177cfd2a0d00ee14de3fce12d9bf)
|
|
login.
Found that because I want to play around with setsharesecurity, for this I
need the "whoami" call figuring out the SID of the currently connected user.
Not activating this test yet until the build farm has picked up the new samba4
revision.
Volker
(This used to be commit 5603db30e7dfbb3d5c4599d36a50007a2b3cac75)
|
|
(This used to be commit 656d8337c474374014ac681914fa761916a9bc3c)
|
|
(This used to be commit bd84fde777366899391d122e0aa5034ba0b80037)
|
|
to be created as foreign, even if they are in a local domain.
Also we do need the user to exist for the life of the test, as we add
it to a group.
Andrew Bartlett
(This used to be commit ae470ff7014e52b55d88e9fe12e2322e069daf9d)
|
|
of this test.
Andrew Bartlett
(This used to be commit b4d75f01d9cb2d1c9d5facfd5eb39c8a062886d4)
|
|
I still need to figure out what causes the rest to fail...
Andrew Bartlett
(This used to be commit aa34bd46cb1446b9fb6fd8f1b8ffca5f81b3c052)
|
|
- creation of ForeignSecurityPrincipals
- template duplication code
Rework much of the LSA server to pass the RPC-LSA test. Much of the
server code was untested. In implementing the LSA Accounts feature, I
have opted to have it only create entires when privilages are applied,
and not to delete entries, but to delete the privilages.
We skip some parts of the test, but it is much better than not testing
it at all.
Andrew Bartlett
(This used to be commit 10eeea6da465564ed9f785d06e2d2ed06cfe29a4)
|
|
in RPC-SAMR test.
Andrew Bartlett
(This used to be commit 08ec74d620ffe613655f28d002e60ca8201fadd9)
|
|
still a couple of unimplemented functions, but this is far better than
not testing this at all. In particular, this exercises the
password_hash module.
Specific changes:
- Add support for SetDomainInfo
- Add many more info levels to QueryDomainInfo
- Set a domain comment in RPC-SAMR, and verify it is kept
- Refactor QueryUserInfo not to always serach for all attributes
- Add QueryDiplayInfo3 and QueryDomainInfo2 as aliased calls
- Make OemChangePassword2 search under the samdb_base_dn(), so it
finds the user when partitions are active.
- Skip SetSecurity, DisplayIndex, MemberAttributesOfGroup and
'Multiple' alias operations in RPC-SAMR for Samba4
- Add RPC-SAMR as a 'slow' RPC test (it is quite slow)
Andrew Bartlett
(This used to be commit 01d25c9d6ca8d036d40040e5ee87a330e5b84d55)
|
|
skipping some checks.
These should be removed, and the code fixed, but currently we are
loosing quality because the test isn't run by default.
Andrew Bartlett
(This used to be commit 1306f60c97562a71ae15f0ab257ddcd5e0af36d4)
|
|
which is very useful for analysing a windows machine remotely
with this I found that vista-beta2 doesn't have an 'administrator' account
and mapps any not known user to MACHINENAME\Guest
metze
(This used to be commit 97ae93627527f65b6ecded9884a26d4cffa1409d)
|
|
(This used to be commit 9e8574ac6cd38d1ff388f0c9ff37d86b316a431e)
|
|
test suite tree, looks a bit more like other unit testing API's,
fixes some memory responsibility issues, introduces testcases,
and removes the need for tests to call torture_ok().
(This used to be commit 0445b1a56a02552f895f400960b9ced39244a144)
|
|
(This used to be commit f8bae84e89bb2fe8deea7795ad59fbefa9c98e79)
|
|
anonymously. Disable that test for now.
(This used to be commit 9015713d62558ba76d693c5e8a4c23e3fd3ccab5)
|
|
(This used to be commit e980066111cf442102b849b04a411c3f2df8e05b)
|