Age | Commit message (Collapse) | Author | Files | Lines |
|
File descriptor leaks only when we use file instead of stdout.
Found by cppcheck:
[./source3/torture/smbiconv.c:219]: (error) Resource leak: out
[./source4/torture/smbiconv.c:211]: (error) Resource leak: out
|
|
(This used to be commit 8795697db56e4ca6715950d68f5ec370604fcc76)
|
|
(This used to be commit db6dd425e3526c04e96d778a736dbb5cf14ddc56)
|
|
There are still a few tidyups of old FSF addresses to come (in both s3
and s4). More commits soon.
(This used to be commit fcf38a38ac691abd0fa51b89dc951a08e89fdafa)
|
|
(This used to be commit 8b622c5ded0732df0eaf9f6226f52a27b6eacd73)
|
|
There is now a new --debug-stderr option to enable debug to STDERR.
popt isn't perfect, but the callbacks are used in all the main Samba
binaries, and should be used in the rest. This avoids duplicated
code, and ensures every binary is setup correctly.
This also ensures the setup happens early enough to have -s function,
and have a correct impact on the credentials code. (Fixing a bug that
frustrated tridge earlier today).
The only 'subtle' aspect of all this is that I'm pretty sure that the
SAMBA_COMMON popt code must be above the CREDENTIALS code, in the
popt tables.
Andrew Bartlett
(This used to be commit 50f3c2b3a22971f40e0d3a88127b5120bfc47591)
|
|
In Samba4 this is now an enum. Possibly by accident, True just happens
to map to the right value in this case. (-:
(This used to be commit affacc539864435cbc749a4c1a6b848c61b7182b)
|
|
(This used to be commit 4c0226c71820c18725fd44dc66e1db36037c6a70)
|
|
(This used to be commit 00807119eeb32dcf5f3b19fa08956fa9177405a5)
|