summaryrefslogtreecommitdiff
path: root/source4
AgeCommit message (Collapse)AuthorFilesLines
2010-07-07s4-dsdb: use ldb_operr() in the dsdb codeAndrew Tridgell43-625/+455
this replaces "return LDB_ERR_OPERATIONS_ERROR" with "return ldb_operr(ldb)" in places in the dsdb code where we don't already explicitly set an error string. This should make is much easier to track down dsdb module bugs that result in an operations error.
2010-07-07s4-ldb: added ldb_error() and ldb_operr()Andrew Tridgell3-2/+22
These will be used to help avoid the problem we have with hundreds of places that do "return LDB_ERR_OPERATIONS_ERROR" without an explanation. It is very difficult to track down ldb errors which don't have any explanation. By replacing "return LDB_ERR_OPERATIONS_ERROR;" with "return ldb_operr(ldb);" we at least get a file:line message in the ldb error string. It isn't an ideal error message, but it is much better than just "operations error" This change also makes ldb_oom() return the error code (LDB_ERR_OPERATIONS_ERROR) so you can do: return ldb_oom(ldb); instead of: ldb_oom(ldb); return LDB_ERR_OPERATIONS_ERROR;
2010-07-07s4-ldb: added support for simple binds on ldb_ldap backendAndrew Tridgell1-0/+50
this uses the options[] array to pass in bindMech, bindID and bindSecret. Currently only "simple" is supported.
2010-07-07s4-ldb: added ldb_options_find()Andrew Tridgell6-7/+85
ldb_options_find() allows backends to find options in the options[] array passed to the connect operation. This will be used by the ldb_ldap bind code
2010-07-06s4:libcli: Modify S4 client library to check for proper CN alignmentSteven Danneman2-2/+102
MS-CIFS 2.2.7.4.2 states that FILE_NOTIFY_INFORMATION structures in change notify replies must be aligned to 4-byte boundaries. This updates s4 client to check for this restriction and also adds a torture test which should tickle a server into giving unaligned structures if it doesn't follow the spec.
2010-07-06s4:new_partition LDB module - fix an uninitalised variable warningMatthias Dieter Wallnöfer1-2/+1
> [ 651/1946] Compiling dsdb/samdb/ldb_modules/new_partition.c > ../dsdb/samdb/ldb_modules/new_partition.c: In function 'new_partition_add': > ../dsdb/samdb/ldb_modules/new_partition.c:195: warning: 'down_req' may be used uninitialized in this function The "down_req" variable isn't used anymore.
2010-07-06s4:SAMR rpc server - "SetUserInfo" - fix the implementation of the expire flagMatthias Dieter Wallnöfer1-3/+22
It has to consider the "password_expires" flag to known if the "pwdLastSet" has to be updated or to be resetted.
2010-07-06s4:SAMR rpc server - "QueryUserInfo" - send back the password expired flag ↵Matthias Dieter Wallnöfer1-1/+6
on level 21 Taken from the s3 server code
2010-07-06s4:dsdb - samdb_result_force_password_change - also when "pwdLastSet" is ↵Matthias Dieter Wallnöfer1-3/+9
"-1" we shouldn't force a password change This value is set by the ADUC console.
2010-07-06s4:rpc_server/lsa/dcesrv_lsa.c - fix typoSumit Bose1-1/+1
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-05s4-smbtorture: add my (C) to rap torture lib.Günther Deschner1-0/+1
Guenther
2010-07-05s4:dsdb/password_hash: implement DSDB_CONTROL_BYPASS_PASSWORD_HASH_OIDStefan Metzmacher1-0/+20
metze
2010-07-05s4:dsdb: allocate DSDB_CONTROL_BYPASS_PASSWORD_HASH_OIDStefan Metzmacher2-0/+6
When importing users from Samba3 we need to control all values. metze
2010-07-05s4:dsdb/password_hash: fix some c++ compiler warningsStefan Metzmacher1-9/+12
metze
2010-07-05DNS objects should not be ignoredZahari Zahariev1-21/+9
Recently I have found that after vampireing from a clean Windows server we have the same DNS objects in the ldb. So ldapcmp has to no longer ignore them. Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
2010-07-05s4:winbind/wb_cmd_setpwent.c - fix a possible crash condition in the ↵Matthias Dieter Wallnöfer1-8/+10
"winbind struct test" Use a "talloc_strdup" for duplicating usernames.
2010-07-05s4:samr RPC server - "SetUserInfo" - allow some more informations to be setMatthias Dieter Wallnöfer1-0/+25
Taken from the s3 implementation.
2010-07-05Changed passwords.py to use the correct account as acl checks now pass.Nadezhda Ivanova1-14/+6
2010-07-05s4-dsdb: Implementation of User-Change-Password and User-Force-Password-ChangeNadezhda Ivanova2-85/+226
These CARs need to be checked on password change and password reset operations. Apparently the password attributes are not influenced by Write Property. Single detele operations and modifications of dBCSPwd are let through to the password_hash module. This is determined experimentally.
2010-07-04s4:subtree_rename LDB module - Cosmetic fixesMatthias Dieter Wallnöfer1-3/+4
2010-07-04s4:subtree_delete LDB module - fix comments and add my copyrightMatthias Dieter Wallnöfer1-2/+3
(I've introduced the subtree delete mechanism)
2010-07-04s4:wb_cmd_list_groups.c - don't crash when we don't get any group at allMatthias Dieter Wallnöfer1-2/+4
2010-07-04s4:wb_cmd_list_groups.c - indentation and comment fixesMatthias Dieter Wallnöfer1-9/+11
2010-07-04s4:libnet - add missing "talloc_free"s for "c" contexts on "recv" operationsMatthias Dieter Wallnöfer3-5/+8
2010-07-03s4:torture/rpc/samlogon.c - strip trailing whitespacesMatthias Dieter Wallnöfer1-199/+199
2010-07-03s4:torture/rpc/samlogon.c - provide a function which sets and afterwards ↵Matthias Dieter Wallnöfer1-0/+97
resets the minimum password age This is needed since we on s4 do now use the Windows Server standard of 1 day.
2010-07-03s4:dsdb/tests/python/ldap_schema.py - remove a now useless "schemaUpdateNow" ↵Matthias Dieter Wallnöfer1-10/+0
request "schemaUpdateNow" on s4 is now a non-op and therefore not strictly needed anymore.
2010-07-03s4:urgent_replication.py test - remove unneeded "relax" control parametersMatthias Dieter Wallnöfer1-2/+2
2010-07-03s4:schema_load LDB module - fix a segfault condition on schema refreshMatthias Dieter Wallnöfer1-0/+5
The schema refresh operation itself starts requests from the top of the LDB modules stack (see call "dsdb_schema_set_attributes" - search operations). This doesn't work well when these do perform "dsdb_get_schema" calls. Since the new schema isn't marked as "refreshed" atm (but in fact it still is - we didn't terminate the reload/refresh yet) we could perform other calls to "dsdb_schema_refresh" and run into serious trouble (segfault).
2010-07-03s4:schema_set.c - Fix a commentMatthias Dieter Wallnöfer1-1/+2
2010-07-03s4:dsdb_schema_set_attributes - remove unneeded filter criteriasMatthias Dieter Wallnöfer1-2/+4
We already choose the right entry by specifying the right basedn with scope "LDB_SCOPE_BASE".
2010-07-03s4:dsdb_module_load_partition_usn - check for "res->count" equal/unequal to 1Matthias Dieter Wallnöfer1-1/+1
2010-07-03s4:schema_set.c - fix typoMatthias Dieter Wallnöfer1-1/+3
2010-07-03s4:schema_load.c - jump to "failed" on an error conditionMatthias Dieter Wallnöfer1-3/+2
2010-07-03s4:setup/provision_basedn_modify.ldif - set "minPwdAge" to the right valueMatthias Dieter Wallnöfer1-2/+1
Now we should have fixed all password related tests to cooperate with this value
2010-07-03s4:pwsettings net utility - change also here the "minPwdAge" to be the real ↵Matthias Dieter Wallnöfer1-2/+2
default Which is one day.
2010-07-03s4:dsdb/tests/passwords.py - set and reset the "minPwdAge" properlyMatthias Dieter Wallnöfer1-2/+21
After a patch proposal of Nadya and some reflection I think that it's really worth to change all tests which need a "0" "minPwdAge" to set it manually and reset the default afterwards. So we can finally introduce the default "minPwdAge" on provision. Patch proposal by: Nadya Ivanova
2010-07-02Tests for user-change-password and force-password-change access rightsNadezhda Ivanova1-4/+242
2010-07-02s4/schema: remove unnecessary deletion of dsdb_schema cached pointerAnatoliy Atanasov1-3/+0
This is needed so we can find and free old schemas based using the cached pointer
2010-07-02s4-smbtorture: enable extended SetValue test against Samba3.Günther Deschner1-3/+2
Guenther
2010-07-02s4-ldb: fixed error handling in openldap backendAndrew Tridgell1-5/+15
fixed several bugs in error handling. the ldb context was used without being initialised in the error paths, and several error paths did not set an ldb error string.
2010-07-02s4-ldb: fixed the parsing of references in the openldap backendAndrew Tridgell1-5/+6
We need to use ldap_parse_reference() not ldap_parse_result()
2010-07-02s4-dsdb: fixed use after free of sasl mechanisms opaqueAndrew Tridgell1-0/+6
the supportedSASLMechanisms opaque must live for at least as long as the ldb, or we can crash when the first connection is torn down Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-07-02s4-dsdb: fixed spelling of supportedSASLMechanismsAndrew Tridgell2-2/+2
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-07-02s4:dsdb Ensure we free old schema copiesAndrew Bartlett1-6/+25
It was reported by aatanasov that we kept around one whole schema per modification made. This does not fix that, but I hope moves us closer to a fix The most important part of the fix is that: - if (schema_out != schema_in) { - talloc_unlink(schema_in, ldb); - } was the wrong way around. This is now handled in the schema_set calls. Andrew Bartlett
2010-07-02s4/dsdb: Assert DSDB_FLAG_*_MODULE is always passed in function callKamen Mazdrashki1-0/+5
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02s4-source4/dsdb/samdb/ldb_modules/util.c Use DSDB_FLAG_NEXT_MODULE flagKamen Mazdrashki1-2/+3
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02s4-source4/dsdb/samdb/ldb_modules/subtree_delete.c: Use ↵Kamen Mazdrashki1-1/+3
DSDB_FLAG_NEXT_MODULE flag Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02s4-source4/dsdb/samdb/ldb_modules/schema_load.c: Use DSDB_FLAG_NEXT_MODULE flagKamen Mazdrashki1-1/+2
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02s4-source4/dsdb/samdb/ldb_modules/samldb.c: Use DSDB_FLAG_NEXT_MODULE flagKamen Mazdrashki1-4/+5
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
generated by cgit (git 2.34.1) at 2024-12-29 00:32:05 +0000