Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2009-11-29 | lib/registry/util.c - Reorder the registry datatypes of the conversion functions | Matthias Dieter Wallnöfer | 1 | -9/+12 | |
This is absolutely cosmetic and makes the code easier to comprehend. | |||||
2009-11-29 | Revert "s4:registry/util - Don't include the trailing '\0' in the internal ↵ | Matthias Dieter Wallnöfer | 1 | -6/+2 | |
data format but add it on the back-conversion to a string" This reverts commit 7d400715e9af2056690c03a1a2f45c7f343fa313. "convert_string_talloc_convenience" does always add the NULL termination. Didn't know that. Thanks Jelmer for pointing out! | |||||
2009-11-28 | s4:upgrade_from_s3 - Move it back to "setup" | Matthias Dieter Wallnöfer | 2 | -1/+1 | |
Suggested by Jelmer | |||||
2009-11-28 | s4:setup/provision - Rework | Matthias Dieter Wallnöfer | 1 | -5/+24 | |
- Revert change in "ask" - was previously correct - Readd accidentally removed checks for non-null realm and domainname - On interactive mode perform only one "ask" call per question - Inform the user about the unset administrator password | |||||
2009-11-28 | s4:upgrade.py - remove my copyright | Matthias Dieter Wallnöfer | 1 | -1/+0 | |
First I wanted to add also other changes but then I didn't introduce them. Therefore remove my copyright again. | |||||
2009-11-28 | s4:upgrade.py - readd accidentally removed empty lines | Matthias Dieter Wallnöfer | 1 | -0/+4 | |
Jelmer pointed out that this is against the PEP8 norm | |||||
2009-11-28 | s4:samba3.py/upgrade.py: Revert | Matthias Dieter Wallnöfer | 3 | -10/+9 | |
This reverts commit 2175c0ed0649d545ea833d50e8d33fbee9051c35. This reverts commit 6c3e2417a0639cd7c367de93615c422cf5217456. This reverts commit dbb8989e05ac3189a5eca11fa40d572388ea02fc. This reverts commit 82adfa39b75aa628c88f828278c6ac09335d1a49. This reverts commit f299efa8f05c6a5b739222bdf75690a4591d3650. After a small discussion with Jelmer we agreed that this isn't the right way to fix the problem. We should wait for a real patch rather to rely on temporal hacks. | |||||
2009-11-28 | s4-ldb: make it much easier to use common ldb controls | Andrew Tridgell | 2 | -15/+64 | |
2009-11-28 | s4-drs: cope with bogus empty attributes from w2k8-r2 | Andrew Tridgell | 1 | -0/+17 | |
w2k8-r2 sometimes sends empty attributes with completely bogus attrid values in a DRS replication response. This allows us to continue with the vampire operation despite these broken elements. | |||||
2009-11-28 | s4: fix SD update and password change in upgrade script | Matthieu Patou | 8 | -93/+161 | |
- reserve a new Samba OID for recalculate SD control - fix the update SD function - fix handling of kvno in the update_machine_account_password function - fix handling of handles in RPC winreg server Signed-off-by: Andrew Tridgell <tridge@samba.org> | |||||
2009-11-27 | s4:WINREG RPC server - add another "talloc_unlink" in "DeleteKey" | Matthias Dieter Wallnöfer | 1 | -1/+5 | |
Also here we waste memory - therefore free the pointless handle after the delete. | |||||
2009-11-27 | s4:WINREG RPC server - Reintroduce the free operation on "CloseKey" | Matthias Dieter Wallnöfer | 1 | -0/+2 | |
Better use "talloc_unlink" here Since we could have more than one reference. | |||||
2009-11-27 | s4-smbtorture: more and stricter tests for printer and data keys in RPC-SPOOLSS. | Günther Deschner | 1 | -4/+8 | |
Guenther | |||||
2009-11-27 | s4:provision.py - remove hardcoded SIDs and RIDs | Matthias Dieter Wallnöfer | 1 | -3/+3 | |
After rework of the SDDL modules this is possible. In future: Never hardcode them anymore! Always use the abbreviations. | |||||
2009-11-27 | s4:security/sddl - rework of the security descriptor abbreviations | Matthias Dieter Wallnöfer | 1 | -28/+33 | |
- Reoder them - Add some new ones (needed for the security descriptor in the provision script) | |||||
2009-11-27 | s4:registry/util - Don't include the trailing '\0' in the internal data ↵ | Matthias Dieter Wallnöfer | 1 | -14/+27 | |
format but add it on the back-conversion to a string As far as I know the registry library saves all data (including) strings without the null termination. So do it also here in a similar way. | |||||
2009-11-27 | s4:net utility - add a notice for the "help" operation and format it's ↵ | Matthias Dieter Wallnöfer | 1 | -1/+6 | |
output of the command list better | |||||
2009-11-27 | s4:samba3.py - deactivate also the assertion on line 599 | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2009-11-27 | s4:winbind - Fix it another time up | Matthias Dieter Wallnöfer | 1 | -2/+14 | |
The first fix attempt did break some configurations (incl. "make test"). This now is the right fix with the right comment. | |||||
2009-11-27 | s4:provision.py - cosmetic | Matthias Dieter Wallnöfer | 1 | -8/+7 | |
2009-11-27 | s4:samba3.py (and test) - deactivate the tests until those parameters are fixed | Matthias Dieter Wallnöfer | 2 | -4/+4 | |
2009-11-27 | s4:upgrade.py - Umlaut problem | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2009-11-27 | s4:tests.sh - Make also here the change from "upgrade" to "upgrade_from_s3" | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2009-11-27 | s4:upgrade.py - rework to make the upgrade s3 -> s4 possible again | Matthias Dieter Wallnöfer | 1 | -72/+72 | |
Able to read basic settings "workgroup", "realm", "netbios name" and the function mode from the s3 "smb.conf" and use them for the provision of s4. | |||||
2009-11-27 | s4:upgrade_from_s3 - Fix message outputs | Matthias Dieter Wallnöfer | 1 | -3/+3 | |
The quiet parameter was interpreted in the reverse manner. | |||||
2009-11-27 | s4:upgrade.py - the import of WINS databases don't seem to work always | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
Disable it for now until the cause has been found | |||||
2009-11-27 | s4:samba3.py - ignore comments in "smb.conf" files | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2009-11-27 | s4:samba3.py - don't read those informations out from the TDB | Matthias Dieter Wallnöfer | 1 | -3/+4 | |
At the moment those three calls are broken | |||||
2009-11-27 | s4:samba3.py - support the TDB version 3 | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2009-11-27 | s4:provision - Fix up the provision of "standalone" and "member" mode | Matthias Dieter Wallnöfer | 2 | -10/+12 | |
Both modes weren't possible anymore since 1.) the secrets entry wasn't created, 2.) a lookup in winbindd was done using "lp_workgroup()" rather than "lp_sam_name()" (since on the mentioned two configurations we use the netbios name as domainname - and not the workgroup). | |||||
2009-11-27 | s4:provision.py - cosmetic output correction | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2009-11-27 | s4:setup/provision - make the interactive mode work again | Matthias Dieter Wallnöfer | 1 | -13/+3 | |
2009-11-27 | s4:upgrade script - rename it to "upgrade_from_s3" and do some rework | Matthias Dieter Wallnöfer | 1 | -17/+20 | |
- Give a better name to the script - Move it to the location where also "upgradeprovision" resides - Fix up trailing whitespaces and tabs | |||||
2009-11-27 | s4-install: old systems don't have sed -i | Andrew Tridgell | 1 | -1/+4 | |
surprisingly, this failure came from SLES8. I didn't realise that the -i option was so new! | |||||
2009-11-27 | s4-selftest: s4 passes all the SMB2-LOCK tests now | Andrew Tridgell | 1 | -2/+0 | |
2009-11-27 | s4-torture: fixed error code for s4 in SMB2-LOCK test | Andrew Tridgell | 1 | -1/+8 | |
s4 returns NETWORK_NAME_DELETED if you attempt to use an invalid tree connection for a lock. This test (correctly I think) happens before we validate the file handle. That implies that when you pass both a closed handle and a invalid tree you should get NT_STATUS_NETWORK_NAME_DELETED. | |||||
2009-11-27 | s4-ntvfs: win7 does not check for the NONE smb2 lock flag on unlock | Andrew Tridgell | 1 | -1/+2 | |
2009-11-27 | s4-selftest: s4 passes this test now | Andrew Tridgell | 1 | -1/+0 | |
2009-11-27 | s4-torture: mark s4 as doing valid lock range tests on SMB | Andrew Tridgell | 1 | -1/+2 | |
2009-11-27 | s4-ntvfs: move valid lock range test from smb2 layer to generic code | Andrew Tridgell | 2 | -6/+19 | |
win7 also fails invalid lock ranges on SMB | |||||
2009-11-27 | s4:smb_server/smb2: don't reset highest_smb2_seqnum on SMB2 Cancel | Stefan Metzmacher | 1 | -2/+4 | |
metze | |||||
2009-11-27 | s4-torture: fixed expected error codes for s4 in SMB2-LOCK | Andrew Tridgell | 2 | -3/+24 | |
I think the error/success codes returned by windows for these tests are quite bogus. The ones s4 gives are much more reasonable. The locking ones returning NT_STATUS_SUCCESS could lead to data loss, as an application thinks it has a file locked correctly when it fact it doesn't, so it could do an unsafe modify. | |||||
2009-11-27 | s4-drstest: don't use getenv("LDB_URL") in test suites | Andrew Tridgell | 1 | -18/+7 | |
I was stumped for a while as to why the drs test suite was failing for me. It turned out that it looked for LDB_URL in the environment, and used it if set. I had it set in my terminal, and it was happily munching on my sam.ldb while testing. Quite a cute bug really :-) | |||||
2009-11-27 | s4-pvfs: fixed access check failure in SFILEINFO test | Andrew Tridgell | 1 | -8/+5 | |
matching windows behaviour is not always the right thing to do! | |||||
2009-11-27 | s4-ldb: improve detection of whether the server has a GC port | Andrew Tridgell | 1 | -5/+9 | |
We were trying to open $SERVER:3268 regardless, which could result in creating a file called "localdc1:3268", which led to subsequent test failures | |||||
2009-11-27 | s4-ldb: better to test for valid arguments in ldb library than commandline | Andrew Tridgell | 2 | -9/+10 | |
We were testing for valid DNs in ldbrename in the command line tool. This hid a bug in the ldb library where we caught a bad DN in the objectclass module rather than in the main ldb code. It is better to do validation of the DNs passed on the command line in the library code, as this gives us more consistent error handling between the programming APIs for ldb and the command line. | |||||
2009-11-27 | s4-smb2: SMB2 uses NT_STATUS_CANCELLED for cancelled locks | Andrew Tridgell | 1 | -1/+5 | |
2009-11-27 | s4-smb2: sequence numbers are not checked in SMB2_OP_CANCEL | Andrew Tridgell | 1 | -1/+2 | |
2009-11-27 | torture: fixed SMB2-LOCK valgrind error | Andrew Tridgell | 1 | -1/+2 | |
2009-11-27 | s4-smb2: check for invalid SMB2 lock ranges | Andrew Tridgell | 1 | -0/+6 | |