Age | Commit message (Collapse) | Author | Files | Lines |
|
was a real bug
(This used to be commit 02d5d0f685e44bd66aff4a007f0bf34c8f915574)
|
|
this test now passes
(This used to be commit 3d270fd86caedd1023373160934d72d8cb065659)
|
|
and sends
it now passes the non-blocking test suite
(This used to be commit 6cdf485fb263c69d62ea2e98236d92ffbf6b7a3e)
|
|
(This used to be commit 1e62aa262aac1c8e3676caac7b65086d21b7a01e)
|
|
as randomly short recv/send when socket:testnonblock is enabled
(This used to be commit 718175a265d34bfdbcbf0cc6b55dbf6b389f3194)
|
|
(This used to be commit 5e8fd27d6ec7f44e6e802a2f29ec54e96fa78af0)
|
|
didn't handle EINTR or EAGAIN)
(This used to be commit c35a8f92c2df354e972ced9371d33657ce99988e)
|
|
allows me to test with the socket:testnonblock option. It passes.
(This used to be commit 7cb4bf8662825d507d8246647ffb10aa08bad794)
|
|
you set this option (either on the command line using --option or in
smb.conf) then every socket recv or send will return short by random
amounts. This allows you to test that the non-blocking socket logic in
your code works correctly.
I also removed the flags argument to socket_accept(), and instead made
the new socket inherit the flags of the old socket, which makes more
sense to me.
(This used to be commit 406d356e698da01c84e8aa5b7894752b4403f63c)
|
|
SOCKET_FLAG_BLOCK is set.
(This used to be commit a2d92aa431e0e9752387eebe741d9e6f376f74d7)
|
|
wakeup all pending locks at once. This change means that we only
trigger this anti-stampede code for write locks, as for pending read
locks the correct behaviour is to stampede (as they will all succeed)
(This used to be commit 8021d1d74207db1204139309592b9d2f80f2bd0e)
|
|
Add tests for EnumForms, GetForm, AddForm, DeleteForm.
(This used to be commit 6c49ce976a5c6982fa83de4ea723cef5597c29ef)
|
|
(This used to be commit 5dcb300fca592cc62d325c47c857b046c90e7b42)
|
|
(This used to be commit 2d60a04f21da9dbe32c85b11afa98df74f5fd763)
|
|
(This used to be commit 52af866ffb427427d21daf11a4ca9a8b9881f1d5)
|
|
means the whole of the SMB handling code is now non-blocking.
(This used to be commit 30acedb943f0170d30e7b08925280d0dffc7873e)
|
|
haven't marked the socket non-blocking yet as I haven't checked that
the send path is OK for non-blocking.
(This used to be commit bda978cc2a921a888534054135b9325427425dd2)
|
|
it gets regularly tested when I make changes.
(This used to be commit e4216da824c8186df956d05742d96da05393c719)
|
|
The main change is to make socket_recv() take a pre-allocated buffer,
rather than allocating one itself. This allows non-blocking users of
this API to avoid a memcpy(). As a result our messaging code is now
about 10% faster, and the ncacn_ip_tcp and ncalrpc code is also
faster.
The second change was to remove the unused mem_ctx argument from
socket_send(). Having it there implied that memory could be allocated,
which meant the caller had to worry about freeing that memory (if for
example it is sending in a tight loop using the same memory
context). Removing that unused argument keeps life simpler for users.
(This used to be commit a16e4756cd68ca8aab4ffc59d4d9db0b6e44dbd1)
|
|
unmarshalling arrays.
(This used to be commit ee535b6801e553d0a180f18cc2c4b4438ee23de1)
|
|
need to be marked as subcontext(0).
GetPrinter tests now work for all info levels!
(This used to be commit 53bd02960e17f7517e0d6c4f489d27b8bdcc7582)
|
|
(This used to be commit dcdc6666d55c1ad006a5a4e58b337874478a66a4)
|
|
NT_STATUS_IS_ERR()
(This used to be commit 80a109de8458420ac0b40c563f4b3bc51424d759)
|
|
Dahyabhai <nalin@redhat.com>.
Jeremy.
(This used to be commit afed78f359a15809b2d9b7566e16ade294944fa9)
|
|
metze
(This used to be commit d331a83f08b492ea463fb8781b4c46a71f80bf42)
|
|
metze
(This used to be commit 177afd4855c66f46c82899b46f030803be63d52a)
|
|
can we decide to not break WinXP clients:-)
metze
(This used to be commit 5eb0ff78d5e68f488a439545fdaec90c28ef877a)
|
|
rather extensive test reveals some really bizarre error code
handling in w2k3.
- extended and simplified the RAW-CHKPATH test, making it easier to
read (note that Samba3 fails the new tests - jra may wish to look)
- marked RAW-CHKPATH as pass for pvfs
(This used to be commit 32dccf91cfa5b57f84dd6307720b3f45faa10ae0)
|
|
strings. Not sure how to write this as idl which maps to a char * but
at least devicemodes can be pulled off the wire sucessfully.
(This used to be commit dd20730a09935b0783b020a020ed9283ca1e4608)
|
|
(This used to be commit 891d87a71203fcee504875976a4ee61b84579c83)
|
|
(This used to be commit 4545ac9bfabf4af4b44cb72f30ed93273d9cdc37)
|
|
signed integer values for enum), and it is also very confusing to read.
Also, please align defines nicely. The value of SV_TYPE_DOMAIN_ENUM
was defined incorrectly, which became obvious when you align the
defines, but wasn't at all obvious in the original code.
- removed redundent defines in smb.h
(This used to be commit fe042b8e5ca15dfd986bc0c05d464214a51cc0cf)
|
|
the build on systems like solaris with the SunPRO compiler
(This used to be commit fe913ad11bf1c5e9fe04ed769a93b0ea16aa0a34)
|
|
uuid(1ff70682-0a51-30e8-076d-740be8cee98b) so we now accept
uuid("1ff70682-0a51-30e8-076d-740be8cee98b") in pidl, and
automagically add quotes only if needed
(This used to be commit 4aab2cb210eb9678bb72aebb33dcf6fd499206c1)
|
|
structures generate a single _empty_ element in the header
(This used to be commit 00ff1ca1d284bb698e98c773b18a29695e927605)
|
|
(This used to be commit 29fab12d0b1649046ab2abb08b51f9845c8f8116)
|
|
If a socket is non-blocking then adding MSG_DONTWAIT is pointless (it
does nothing), so all we lose is the ability to set non-blocking on a
packet-by-packet basis, which is not a very useful thing to have
anyway
if the socket is blocking then the code already adds MSG_WAITALL, so
MSG_DONTWAIT is also not needed in that case.
(This used to be commit b8a2afae67691a609b4a7a577fee3f9518adc9d2)
|
|
rather than doing everything itself. This greatly simplifies the
code, although I really don't like the socket_recv() interface (it
always allocates memory for you, which means an extra memcpy in this
code)
- fixed several bugs in the socket_ipv4.c code, in particular client
side code used a non-blocking connect but didn't handle EINPROGRESS,
so it had no chance of working. Also fixed the error codes, using
map_nt_error_from_unix()
- cleaned up and expanded map_nt_error_from_unix()
- changed interpret_addr2() to not take a mem_ctx. It makes absolutely
no sense to allocate a fixed size 4 byte structure like this. Dozens
of places in the code were also using interpret_addr2() incorrectly
(precisely because the allocation made no sense)
(This used to be commit 7f2c771b0e0e98c5c9e5cf662592d64d34ff1205)
|
|
interpret_addr() and if someone wants to add support to that function
for ipv6 then they are welcome to.
(This used to be commit 50377db11bb727b407744e0c50805c8f90810c16)
|
|
set at an arbitrary 5000)
- auto-cleanup old searches that the client forgot to close (common with old searches)
- expanded the RAW-SEARCH test to test more than 256 old searches, and
old search rewind (w2k3 fails this - it appears to not support rewind
on old style searches)
(This used to be commit bc83d823b2140a10007490bf0101843a886f99a6)
|
|
(This used to be commit cc93813e4a09c538ad485dc2b3cb4c9be34f3d18)
|
|
- removed BASE-TRANS2 from the list of tests to be worked on (its
already in the "passes" list)
(This used to be commit 8ba10229c3860b955de698c3e2660cf6d18e2f22)
|
|
(This used to be commit bc392d88b1fa34edfc922f43e190da003160a7d2)
|
|
- ensure that d_name from readdir is not used after closedir
(This used to be commit 5352613342c58192ae00618977041b98cd0ff7b6)
|
|
tools on Solaris.
(This used to be commit c5d338d06137fe7464849df02671d8ab833e3b4e)
|
|
(This used to be commit e5a0763655d8ccb929d2bf39bf099449b0dfcee7)
|
|
calls. This is needed to allow for "new files appear during a search"
behaviour
- pvfs now passes RAW-SEARCH
(This used to be commit 0d98f7653a1d58510a6cd4c2ac6c5e05c541109c)
|
|
(This used to be commit 05530bfb99011db8a00f5debcf8eec19b5e8a5d6)
|
|
directory open" implementation, as opposed to the "load the whole
directory" interface used now. This will be needed to pass RAW-SEARCH
(This used to be commit 692623c6c0a2c6817fddfa77cd1c2525c27145c4)
|
|
(This used to be commit cc58d249f973397bf800c9b56a5d4ab30fcda2b4)
|