Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2010-03-22 | s4:lsa Abstract crypto (un)wrapping in separate functions | Simo Sorce | 1 | -81/+89 | |
2010-03-23 | s4:registry - "LDB backend" - revert the length check for UTF16 strings | Matthias Dieter Wallnöfer | 1 | -10/+5 | |
Let this do the "convert_string_talloc" function as it was before. | |||||
2010-03-23 | Revert "s4:torture - WINREG RPC - reactivate test "SetValueExtended" for s4" | Matthias Dieter Wallnöfer | 1 | -2/+3 | |
This reverts commit 0f2cf82e5e52da6fc71742df7b13c9f372bcf113. Naturally we have to revert this for s4 until a new storage mechanism for binary REG_SZ and REG_*WORD values has been found. | |||||
2010-03-23 | s4:registry - "LDB backend" - revert the binary storage of "REG_SZ", ↵ | Matthias Dieter Wallnöfer | 1 | -110/+19 | |
"REG_DWORD" and "REG_QWORD" We agreed that this hack isn't the best of the possible solutions. | |||||
2010-03-23 | s4:ldb_modules/util.c - fix two counter variables to be "unsigned" | Matthias Dieter Wallnöfer | 1 | -2/+2 | |
2010-03-22 | s4:registry - "reg_key_del/add_abs": call "talloc_free" only on valid objects | Matthias Dieter Wallnöfer | 1 | -6/+6 | |
2010-03-22 | s4:registry - "reg_import_hive_key" - change a "talloc_steal" into a ↵ | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
"talloc_reference" Use a "talloc_reference" since the "hive" variable can continue to exist also after the destructed "struct local_key" object. It is also referenced by the "mountpoints" structure under the "ctx" object. | |||||
2010-03-22 | s4:registry - "patchfile" - add another "W_ERROR_HAVE_NO_MEMORY" macro call | Matthias Dieter Wallnöfer | 1 | -0/+1 | |
2010-03-22 | s4:registry - "local" - add also here more "W_ERROR_HAVE_NO_MEMORY" macro tests | Matthias Dieter Wallnöfer | 1 | -8/+26 | |
2010-03-22 | s4:registry - "util.c" - initialise "result" in "reg_key_add_abs" | Matthias Dieter Wallnöfer | 1 | -0/+2 | |
2010-03-22 | s4:WINREG RPC - add also here a "W_ERROR_HAVE_NO_MEMORY" | Matthias Dieter Wallnöfer | 1 | -0/+1 | |
2010-03-22 | s4:registry - "samba.c" - add a "talloc_free" | Matthias Dieter Wallnöfer | 1 | -0/+2 | |
2010-03-22 | s4:registry - add more "W_ERROR_HAVE_NO_MEMORY" invocations (on talloc'ed stuff) | Matthias Dieter Wallnöfer | 4 | -1/+13 | |
2010-03-22 | s4:registry - "util" - remove "const" from "reg_abs_path" | Matthias Dieter Wallnöfer | 1 | -3/+3 | |
Here it's not really needed | |||||
2010-03-22 | s4:registry - adaptions for "add also a memory context argument for ↵ | Matthias Dieter Wallnöfer | 2 | -2/+2 | |
"reg_key_del_abs" | |||||
2010-03-22 | s4:registry - "util" - add also a memory context argument for "reg_key_del_abs" | Matthias Dieter Wallnöfer | 2 | -5/+4 | |
2010-03-22 | s4:registry - "util" - make "reg_key_add_abs" consistent with "reg_key_del_abs" | Matthias Dieter Wallnöfer | 1 | -6/+3 | |
2010-03-22 | s4:registry - "util" - fix up memory allocated data | Matthias Dieter Wallnöfer | 1 | -1/+10 | |
2010-03-22 | s4:registry - "dir.c" - fix up dynamic memory allocation operations | Matthias Dieter Wallnöfer | 1 | -15/+50 | |
- Added free operations where needed - Use always the "mem_ctx" for temporary data - Proof with W_ERROR_HAVE_NO_MEMORY if stuff was allocated | |||||
2010-03-22 | s4:registry - adaptions for "add memory contexts for delete value/key functions" | Matthias Dieter Wallnöfer | 14 | -64/+59 | |
2010-03-22 | s4:registry - registry.h - add memory contexts for delete value/key functions | Matthias Dieter Wallnöfer | 1 | -8/+16 | |
2010-03-22 | s4:registry - "RPC backend" - use "talloc_steal" and not "talloc_reference" | Matthias Dieter Wallnöfer | 1 | -4/+4 | |
No need to create additional references but we need to assign the strings to the right context. | |||||
2010-03-22 | s4:registry - "patchfile" - check if strings could be allocated | Matthias Dieter Wallnöfer | 1 | -0/+10 | |
2010-03-22 | s4:registry - "patchfile" - initialise the data blobs | Matthias Dieter Wallnöfer | 1 | -2/+2 | |
2010-03-22 | s4:registry - "patchfile" - add more "talloc_free"s to save memory | Matthias Dieter Wallnöfer | 1 | -5/+30 | |
2010-03-22 | s4:registry - "util.c" - "reg_string_to_val" - consider always the return values | Matthias Dieter Wallnöfer | 1 | -7/+9 | |
In some cases we didn't consider them. | |||||
2010-03-22 | s4:registry - "patchfile_preg.c" - also here don't accumulate the memory usage | Matthias Dieter Wallnöfer | 1 | -4/+26 | |
Free always the unused stuff. | |||||
2010-03-22 | s4:registry - "patchfile_dotreg.c" - fix a memory leak | Matthias Dieter Wallnöfer | 1 | -3/+5 | |
Here we allocate memory on the "NULL" context through "reg_val_data_string" on each call of "set_value". So when we have written out the allocated data on the specified file descriptor we should immediately free this memory! Otherwise we may end up with a big memory consumption on big registry databases. | |||||
2010-03-22 | s4:registry - "patchfile" - add comments | Matthias Dieter Wallnöfer | 1 | -0/+6 | |
Helps to understand when we need to generate the hive diffs. | |||||
2010-03-22 | s4-selftest: fix selftest-vars script. | Günther Deschner | 1 | -1/+1 | |
Tridge, please check. Guenther | |||||
2010-03-22 | s4:dsdb Add a shortcut sequence number for schema reloads | Andrew Bartlett | 2 | -14/+81 | |
This uses the ldb sequence number, in a hope to detect an unchanged schema quicker. Andrew Bartlett | |||||
2010-03-22 | s4:dsdb Rework schema loading and add schema reloading | Andrew Bartlett | 3 | -131/+185 | |
This commit reworks Samba4's schema loading code to detect when it needs to reload the schema. This is done by watching the @REPLCHANGED special DN. The reload happens by means of a callback, which is only set when the schema is loaded from the ldb - not when loaded from an LDIF file or DRS. We also rework the global schema handling - instead of storing the pointer to the global schema in each ldb, we store a flag indicating that the global schema should be returned at run time. This makes it much easier to switch to a new global schema. Andrew Bartlett | |||||
2010-03-22 | s4:dsdb Move dsdb_save_partition_usn() to be a module helper function | Andrew Bartlett | 3 | -92/+178 | |
This function should not traverse the module stack again, but instead run from this point. Also add a matching dsdb_module_load_partition_usn() and change repl_meta_data to match. Andrew Bartlett | |||||
2010-03-22 | s4:schema Expand the schema structure | Andrew Bartlett | 2 | -0/+11 | |
We now store the location of the schema in the schema, and provide hooks for a future schema reloading mechanism. Andrew Bartlett | |||||
2010-03-22 | s4:dsdb Remove unused 'dsdb_make_schema_global' call from pyglue | Andrew Bartlett | 1 | -17/+0 | |
2010-03-22 | s4:dsdb Add 'const' to some struct dsdb_schema variables | Andrew Bartlett | 2 | -9/+9 | |
We don't currently require this, but we may move this way in future. | |||||
2010-03-22 | s4:dsdb Don't load the schema unconditionally | Andrew Bartlett | 2 | -3/+19 | |
Schema loads now come at a price, so avoid doing them if we don't have to (such as when doing an @REPLCHANGED or other special DN based search). Andrew Bartlett | |||||
2010-03-22 | s4:registry - "patchfile.c" - consider also the hives in the generated diffs | Matthias Dieter Wallnöfer | 1 | -0/+9 | |
Apparently the diffs for the hives weren't generated previously. | |||||
2010-03-22 | s4:registry - "patchfile.c" - fix a typo | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2010-03-21 | s4:regtree - fix counter variables to be "unsigned" | Matthias Dieter Wallnöfer | 1 | -3/+4 | |
2010-03-21 | s4:registry - "LDB backend" - "reg_ldb_unpack_value" | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
When the name isn't found it is the default value. Call it "" to be consistent. | |||||
2010-03-21 | s4:registry - "LDB backend" - "reg_key_get_info" | Matthias Dieter Wallnöfer | 1 | -2/+29 | |
Consider also the default value (if it exists) as value. That means: - count it when setting "num_values" - take also his buffer length as a candidate for the maximum value buffer length This is what Windows does. | |||||
2010-03-21 | s4:registry - "LDB backend" - "ldb_get_default_value" | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
There exist also key objects (the hives) which don't contain a "key" entry at all. This prevented to display their default value (my fault). | |||||
2010-03-21 | s4:registry - "LDB backend" - make the key argument "const" of ↵ | Matthias Dieter Wallnöfer | 1 | -1/+2 | |
ldb_get_default_value | |||||
2010-03-21 | s4:registry - "LDB backend" - fix indentation | Matthias Dieter Wallnöfer | 1 | -2/+2 | |
2010-03-21 | s4:regshell - here we don't need a newline - "ctime" itself provides one | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2010-03-21 | s4:regshell - don't return an error code if we get a security descriptors error | Matthias Dieter Wallnöfer | 1 | -2/+2 | |
s4 itself doesn't support them so print only the error code out (in s4's case WERR_NOT_SUPPORTED). | |||||
2010-03-21 | s4:registry - "LDB backend" - reg_key_get_info - adapt max. subkey and value ↵ | Matthias Dieter Wallnöfer | 1 | -8/+8 | |
length Those lengths are measured in UTF8 string lengths and not in UTF16 ones (the returned strings are generally in this format). Discovered this by checking the s3 registry code. Therefore we have to multiply the both numbers by two. Discovered with the "regedt32" (old NT registry editor). | |||||
2010-03-21 | s4:WINREG RPC server - don't check for the "name" size in "EnumValue" | Matthias Dieter Wallnöfer | 1 | -5/+0 | |
This isn't needed at all since: 1.) a new name object is created and sent back to the client 2.) the "size" seems to be the size of the "name" pointer. On my test with the "regedt32" program this has always been "4". | |||||
2010-03-21 | s4:torture - WINREG RPC - reactivate test "SetValueExtended" for s4 | Matthias Dieter Wallnöfer | 1 | -3/+2 | |
Should be definitely fixed now. |