From 0c639097cf033b25c956222c72622e6b97695f59 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vlendec@samba.org>
Date: Wed, 17 Nov 2004 21:22:35 +0000
Subject: r3824: Fix crash in api_RNetShareEnum. ServicePtrs[] may contain
 invalid entries. Happened after rev3708 removed non-existing cups printers.

Volker
(This used to be commit 60998d9d2f6272e383304da2b1d568a4b65f8787)
---
 source3/smbd/lanman.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/source3/smbd/lanman.c b/source3/smbd/lanman.c
index 1379877efc..aeea9de9ca 100644
--- a/source3/smbd/lanman.c
+++ b/source3/smbd/lanman.c
@@ -1502,6 +1502,8 @@ static BOOL api_RNetShareEnum( connection_struct *conn,
   data_len = fixed_len = string_len = 0;
   for (i=0;i<count;i++) {
     fstring servicename_dos;
+    if (!(lp_browseable(i) && lp_snum_ok(i)))
+	    continue;
     push_ascii_fstring(servicename_dos, lp_servicename(i));
     if( lp_browseable( i )
         && lp_snum_ok( i )
@@ -1530,6 +1532,8 @@ static BOOL api_RNetShareEnum( connection_struct *conn,
   for( i = 0; i < count; i++ )
     {
     fstring servicename_dos;
+    if (!(lp_browseable(i) && lp_snum_ok(i)))
+	    continue;
     push_ascii_fstring(servicename_dos, lp_servicename(i));
     if( lp_browseable( i )
         && lp_snum_ok( i )
-- 
cgit