From 0d425487da05db23a1a2f0f67e34bce3c5d80d7e Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Wed, 17 Aug 2005 13:09:42 +0000 Subject: r9359: don't check for size overflow if value is NULL this gets viewing the product options in smbd HKLM from w2k3 regedit working (This used to be commit 17f3250dd61bc9aad5cf3804e271383e219752f6) --- source4/rpc_server/winreg/rpc_winreg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source4/rpc_server/winreg/rpc_winreg.c b/source4/rpc_server/winreg/rpc_winreg.c index 2cbac091bb..400041451f 100644 --- a/source4/rpc_server/winreg/rpc_winreg.c +++ b/source4/rpc_server/winreg/rpc_winreg.c @@ -209,7 +209,8 @@ static WERROR winreg_EnumValue(struct dcesrv_call_state *dce_call, TALLOC_CTX *m } /* check the client has enough room for the value */ - if (r->in.size != NULL && + if (r->in.value != NULL && + r->in.size != NULL && value->data_len > *r->in.size) { return WERR_MORE_DATA; } -- cgit