From 1e2e92f54d90c59a2a340728d3adc3cac1dd8133 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Mon, 25 Jan 2010 17:38:55 -0800 Subject: Correct fix for unused variable return from ndr_decode. Use it :-). Jeremy. --- source3/smbd/dosmode.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/source3/smbd/dosmode.c b/source3/smbd/dosmode.c index aaef09bc85..e5d6bc32e8 100644 --- a/source3/smbd/dosmode.c +++ b/source3/smbd/dosmode.c @@ -264,6 +264,14 @@ static bool get_ea_dos_attribute(connection_struct *conn, ndr_err = ndr_pull_struct_blob(&blob, talloc_tos(), NULL, &dosattrib, (ndr_pull_flags_fn_t)ndr_pull_xattr_DOSATTRIB); + if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) { + DEBUG(1,("get_ea_dos_attributes: bad ndr decode " + "from EA on file %s: Error = %s\n", + smb_fname_str_dbg(smb_fname), + ndr_errstr(ndr_err))); + return false; + } + DEBUG(10,("get_ea_dos_attribute: %s attr = %s\n", smb_fname_str_dbg(smb_fname), dosattrib.attrib_hex)); -- cgit