From 2311a2c9f5fdcb6f8336dbdb972963a35890a200 Mon Sep 17 00:00:00 2001 From: Kai Blin Date: Wed, 5 Sep 2012 01:27:00 +0200 Subject: s4 dns: Allow configuring signed updates Autobuild-User(master): Kai Blin Autobuild-Date(master): Wed Sep 5 10:45:22 CEST 2012 on sn-devel-104 --- source4/dns_server/dns_update.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/source4/dns_server/dns_update.c b/source4/dns_server/dns_update.c index e7514acace..61850a1056 100644 --- a/source4/dns_server/dns_update.c +++ b/source4/dns_server/dns_update.c @@ -734,10 +734,15 @@ WERROR dns_server_process_update(struct dns_server *dns, /* TODO: Check if update is allowed, we probably want "always", * key-based GSSAPI, key-based bind-style TSIG and "never" as * smb.conf options. */ - if (lpcfg_allow_dns_updates(dns->task->lp_ctx) != DNS_UPDATE_ON) { + if (lpcfg_allow_dns_updates(dns->task->lp_ctx) == DNS_UPDATE_OFF) { DEBUG(0, ("Update not allowed.\n")); return DNS_ERR(REFUSED); } + if (lpcfg_allow_dns_updates(dns->task->lp_ctx) == DNS_UPDATE_SIGNED && + state->authenticated == false ) { + DEBUG(0, ("Update not allowed for unsigned packet.\n")); + return DNS_ERR(REFUSED); + } *update_count = in->nscount; *updates = in->nsrecs; -- cgit