From 27655be3c1708d447b046a2b0d8b2013eeb21835 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Fri, 11 Jan 2002 13:14:28 +0000 Subject: fixed a crash bug in domain auth caused by an uninitialised nt_status (This used to be commit 0b0b937b58f4bf4e005fb622f0db19175fc46a47) --- source3/auth/auth_domain.c | 2 +- source3/libsmb/cliconnect.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/source3/auth/auth_domain.c b/source3/auth/auth_domain.c index a81af3b738..eba61114d6 100644 --- a/source3/auth/auth_domain.c +++ b/source3/auth/auth_domain.c @@ -242,7 +242,7 @@ static NTSTATUS domain_client_validate(TALLOC_CTX *mem_ctx, fstring remote_machine; NET_USER_INFO_3 info3; struct cli_state *cli; - NTSTATUS nt_status; + NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL; struct passwd *pass; /* diff --git a/source3/libsmb/cliconnect.c b/source3/libsmb/cliconnect.c index 7649a88ffd..1812416426 100644 --- a/source3/libsmb/cliconnect.c +++ b/source3/libsmb/cliconnect.c @@ -1270,6 +1270,7 @@ again: DEBUG(1,("failed session setup\n")); nt_status = cli_nt_error(cli); cli_shutdown(cli); + if (NT_STATUS_IS_OK(nt_status)) nt_status = NT_STATUS_UNSUCCESSFUL; return nt_status; } @@ -1281,6 +1282,7 @@ again: DEBUG(1,("failed tcon_X\n")); nt_status = cli_nt_error(cli); cli_shutdown(cli); + if (NT_STATUS_IS_OK(nt_status)) nt_status = NT_STATUS_UNSUCCESSFUL; return nt_status; } } -- cgit