From 31f0e24fbe5f3da7e1a3e4b0ae234c0803123501 Mon Sep 17 00:00:00 2001 From: Jelmer Vernooij Date: Thu, 22 Nov 2012 00:46:55 +0000 Subject: web_server/wsgi: Don't segfault when wsgi app doesn't return iterable. There is a bug in the application if this happens, but invalid Python code shouldn't cause segfaults. Reviewed-by: Matthieu Patou --- source4/web_server/wsgi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/source4/web_server/wsgi.c b/source4/web_server/wsgi.c index 37ded29480..3f8141c5e2 100644 --- a/source4/web_server/wsgi.c +++ b/source4/web_server/wsgi.c @@ -369,6 +369,11 @@ static void wsgi_process_http_input(struct web_server_data *wdata, iter = PyObject_GetIter(result); Py_DECREF(result); + if (iter == NULL) { + DEBUG(0, ("wsgi application did not return iterable\n")); + return; + } + /* Now, iter over all the data returned */ while ((item = PyIter_Next(iter))) { -- cgit