From 45a2713b475e66a880b4c6f019dc22119444dc7b Mon Sep 17 00:00:00 2001 From: James Peach Date: Fri, 14 Sep 2007 04:17:17 +0000 Subject: r25142: Panic if setting the group list fails while switching security contexts. Patch from Tim Prouty . (This used to be commit a136de663f122603e8d34e06027896ff39b35e11) --- source3/smbd/sec_ctx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/source3/smbd/sec_ctx.c b/source3/smbd/sec_ctx.c index 67b15dc014..108d1794c7 100644 --- a/source3/smbd/sec_ctx.c +++ b/source3/smbd/sec_ctx.c @@ -239,7 +239,9 @@ static void set_unix_security_ctx(uid_t uid, gid_t gid, int ngroups, gid_t *grou /* Start context switch */ gain_root(); #ifdef HAVE_SETGROUPS - sys_setgroups(gid, ngroups, groups); + if (sys_setgroups(gid, ngroups, groups) != 0) { + smb_panic("sys_setgroups failed"); + } #endif become_id(uid, gid); /* end context switch */ @@ -282,6 +284,7 @@ static void set_unix_security_ctx(uid_t uid, gid_t gid, int ngroups, gid_t *grou DEBUG(0, ("WARNING: failed to set group list " "(%d groups) for UID %ld: %s\n", ngroups, uid, strerror(errno))); + smb_panic("sys_setgroups failed"); } become_uid(uid); -- cgit