From 4a57f9763a7b8ab5114bbecf9e1096b66174137f Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Tue, 25 Apr 2000 00:46:24 +0000 Subject: fixed a memory leak of devmode in spoolss this stuff is screaming out for talloc() rather than malloc/free (This used to be commit e9576124cbe8322ed7bee9f4e72b5d1753ee0bac) --- source3/rpc_server/srv_spoolss.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/source3/rpc_server/srv_spoolss.c b/source3/rpc_server/srv_spoolss.c index aaa87fe6ff..da7db8e557 100755 --- a/source3/rpc_server/srv_spoolss.c +++ b/source3/rpc_server/srv_spoolss.c @@ -50,6 +50,9 @@ static BOOL api_spoolss_open_printer_ex(prs_struct *data, prs_struct *rdata) q_u.user_switch, q_u.user_ctr, &r_u.handle); + /* we _really_ need to switch to talloc() */ + safe_free(q_u.printer_default.devmode_cont.devmode); + if (!spoolss_io_r_open_printer_ex("",&r_u,rdata,0)){ DEBUG(0,("spoolss_io_r_open_printer_ex: unable to marshall SPOOL_R_OPEN_PRINTER_EX.\n")); return False; -- cgit