From 4b354e67fc7adce5152c73697bbf02a1aac69b20 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 15 Feb 2011 18:16:43 +0100 Subject: s3-amend: Don't overwrite existing values MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This saves a ton of tdb transactions on smbd startup Andreas, Günther, please check! Autobuild-User: Volker Lendecke Autobuild-Date: Tue Feb 15 19:11:25 CET 2011 on sn-devel-104 --- source3/registry/reg_api.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/source3/registry/reg_api.c b/source3/registry/reg_api.c index acce7ab1b4..7c2e01dccc 100644 --- a/source3/registry/reg_api.c +++ b/source3/registry/reg_api.c @@ -659,6 +659,7 @@ done: WERROR reg_setvalue(struct registry_key *key, const char *name, const struct registry_value *val) { + struct regval_blob *existing; WERROR err; int res; @@ -670,6 +671,15 @@ WERROR reg_setvalue(struct registry_key *key, const char *name, return err; } + existing = regval_ctr_getvalue(key->values, name); + + if ((existing != NULL) && + (regval_size(existing) == val->data.length) && + (memcmp(regval_data_p(existing), val->data.data, + val->data.length) == 0)) { + return WERR_OK; + } + res = regval_ctr_addvalue(key->values, name, val->type, val->data.data, val->data.length); -- cgit