From 4c991c6edd2a46d7452096ba80c00e7ab4c95924 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Fri, 30 Apr 2004 12:52:58 +0000 Subject: r425: add some comments to ugly code parts we should take care of 'char *' and 'const char *' and DO NOT mix them! Jelmer: please fix this metze (This used to be commit cd609eb2fe9303825d5562047d57fd553b2601bd) --- source4/lib/registry/common/reg_interface.c | 2 +- source4/lib/registry/reg_backend_rpc/reg_backend_rpc.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/source4/lib/registry/common/reg_interface.c b/source4/lib/registry/common/reg_interface.c index fdbb7345d2..3600ab62ea 100644 --- a/source4/lib/registry/common/reg_interface.c +++ b/source4/lib/registry/common/reg_interface.c @@ -160,7 +160,6 @@ WERROR reg_open_key(REG_KEY *parent, const char *name, REG_KEY **result) mem_ctx = talloc_init("mem_ctx"); fullname = talloc_asprintf(mem_ctx, "%s%s%s", parent->path, parent->path[strlen(parent->path)-1] == '\\'?"":"\\", name); -\ if(!parent->handle->functions->open_key) { DEBUG(0, ("Registry backend doesn't have get_subkey_by_name nor open_key!\n")); @@ -432,6 +431,7 @@ WERROR reg_key_add_name_recursive(REG_KEY *parent, const char *path) { REG_KEY *cur, *prevcur = parent; WERROR error; + /* FIXME: we should never write to a 'const char *' !!! --metze */ char *begin = (char *)path, *end; while(1) { diff --git a/source4/lib/registry/reg_backend_rpc/reg_backend_rpc.c b/source4/lib/registry/reg_backend_rpc/reg_backend_rpc.c index a24df893fb..de2c2261b9 100644 --- a/source4/lib/registry/reg_backend_rpc/reg_backend_rpc.c +++ b/source4/lib/registry/reg_backend_rpc/reg_backend_rpc.c @@ -234,6 +234,7 @@ static WERROR rpc_get_value_by_index(REG_KEY *parent, int n, REG_VAL **value) if(vn.max_len > 0) { vn.len = 0; vn.max_len = mykeydata->max_valnamelen*2; + /* FIXME: we should not point a 'char *' to a const buffer!!! --metze*/ vn.buf = ""; } r.in.name = r.out.name = &vn; -- cgit