From 56eb4ab5f6280aa40c0e0edefad7f965b3f02a4a Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn@samba.org>
Date: Wed, 19 Dec 2012 11:20:50 +0100
Subject: s3-rpc_server: Fix username and remote check.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
---
 source3/rpc_server/wkssvc/srv_wkssvc_nt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source3/rpc_server/wkssvc/srv_wkssvc_nt.c b/source3/rpc_server/wkssvc/srv_wkssvc_nt.c
index ada83ea18d..daa44e9e28 100644
--- a/source3/rpc_server/wkssvc/srv_wkssvc_nt.c
+++ b/source3/rpc_server/wkssvc/srv_wkssvc_nt.c
@@ -183,8 +183,8 @@ static struct dom_usr *get_domain_userlist(TALLOC_CTX *mem_ctx)
 	}
 
 	for (i=num_users=0; i<num_sessions; i++) {
-		if (!session_list[i].username
-		    || !session_list[i].remote_machine) {
+		if (session_list[i].username[0] == '\0' ||
+		    session_list[i].remote_machine[0] == '\0') {
 			continue;
 		}
 		p = strpbrk(session_list[i].remote_machine, "./");
-- 
cgit