From 58221bfcf7d3e613a5cc84dea09f1dc0f9238d59 Mon Sep 17 00:00:00 2001
From: Gerald Carter <jerry@samba.org>
Date: Thu, 20 Jul 2000 13:38:48 +0000
Subject: Fixed unitilized secdesc pointer which was causing spoolgetprinter
 rpcclient command to fail on shared printers.

jerry
(This used to be commit c8abc31187dbfe6076277896b029fa11443e43bd)
---
 source3/rpc_client/msrpc_spoolss.c | 5 +++++
 source3/rpcclient/cmd_spoolss.c    | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/source3/rpc_client/msrpc_spoolss.c b/source3/rpc_client/msrpc_spoolss.c
index d8379048cf..10582c01be 100644
--- a/source3/rpc_client/msrpc_spoolss.c
+++ b/source3/rpc_client/msrpc_spoolss.c
@@ -92,6 +92,8 @@ static void decode_printer_info_2(NEW_BUFFER *buffer, uint32 returned,
         buffer->prs.data_offset=0;
 
         for (i=0; i<returned; i++) {
+		/* a little initialization as we go */
+		inf[i].secdesc = NULL;
                 new_smb_io_printer_info_2("", buffer, &(inf[i]), 0);
         }
 
@@ -356,6 +358,9 @@ BOOL msrpc_spoolss_enum_printerdata( const char* printer_name,
 	if(!spoolss_open_printer_ex( printer_name, 0, 0, station, user_name, &hnd))
 		return False;
 
+	/* FIXME!!!!  --jerry
+	   something is severly buggy about the use of 
+	   data, datalen, value, & valuelen */
 	status = spoolss_enum_printerdata(&hnd, 0, &valuelen, value, 
 					  &rvaluelen, &type, &datalen, 
 					  data, &rdatalen);
diff --git a/source3/rpcclient/cmd_spoolss.c b/source3/rpcclient/cmd_spoolss.c
index 2dd70bfd67..9b4da4f1af 100644
--- a/source3/rpcclient/cmd_spoolss.c
+++ b/source3/rpcclient/cmd_spoolss.c
@@ -337,8 +337,8 @@ uint32 cmd_spoolss_getprinterdata(struct client_info *info, int argc, char *argv
                                 printer_name, station, value_name));
 
         status = msrpc_spoolss_getprinterdata( printer_name, station,
-                                "Administrateur",
-                                /*usr_creds->ntc.user_name,*/
+                                /* "Administrateur", */
+                                usr_creds->ntc.user_name,
                                 value_name, &type,
                                 &ctr, NULL);
 
-- 
cgit