From 5a1606269aeeeb1b777974d88c33df543d1b6f4d Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sun, 15 Nov 2009 22:22:38 +0100 Subject: s3: Tune if-conditions in a very hot codepath This looks innocent, but it is visible in a netbench run. Due to boolean short-circuiting we don't have to execute the conditions on the right-hand side of the &&. So putting the less likely condition left gains a bit. --- source3/smbd/reply.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c index ae88db7562..682f56ff33 100644 --- a/source3/smbd/reply.c +++ b/source3/smbd/reply.c @@ -67,7 +67,7 @@ static NTSTATUS check_path_syntax_internal(char *path, } } - if (!posix_path && !stream_started && *s == ':') { + if ((*s == ':') && !posix_path && !stream_started) { if (*p_last_component_contains_wcard) { return NT_STATUS_OBJECT_NAME_INVALID; } -- cgit