From 5d4f474b58e209f171bd5976242db4a1dc2af2ee Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Fri, 23 Sep 2011 17:37:23 +1000 Subject: s4-dbchecker: fixed handling of DSDB DNs in dbcheck we need to use the original value, as ldb.Dn() can't parse a DSDB binary DN --- source4/scripting/python/samba/dbchecker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source4/scripting/python/samba/dbchecker.py b/source4/scripting/python/samba/dbchecker.py index 03303b8ab6..ea5a9030c6 100644 --- a/source4/scripting/python/samba/dbchecker.py +++ b/source4/scripting/python/samba/dbchecker.py @@ -256,7 +256,7 @@ class dbcheck(object): return m = ldb.Message() m.dn = dn - m['old_value'] = ldb.MessageElement(str(ldb.Dn(self.samdb, val)), ldb.FLAG_MOD_DELETE, attrname) + m['old_value'] = ldb.MessageElement(val, ldb.FLAG_MOD_DELETE, attrname) m['new_value'] = ldb.MessageElement(str(dsdb_dn), ldb.FLAG_MOD_ADD, attrname) if self.do_modify(m, ["show_recycled:1"], "Failed to fix incorrect DN string on attribute %s" % attrname): -- cgit