From 62646b7666178bf03cd650056a61338e84b54b25 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Thu, 6 Dec 2012 11:40:35 +0100 Subject: winbind: Use talloc in resolve_username_to_alias(). MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Found by Coverity. Signed-off-by: Andreas Schneider Reviewed-by: Günther Deschner --- source3/winbindd/winbindd_cache.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c index ffed27b397..76970d6be4 100644 --- a/source3/winbindd/winbindd_cache.c +++ b/source3/winbindd/winbindd_cache.c @@ -1111,16 +1111,18 @@ NTSTATUS resolve_username_to_alias( TALLOC_CTX *mem_ctx, if (!cache->tdb) goto do_query; - if ( (upper_name = SMB_STRDUP(name)) == NULL ) + upper_name = talloc_strdup(mem_ctx, name); + if (upper_name == NULL) { return NT_STATUS_NO_MEMORY; + } if (!strupper_m(upper_name)) { - SAFE_FREE(upper_name); + talloc_free(upper_name); return NT_STATUS_INVALID_PARAMETER; } centry = wcache_fetch(cache, domain, "NSS/NA/%s", upper_name); - SAFE_FREE( upper_name ); + talloc_free(upper_name); if (!centry) goto do_query; -- cgit