From 6bec071408c80a85dc2a7830d2cf4c48157b5187 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sun, 9 Dec 2007 19:46:06 +0100 Subject: Don't copy the rpc function pointers This actually shows up in a valgrind massif run with 4.1% of allocated memory. I don't see why we would have to make a copy here. Metze? (This used to be commit 616d6b97e594a846e9b3ac4cbe48538d649462e9) --- source3/rpc_server/srv_pipe.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/source3/rpc_server/srv_pipe.c b/source3/rpc_server/srv_pipe.c index 49ffcf13a6..5ede0c93f4 100644 --- a/source3/rpc_server/srv_pipe.c +++ b/source3/rpc_server/srv_pipe.c @@ -714,7 +714,7 @@ struct rpc_table { const char *clnt; const char *srv; } pipe; - struct api_struct *cmds; + const struct api_struct *cmds; int n_cmds; }; @@ -1075,12 +1075,8 @@ NTSTATUS rpc_pipe_register_commands(int version, const char *clnt, const char *s ZERO_STRUCTP(rpc_entry); rpc_entry->pipe.clnt = SMB_STRDUP(clnt); rpc_entry->pipe.srv = SMB_STRDUP(srv); - rpc_entry->cmds = SMB_REALLOC_ARRAY(rpc_entry->cmds, struct api_struct, rpc_entry->n_cmds + size); - if (!rpc_entry->cmds) { - return NT_STATUS_NO_MEMORY; - } - memcpy(rpc_entry->cmds + rpc_entry->n_cmds, cmds, size * sizeof(struct api_struct)); - rpc_entry->n_cmds += size; + rpc_entry->cmds = cmds; + rpc_entry->n_cmds = size; return NT_STATUS_OK; } -- cgit