From 6c9d22d1ed5cc886b7a7c886f7298fea8c60089c Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Tue, 4 Sep 2012 17:18:45 +1000 Subject: file_server: Clarify code by avoiding a goto As suggested by Ricky Nance Andrew Bartlett --- file_server/file_server.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/file_server/file_server.c b/file_server/file_server.c index a3efcb2418..e1560c202d 100644 --- a/file_server/file_server.c +++ b/file_server/file_server.c @@ -117,15 +117,13 @@ static void s3fs_task_init(struct task_server *task) NULL); if (req == NULL) { DEBUG(0, ("Failed to start smbd as child daemon\n")); - goto failed; + task_server_terminate(task, "Failed to startup s3fs smb task", true); + return; } tevent_req_set_callback(req, file_server_smbd_done, task); DEBUG(1,("Started file server smbd with config %s\n", fileserver_conf)); - return; -failed: - task_server_terminate(task, "Failed to startup s3fs smb task", true); } /* called at smbd startup - register ourselves as a server service */ -- cgit